Issues in TruncateTaskFieldProvider.php (master) - Issues in master - AOEpeople/TYPO3-Truncate-Job - Measure and Improve Code Quality continuously with Scrutinizer

Issues (2)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Classes/TruncateTaskFieldProvider.php (1 issue)

Labels

Coding Style 1

Severity

Informational 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Aoe\TruncateJob;

/***************************************************************
 *  Copyright notice
 *
 *  (c) 2018 AOE GmbH <[email protected]>
 *
 *  All rights reserved
 *
 *  This script is part of the TYPO3 project. The TYPO3 project is
 *  free software; you can redistribute it and/or modify
 *  it under the terms of the GNU General Public License as published by
 *  the Free Software Foundation; either version 3 of the License, or
 *  (at your option) any later version.
 *
 *  The GNU General Public License can be found at
 *  http://www.gnu.org/copyleft/gpl.html.
 *
 *  This script is distributed in the hope that it will be useful,
 *  but WITHOUT ANY WARRANTY; without even the implied warranty of
 *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 *  GNU General Public License for more details.
 *
 *  This copyright notice MUST APPEAR in all copies of the script!
 ***************************************************************/

use TYPO3\CMS\Scheduler\AdditionalFieldProviderInterface;

/**
 * Export Task for scheduler
 */
class TruncateTaskFieldProvider implements AdditionalFieldProviderInterface {
    /**
     * @param array $taskInfo
     * @param TruncateTask $task
     * @param \TYPO3\CMS\Scheduler\Controller\SchedulerModuleController $schedulerModule
     * @return array
     */
    public function getAdditionalFields(array &$taskInfo, $task, \TYPO3\CMS\Scheduler\Controller\SchedulerModuleController $schedulerModule) {
		if (empty($taskInfo['tables'])) {
			if ($schedulerModule->CMD == 'edit') {
				$taskInfo['tables'] = $task->getTables();
			} else {
				$taskInfo['tables'] = '';
			}
		}
	
		$fieldID = 'task_tables';
		$fieldCode = '<input type="text" name="tx_scheduler[tables]" id="' . $fieldID . '" value="'.$taskInfo ['tables'].'" size="30" class="form-control" />';
		$additionalFields = [];
		$additionalFields[$fieldID] = ['code' => $fieldCode, 'label' => 'Tables (comma seperated)'];
		return $additionalFields;
	}

    /**
     * @param array $submittedData
     * @param \TYPO3\CMS\Scheduler\Task\AbstractTask $task
     */
    public function saveAdditionalFields(array $submittedData, \TYPO3\CMS\Scheduler\Task\AbstractTask $task) {
        /** @var TruncateTask $task */
		$task->setTables($submittedData['tables']);
	}

    /**
     * @param array $submittedData
     * @param \TYPO3\CMS\Scheduler\Controller\SchedulerModuleController $schedulerModule
     * @return bool
     */
    public function validateAdditionalFields(array &$submittedData, \TYPO3\CMS\Scheduler\Controller\SchedulerModuleController $schedulerModule) {
		return true;
	}
}


1			<?php
			0 ignored issues – show Coding Style introduced 2018-01-08 11:59 UTC by Report Bug Copy Issue Report Show Similar Issues like this End of line character is invalid; expected "\n" but found "\r\n" Loading history...
2			namespace Aoe\TruncateJob;
3
4			/***************************************************************
5			* Copyright notice
6			*
7			* (c) 2018 AOE GmbH <[email protected]>
8			*
9			* All rights reserved
10			*
11			* This script is part of the TYPO3 project. The TYPO3 project is
12			* free software; you can redistribute it and/or modify
13			* it under the terms of the GNU General Public License as published by
14			* the Free Software Foundation; either version 3 of the License, or
15			* (at your option) any later version.
16			*
17			* The GNU General Public License can be found at
18			* http://www.gnu.org/copyleft/gpl.html.
19			*
20			* This script is distributed in the hope that it will be useful,
21			* but WITHOUT ANY WARRANTY; without even the implied warranty of
22			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
23			* GNU General Public License for more details.
24			*
25			* This copyright notice MUST APPEAR in all copies of the script!
26			***************************************************************/
27
28			use TYPO3\CMS\Scheduler\AdditionalFieldProviderInterface;
29
30			/**
31			* Export Task for scheduler
32			*/
33			class TruncateTaskFieldProvider implements AdditionalFieldProviderInterface {
34			/**
35			* @param array $taskInfo
36			* @param TruncateTask $task
37			* @param \TYPO3\CMS\Scheduler\Controller\SchedulerModuleController $schedulerModule
38			* @return array
39			*/
40			public function getAdditionalFields(array &$taskInfo, $task, \TYPO3\CMS\Scheduler\Controller\SchedulerModuleController $schedulerModule) {
41			if (empty($taskInfo['tables'])) {
42			if ($schedulerModule->CMD == 'edit') {
43			$taskInfo['tables'] = $task->getTables();
44			} else {
45			$taskInfo['tables'] = '';
46			}
47			}
48
49			$fieldID = 'task_tables';
50			$fieldCode = '<input type="text" name="tx_scheduler[tables]" id="' . $fieldID . '" value="'.$taskInfo ['tables'].'" size="30" class="form-control" />';
51			$additionalFields = [];
52			$additionalFields[$fieldID] = ['code' => $fieldCode, 'label' => 'Tables (comma seperated)'];
53			return $additionalFields;
54			}
55
56			/**
57			* @param array $submittedData
58			* @param \TYPO3\CMS\Scheduler\Task\AbstractTask $task
59			*/
60			public function saveAdditionalFields(array $submittedData, \TYPO3\CMS\Scheduler\Task\AbstractTask $task) {
61			/** @var TruncateTask $task */
62			$task->setTables($submittedData['tables']);
63			}
64
65			/**
66			* @param array $submittedData
67			* @param \TYPO3\CMS\Scheduler\Controller\SchedulerModuleController $schedulerModule
68			* @return bool
69			*/
70			public function validateAdditionalFields(array &$submittedData, \TYPO3\CMS\Scheduler\Controller\SchedulerModuleController $schedulerModule) {
71			return true;
72			}
73			}
74

AOEpeople / TYPO3-Truncate-Job

Issues (2)

Security Analysis no request data

Classes/TruncateTaskFieldProvider.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like