AOEpeople /
TYPO3-Feature-Flag
Complex classes like Tx_FeatureFlag_System_Typo3_TCA often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Tx_FeatureFlag_System_Typo3_TCA, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 31 | class Tx_FeatureFlag_System_Typo3_TCA |
||
| 32 | { |
||
| 33 | /** |
||
| 34 | * @var string |
||
| 35 | */ |
||
| 36 | const FIELD_BEHAVIOR = 'tx_featureflag_behavior'; |
||
| 37 | |||
| 38 | /** |
||
| 39 | * @var string |
||
| 40 | */ |
||
| 41 | const FIELD_FLAG = 'tx_featureflag_flag'; |
||
| 42 | |||
| 43 | /** |
||
| 44 | * @var Tx_FeatureFlag_Domain_Repository_FeatureFlag |
||
| 45 | */ |
||
| 46 | protected $featureFlagRepository; |
||
| 47 | |||
| 48 | /** |
||
| 49 | * @var \TYPO3\CMS\Extbase\Object\ObjectManager |
||
| 50 | */ |
||
| 51 | protected $objectManager; |
||
| 52 | |||
| 53 | /** |
||
| 54 | * @var \TYPO3\CMS\Extbase\Persistence\Generic\PersistenceManager |
||
| 55 | */ |
||
| 56 | protected $persistenceManager; |
||
| 57 | |||
| 58 | /** |
||
| 59 | * @var \TYPO3\CMS\Extbase\Persistence\QueryResultInterface |
||
| 60 | */ |
||
| 61 | protected static $hashedMappings; |
||
| 62 | |||
| 63 | |||
| 64 | /** |
||
| 65 | * @param array $PA |
||
| 66 | * @return string |
||
| 67 | */ |
||
| 68 | public function renderSelectForFlag(array $PA) |
||
| 91 | |||
| 92 | /** |
||
| 93 | * @param array $PA |
||
| 94 | * @return string |
||
| 95 | */ |
||
| 96 | public function renderInfo(array $PA) |
||
| 101 | |||
| 102 | /** |
||
| 103 | * @param array $PA |
||
| 104 | * @return string |
||
| 105 | */ |
||
| 106 | public function renderSelectForBehavior(array $PA) |
||
| 137 | |||
| 138 | /** |
||
| 139 | * Hook for updates in Typo3 backend |
||
| 140 | * @param array $incomingFieldArray |
||
| 141 | * @param string $table |
||
| 142 | * @param integer $id |
||
| 143 | * @param \TYPO3\CMS\Core\DataHandling\DataHandler $tceMain |
||
| 144 | * @codingStandardsIgnoreStart |
||
| 145 | */ |
||
| 146 | public function processDatamap_preProcessFieldArray( |
||
| 160 | |||
| 161 | /** |
||
| 162 | * Hook for deletes in Typo3 Backend. It also delete all overwrite protection |
||
| 163 | * @param string $command |
||
| 164 | * @param string $table |
||
| 165 | * @param integer $id |
||
| 166 | * @codingStandardsIgnoreStart |
||
| 167 | */ |
||
| 168 | public function processCmdmap_postProcess($command, $table, $id) |
||
| 185 | |||
| 186 | /** |
||
| 187 | * @param string $table |
||
| 188 | * @param array $row |
||
| 189 | * @param string $status |
||
| 190 | * @param string $iconName |
||
| 191 | * @return string |
||
| 192 | */ |
||
| 193 | public function postOverlayPriorityLookup($table, $row, &$status, $iconName) |
||
| 212 | |||
| 213 | /** |
||
| 214 | * @param string $table |
||
| 215 | * @param int $id |
||
| 216 | * @param int $featureFlag |
||
| 217 | * @param int $pid |
||
| 218 | * @param string $behavior |
||
| 219 | */ |
||
| 220 | protected function updateMapping($table, $id, $featureFlag, $pid, $behavior) |
||
| 246 | |||
| 247 | /** |
||
| 248 | * @param int $foreignTableUid |
||
| 249 | * @param string $foreignTableName |
||
| 250 | * @return bool |
||
| 251 | */ |
||
| 252 | protected function isMappingAvailableForTableAndUid($foreignTableUid, $foreignTableName) |
||
| 264 | |||
| 265 | /** |
||
| 266 | * @param int $uid |
||
| 267 | * @return Tx_FeatureFlag_Domain_Model_FeatureFlag |
||
| 268 | * @throws Tx_FeatureFlag_Service_Exception_FeatureNotFound |
||
| 269 | */ |
||
| 270 | protected function getFeatureFlagByUid($uid) |
||
| 280 | |||
| 281 | /** |
||
| 282 | * @return Tx_FeatureFlag_Domain_Repository_Mapping |
||
| 283 | */ |
||
| 284 | protected function getMappingRepository() |
||
| 288 | |||
| 289 | /** |
||
| 290 | * @return Tx_FeatureFlag_Domain_Repository_FeatureFlag |
||
| 291 | */ |
||
| 292 | protected function getFeatureFlagRepository() |
||
| 296 | |||
| 297 | /** |
||
| 298 | * @return \TYPO3\CMS\Extbase\Object\ObjectManager |
||
| 299 | */ |
||
| 300 | protected function getObjectManager() |
||
| 308 | |||
| 309 | /** |
||
| 310 | * @return \TYPO3\CMS\Extbase\Persistence\Generic\PersistenceManager |
||
| 311 | */ |
||
| 312 | protected function getPersistenceManager() |
||
| 320 | |||
| 321 | /** |
||
| 322 | * @return TYPO3\CMS\Lang\LanguageService |
||
| 323 | */ |
||
| 324 | protected function getLanguageService() |
||
| 328 | } |
||
| 329 |
Loading history...
You can fix this by adding a namespace to your class:
When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.