Aoe\FeatureFlag\System\Db\FeatureFlagData

Complexity

Total Complexity

4

Size/Duplication

Total Lines	100
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getContentElements()	0	47	1
A	updateContentElements()	0	15	2
A	getContentElementsPIDs()	0	22	1

<?php

namespace Aoe\FeatureFlag\System\Db;

/***************************************************************
 *  Copyright notice
 *
 *  (c) 2021 AOE GmbH <dev@aoe.com>
 *
 *  All rights reserved
 *
 *  This script is part of the TYPO3 project. The TYPO3 project is
 *  free software; you can redistribute it and/or modify
 *  it under the terms of the GNU General Public License as published by
 *  the Free Software Foundation; either version 3 of the License, or
 *  (at your option) any later version.
 *
 *  The GNU General Public License can be found at
 *  http://www.gnu.org/copyleft/gpl.html.
 *
 *  This script is distributed in the hope that it will be useful,
 *  but WITHOUT ANY WARRANTY; without even the implied warranty of
 *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 *  GNU General Public License for more details.
 *
 *  This copyright notice MUST APPEAR in all copies of the script!
 ***************************************************************/

use TYPO3\CMS\Core\Database\Connection;
use TYPO3\CMS\Core\Database\ConnectionPool;
use TYPO3\CMS\Core\Database\Query\QueryBuilder;
use TYPO3\CMS\Core\Utility\GeneralUtility;

class FeatureFlagData
{
    /**
     * @var string
     */
    public const TABLE_MAPPING = 'tx_featureflag_domain_model_mapping';

    /**
     * @var string
     */
    public const TABLE_FLAGS = 'tx_featureflag_domain_model_featureflag';

    public function getContentElements(string $table, int $behavior, int $enabled): array
    {
        /** @var QueryBuilder $queryBuilder */
        $queryBuilder = GeneralUtility::makeInstance(ConnectionPool::class)
            ->getQueryBuilderForTable($table);

        $queryBuilder->getRestrictions()
            ->removeAll();

        $queryBuilder
            ->select($table . '.uid')
            ->from($table)
            ->from(self::TABLE_MAPPING)
            ->from(self::TABLE_FLAGS)
            ->where(
                $queryBuilder->expr()
                    ->andX(
                        $queryBuilder->expr()
                            ->eq(
                                self::TABLE_MAPPING . '.feature_flag',
                                self::TABLE_FLAGS . '.uid'
                            ),
                        $queryBuilder->expr()
                            ->eq(
                                $table . '.uid',
                                self::TABLE_MAPPING . '.foreign_table_uid'
                            ),
                        $queryBuilder->expr()
                            ->eq(
                                self::TABLE_FLAGS . '.enabled',
                                $queryBuilder->createNamedParameter($enabled, Connection::PARAM_INT)
                            ),
                        $queryBuilder->expr()
                            ->eq(
                                self::TABLE_MAPPING . '.foreign_table_name',
                                $queryBuilder->createNamedParameter($table, Connection::PARAM_STR)
                            ),
                        $queryBuilder->expr()
                            ->eq(
                                self::TABLE_MAPPING . '.behavior',
                                $queryBuilder->createNamedParameter($behavior, Connection::PARAM_INT)
                            )
                    )
            );

        return $queryBuilder->execute()
            ->fetchAllAssociative();
    }

    public function updateContentElements(string $table, array $uids, bool $isVisible): void
    {
        /** @var QueryBuilder $queryBuilder */
        $queryBuilder = GeneralUtility::makeInstance(ConnectionPool::class)
            ->getQueryBuilderForTable($table);

        $queryBuilder->getRestrictions()
            ->removeAll();

        $query = $queryBuilder
            ->update($table)
            ->set('hidden', $isVisible ? 0 : 1)
            ->add('where', $queryBuilder->expr()->in('uid', $uids));

        $query->execute();
    }

    public function getContentElementsPIDs(string $table, int $uid): string
    {
        /** @var QueryBuilder $queryBuilder */
        $queryBuilder = GeneralUtility::makeInstance(ConnectionPool::class)
            ->getQueryBuilderForTable($table);

        $queryBuilder->getRestrictions()
            ->removeAll();

        $query = $queryBuilder
            ->select($table . '.pid')
            ->from($table)
            ->where(
                $queryBuilder->expr()

$queryBuilder->expr()->eq($table . '.uid', $queryBuilder->createNamedParameter($uid, TYPO3\CMS\Core\Database\Connection::PARAM_INT)) of type string is incompatible with the type Doctrine\DBAL\Query\Expression\CompositeExpression|array<integer,mixed> expected by parameter $predicates of TYPO3\CMS\Core\Database\Query\QueryBuilder::where().

                    ->eq(
                        $table . '.uid',
                        $queryBuilder->createNamedParameter($uid, Connection::PARAM_INT)
                    )
            );

        return $query->execute()

The expression return $query->execute()->fetchOne() could return the type false which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

            ->fetchOne();
    }
}