PasswordRequestManager::__construct() - Code Metrics - Inspection of "Dev" - 68publishers/user - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#2)

by Tomáš

created 2019-07-07 22:55 UTC

PasswordRequestManager::__construct() A

↳ Parent: PasswordRequestManager

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	9
rs	9.9666
c	0
b	0
f	0
cc	1
nc	1
nop	3

<?php

declare(strict_types=1);

namespace SixtyEightPublishers\User\ForgotPassword\PasswordRequest;

use Nette;
use Doctrine;
use SixtyEightPublishers;

class PasswordRequestManager implements IPasswordRequestManager
{
	use Nette\SmartObject;

	/** @var \Doctrine\ORM\EntityManagerInterface  */
	private $em;

	/** @var \SixtyEightPublishers\User\Common\PasswordHashStrategy\IPasswordHashStrategy  */
	private $passwordHashStrategy;

	/** @var \SixtyEightPublishers\User\ForgotPassword\Query\IFindPasswordRequestByIdsQueryFactory  */
	private $findPasswordRequestByIdsQueryFactory;

	/**
	 * @param \Doctrine\ORM\EntityManagerInterface                                                  $em
	 * @param \SixtyEightPublishers\User\Common\PasswordHashStrategy\IPasswordHashStrategy          $passwordHashStrategy
	 * @param \SixtyEightPublishers\User\ForgotPassword\Query\IFindPasswordRequestByIdsQueryFactory $findPasswordRequestByIdsQueryFactory
	 */
	public function __construct(
		Doctrine\ORM\EntityManagerInterface $em,
		SixtyEightPublishers\User\Common\PasswordHashStrategy\IPasswordHashStrategy $passwordHashStrategy,
		SixtyEightPublishers\User\ForgotPassword\Query\IFindPasswordRequestByIdsQueryFactory $findPasswordRequestByIdsQueryFactory
	) {
		$this->em = $em;
		$this->passwordHashStrategy = $passwordHashStrategy;
		$this->findPasswordRequestByIdsQueryFactory = $findPasswordRequestByIdsQueryFactory;
	}

	/**
	 * @param \SixtyEightPublishers\User\ForgotPassword\DoctrineEntity\IPasswordRequest $request
	 * @param callable                                                                  $try
	 *
	 * @return mixed
	 * @throws \SixtyEightPublishers\User\ForgotPassword\Exception\PasswordRequestProcessException
	 */
	private function tryCatch(SixtyEightPublishers\User\ForgotPassword\DoctrineEntity\IPasswordRequest $request, callable $try)
	{
		try {
			return $try($request);
		} catch (\Throwable $e) {
			if (!$e instanceof SixtyEightPublishers\User\ForgotPassword\Exception\PasswordRequestProcessException) {
				$e = new SixtyEightPublishers\User\ForgotPassword\Exception\PasswordRequestProcessException($request->getUser()->getId(), $request->getId(), $e->getMessage(), 0, $e);
			}

			throw $e;
		}
	}

	/*********** interface \SixtyEightPublishers\User\ForgotPassword\IPasswordRequestSender ***********/

	/**
	 * {@inheritdoc}
	 */
	public function findRequest($uid, $rid): SixtyEightPublishers\User\ForgotPassword\DoctrineEntity\IPasswordRequest
	{
		try {
			/** @var \SixtyEightPublishers\User\ForgotPassword\DoctrineEntity\IPasswordRequest $request */
			$request = $this->findPasswordRequestByIdsQueryFactory
				->create($this->em, $uid, $rid)
				->getOneOrNullResult();
		} catch (Doctrine\DBAL\DBALException $e) {
			throw SixtyEightPublishers\User\ForgotPassword\Exception\PasswordRequestProcessException::missingRequest($uid, $rid);
		}

		if (NULL === $request) {
			throw SixtyEightPublishers\User\ForgotPassword\Exception\PasswordRequestProcessException::missingRequest($uid, $rid);
		}

		if (TRUE === $request->isExpired()) {
			throw SixtyEightPublishers\User\ForgotPassword\Exception\PasswordRequestProcessException::expiredRequest($request->getUser()->getId(), $request->getId());
		}

		return $request;
	}

	/**
	 * {@inheritdoc}
	 */
	public function reset(SixtyEightPublishers\User\ForgotPassword\DoctrineEntity\IPasswordRequest $passwordRequest, string $password): void
	{
		$this->tryCatch($passwordRequest, function (SixtyEightPublishers\User\ForgotPassword\DoctrineEntity\IPasswordRequest $passwordRequest) use ($password) {
			$user = $passwordRequest->getUser();

			if ($this->passwordHashStrategy->needRehash($password)) {
				$password = $this->passwordHashStrategy->hash($password);
$x = 1;
$callable = function() use ($x) {
    $x = 2; // Not visible in outer scope. If you would like this, how
            // about using a different variable name than $x?
};

$callable();
var_dump($x); // integer(1)
			}

			$passwordRequest->getResetDeviceInfo()->fill();
			$passwordRequest->setStatus($passwordRequest::STATUS_COMPLETED);
			$user->setPassword($password);

			$this->em->persist($passwordRequest);
			$this->em->persist($user);
			$this->em->flush();
		});
	}

	/**
	 * {@inheritdoc}
	 */
	public function cancel(SixtyEightPublishers\User\ForgotPassword\DoctrineEntity\IPasswordRequest $passwordRequest): void
	{
		$this->tryCatch($passwordRequest, function (SixtyEightPublishers\User\ForgotPassword\DoctrineEntity\IPasswordRequest $passwordRequest) {
			$passwordRequest->getResetDeviceInfo()->fill();
			$passwordRequest->setStatus($passwordRequest::STATUS_CANCELED);

			$this->em->persist($passwordRequest);
			$this->em->flush();
		});
	}
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace SixtyEightPublishers\User\ForgotPassword\PasswordRequest;
6
7			use Nette;
8			use Doctrine;
9			use SixtyEightPublishers;
10
11			class PasswordRequestManager implements IPasswordRequestManager
12			{
13			use Nette\SmartObject;
14
15			/** @var \Doctrine\ORM\EntityManagerInterface */
16			private $em;
17
18			/** @var \SixtyEightPublishers\User\Common\PasswordHashStrategy\IPasswordHashStrategy */
19			private $passwordHashStrategy;
20
21			/** @var \SixtyEightPublishers\User\ForgotPassword\Query\IFindPasswordRequestByIdsQueryFactory */
22			private $findPasswordRequestByIdsQueryFactory;
23
24			/**
25			* @param \Doctrine\ORM\EntityManagerInterface $em
26			* @param \SixtyEightPublishers\User\Common\PasswordHashStrategy\IPasswordHashStrategy $passwordHashStrategy
27			* @param \SixtyEightPublishers\User\ForgotPassword\Query\IFindPasswordRequestByIdsQueryFactory $findPasswordRequestByIdsQueryFactory
28			*/
29			public function __construct(
30			Doctrine\ORM\EntityManagerInterface $em,
31			SixtyEightPublishers\User\Common\PasswordHashStrategy\IPasswordHashStrategy $passwordHashStrategy,
32			SixtyEightPublishers\User\ForgotPassword\Query\IFindPasswordRequestByIdsQueryFactory $findPasswordRequestByIdsQueryFactory
33			) {
34			$this->em = $em;
35			$this->passwordHashStrategy = $passwordHashStrategy;
36			$this->findPasswordRequestByIdsQueryFactory = $findPasswordRequestByIdsQueryFactory;
37			}
38
39			/**
40			* @param \SixtyEightPublishers\User\ForgotPassword\DoctrineEntity\IPasswordRequest $request
41			* @param callable $try
42			*
43			* @return mixed
44			* @throws \SixtyEightPublishers\User\ForgotPassword\Exception\PasswordRequestProcessException
45			*/
46			private function tryCatch(SixtyEightPublishers\User\ForgotPassword\DoctrineEntity\IPasswordRequest $request, callable $try)
47			{
48			try {
49			return $try($request);
50			} catch (\Throwable $e) {
51			if (!$e instanceof SixtyEightPublishers\User\ForgotPassword\Exception\PasswordRequestProcessException) {
52			$e = new SixtyEightPublishers\User\ForgotPassword\Exception\PasswordRequestProcessException($request->getUser()->getId(), $request->getId(), $e->getMessage(), 0, $e);
53			}
54
55			throw $e;
56			}
57			}
58
59			/********* interface \SixtyEightPublishers\User\ForgotPassword\IPasswordRequestSender *********/
60
61			/**
62			* {@inheritdoc}
63			*/
64			public function findRequest($uid, $rid): SixtyEightPublishers\User\ForgotPassword\DoctrineEntity\IPasswordRequest
65			{
66			try {
67			/** @var \SixtyEightPublishers\User\ForgotPassword\DoctrineEntity\IPasswordRequest $request */
68			$request = $this->findPasswordRequestByIdsQueryFactory
69			->create($this->em, $uid, $rid)
70			->getOneOrNullResult();
71			} catch (Doctrine\DBAL\DBALException $e) {
72			throw SixtyEightPublishers\User\ForgotPassword\Exception\PasswordRequestProcessException::missingRequest($uid, $rid);
73			}
74
75			if (NULL === $request) {
76			throw SixtyEightPublishers\User\ForgotPassword\Exception\PasswordRequestProcessException::missingRequest($uid, $rid);
77			}
78
79			if (TRUE === $request->isExpired()) {
80			throw SixtyEightPublishers\User\ForgotPassword\Exception\PasswordRequestProcessException::expiredRequest($request->getUser()->getId(), $request->getId());
81			}
82
83			return $request;
84			}
85
86			/**
87			* {@inheritdoc}
88			*/
89			public function reset(SixtyEightPublishers\User\ForgotPassword\DoctrineEntity\IPasswordRequest $passwordRequest, string $password): void
90			{
91			$this->tryCatch($passwordRequest, function (SixtyEightPublishers\User\ForgotPassword\DoctrineEntity\IPasswordRequest $passwordRequest) use ($password) {
92			$user = $passwordRequest->getUser();
93
94			if ($this->passwordHashStrategy->needRehash($password)) {
95			$password = $this->passwordHashStrategy->hash($password);
			0 ignored issues – show Bug introduced 2019-06-27 16:37 UTC by Report Bug Copy Issue Report Consider using a different name than the imported variable `$password`, or did you forget to import by reference? It seems like you are assigning to a variable which was imported through a `use` statement which was not imported by reference. For clarity, we suggest to use a different name or import by reference depending on whether you would like to have the change visibile in outer-scope. Change not visible in outer-scope $x = 1; $callable = function() use ($x) { $x = 2; // Not visible in outer scope. If you would like this, how // about using a different variable name than $x? }; $callable(); var_dump($x); // integer(1) Change visible in outer-scope $x = 1; $callable = function() use (&$x) { $x = 2; }; $callable(); var_dump($x); // integer(2) Loading history...
96			}
97
98			$passwordRequest->getResetDeviceInfo()->fill();
99			$passwordRequest->setStatus($passwordRequest::STATUS_COMPLETED);
100			$user->setPassword($password);
101
102			$this->em->persist($passwordRequest);
103			$this->em->persist($user);
104			$this->em->flush();
105			});
106			}
107
108			/**
109			* {@inheritdoc}
110			*/
111			public function cancel(SixtyEightPublishers\User\ForgotPassword\DoctrineEntity\IPasswordRequest $passwordRequest): void
112			{
113			$this->tryCatch($passwordRequest, function (SixtyEightPublishers\User\ForgotPassword\DoctrineEntity\IPasswordRequest $passwordRequest) {
114			$passwordRequest->getResetDeviceInfo()->fill();
115			$passwordRequest->setStatus($passwordRequest::STATUS_CANCELED);
116
117			$this->em->persist($passwordRequest);
118			$this->em->flush();
119			});
120			}
121			}
122

68publishers / user

Pull Request — master (#2)

PasswordRequestManager::__construct() A

Complexity

Size

Duplication

Importance

Change not visible in outer-scope

Change visible in outer-scope

Duplication Side-by-Side

Filter issues like