PasswordRequestManager::cancel() - Code Metrics - Inspection of "Reset password - autologin" - 68publishers/user - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c495da...16538c )

by Tomáš

created 2020-11-30 00:47 UTC

PasswordRequestManager::cancel() A

↳ Parent: PasswordRequestManager

Complexity

Conditions	2
Paths	1

Size

Total Lines

Duplication

Lines	7
Ratio	33.33 %

Importance

Changes

Metric	Value
dl	7
loc	21
rs	9.584
c	0
b	0
f	0
cc	2
nc	1
nop	1

<?php

declare(strict_types=1);

namespace SixtyEightPublishers\User\ForgotPassword\PasswordRequest;

use Nette\SmartObject;
use Doctrine\ORM\EntityManagerInterface;
use SixtyEightPublishers\User\Common\DbalType\Password\Password;
use SixtyEightPublishers\DoctrinePersistence\TransactionFactoryInterface;
use SixtyEightPublishers\DoctrinePersistence\Context\ErrorContextInterface;
use SixtyEightPublishers\User\ForgotPassword\Entity\PasswordRequestInterface;
use SixtyEightPublishers\DoctrineQueryObjects\ExecutableQueryObjectFactoryInterface;
use SixtyEightPublishers\User\ForgotPassword\Exception\PasswordRequestProcessException;
use SixtyEightPublishers\User\Common\PasswordHashStrategy\PasswordHashStrategyInterface;
use SixtyEightPublishers\User\ForgotPassword\Query\FindPasswordRequestByIdsQueryObjectFactoryInterface;

class PasswordRequestManager implements PasswordRequestManagerInterface
{
	use SmartObject;

	/** @var \SixtyEightPublishers\DoctrinePersistence\TransactionFactoryInterface  */
	private $transactionFactory;

	/** @var \SixtyEightPublishers\User\Common\PasswordHashStrategy\PasswordHashStrategyInterface  */
	private $passwordHashStrategy;

	/** @var \SixtyEightPublishers\DoctrineQueryObjects\ExecutableQueryObjectFactoryInterface  */
	private $executableQueryObjectFactory;

	/** @var \SixtyEightPublishers\User\ForgotPassword\Query\FindPasswordRequestByIdsQueryObjectFactoryInterface  */
	private $findPasswordRequestByIdsQueryFactory;

	/**
	 * @param \SixtyEightPublishers\DoctrinePersistence\TransactionFactoryInterface                               $transactionFactory
	 * @param \SixtyEightPublishers\User\Common\PasswordHashStrategy\PasswordHashStrategyInterface                $passwordHashStrategy
	 * @param \SixtyEightPublishers\DoctrineQueryObjects\ExecutableQueryObjectFactoryInterface                    $executableQueryObjectFactory
	 * @param \SixtyEightPublishers\User\ForgotPassword\Query\FindPasswordRequestByIdsQueryObjectFactoryInterface $findPasswordRequestByIdsQueryFactory
	 */
	public function __construct(TransactionFactoryInterface $transactionFactory, PasswordHashStrategyInterface $passwordHashStrategy, ExecutableQueryObjectFactoryInterface $executableQueryObjectFactory, FindPasswordRequestByIdsQueryObjectFactoryInterface $findPasswordRequestByIdsQueryFactory)
	{
		$this->transactionFactory = $transactionFactory;
		$this->passwordHashStrategy = $passwordHashStrategy;
		$this->executableQueryObjectFactory = $executableQueryObjectFactory;
		$this->findPasswordRequestByIdsQueryFactory = $findPasswordRequestByIdsQueryFactory;
	}

	/**
	 * {@inheritdoc}
	 */
	public function findRequest($uid, $rid): PasswordRequestInterface
	{
		$request = $this->executableQueryObjectFactory->create($this->findPasswordRequestByIdsQueryFactory->create($uid, $rid))->fetchOne();

		if (!$request instanceof PasswordRequestInterface) {
			throw PasswordRequestProcessException::missingRequest($uid, $rid);
		}

		if (TRUE === $request->isExpired()) {
			throw PasswordRequestProcessException::expiredRequest($request->getUser()->getId(), $request->getId());
		}

		return $request;
	}

	/**
	 * {@inheritdoc}
	 *
	 * @throws \Throwable
	 */
	public function reset(PasswordRequestInterface $passwordRequest, string $password): void
	{
		$transaction = $this->transactionFactory->create(function (EntityManagerInterface $em, PasswordRequestInterface $passwordRequest, string $password) {
			$user = $passwordRequest->getUser();

			if ($this->passwordHashStrategy->needRehash($password)) {
				$password = $this->passwordHashStrategy->hash($password);
			}

			$passwordRequest->getResetDeviceInfo()->fill();
			$passwordRequest->setStatus($passwordRequest::STATUS_COMPLETED);
			$user->setPassword(new Password($password));

			$em->persist($passwordRequest);
			$em->persist($user);

			return $user;
		});

		$transaction->error(static function (ErrorContextInterface $context) use ($passwordRequest) {

			$e = $context->getError();

			if (!$e instanceof PasswordRequestProcessException) {
				throw new PasswordRequestProcessException($passwordRequest->getUser()->getId(), $passwordRequest->getId(), $e->getMessage(), 0, $e);
			}
		});

		$transaction->withArguments([
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			'passwordRequest' => $passwordRequest,
			'password' => $password,
		])->run();
	}

	/**
	 * {@inheritdoc}
	 *
	 * @throws \Throwable
	 */
	public function cancel(PasswordRequestInterface $passwordRequest): void
	{
		$transaction = $this->transactionFactory->create(static function (EntityManagerInterface $em, PasswordRequestInterface $passwordRequest) {
			$passwordRequest->getResetDeviceInfo()->fill();
			$passwordRequest->setStatus($passwordRequest::STATUS_CANCELED);

			$em->persist($passwordRequest);

			return $passwordRequest;
		});

		$transaction->error(static function (ErrorContextInterface $context) use ($passwordRequest) {

			$e = $context->getError();

			if (!$e instanceof PasswordRequestProcessException) {
				throw new PasswordRequestProcessException($passwordRequest->getUser()->getId(), $passwordRequest->getId(), $e->getMessage(), 0, $e);
			}
		});

		$transaction->withArguments(['passwordRequest' => $passwordRequest])->run();
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
	}
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace SixtyEightPublishers\User\ForgotPassword\PasswordRequest;
6
7		use Nette\SmartObject;
8		use Doctrine\ORM\EntityManagerInterface;
9		use SixtyEightPublishers\User\Common\DbalType\Password\Password;
10		use SixtyEightPublishers\DoctrinePersistence\TransactionFactoryInterface;
11		use SixtyEightPublishers\DoctrinePersistence\Context\ErrorContextInterface;
12		use SixtyEightPublishers\User\ForgotPassword\Entity\PasswordRequestInterface;
13		use SixtyEightPublishers\DoctrineQueryObjects\ExecutableQueryObjectFactoryInterface;
14		use SixtyEightPublishers\User\ForgotPassword\Exception\PasswordRequestProcessException;
15		use SixtyEightPublishers\User\Common\PasswordHashStrategy\PasswordHashStrategyInterface;
16		use SixtyEightPublishers\User\ForgotPassword\Query\FindPasswordRequestByIdsQueryObjectFactoryInterface;
17
18		class PasswordRequestManager implements PasswordRequestManagerInterface
19		{
20		use SmartObject;
21
22		/** @var \SixtyEightPublishers\DoctrinePersistence\TransactionFactoryInterface */
23		private $transactionFactory;
24
25		/** @var \SixtyEightPublishers\User\Common\PasswordHashStrategy\PasswordHashStrategyInterface */
26		private $passwordHashStrategy;
27
28		/** @var \SixtyEightPublishers\DoctrineQueryObjects\ExecutableQueryObjectFactoryInterface */
29		private $executableQueryObjectFactory;
30
31		/** @var \SixtyEightPublishers\User\ForgotPassword\Query\FindPasswordRequestByIdsQueryObjectFactoryInterface */
32		private $findPasswordRequestByIdsQueryFactory;
33
34		/**
35		* @param \SixtyEightPublishers\DoctrinePersistence\TransactionFactoryInterface $transactionFactory
36		* @param \SixtyEightPublishers\User\Common\PasswordHashStrategy\PasswordHashStrategyInterface $passwordHashStrategy
37		* @param \SixtyEightPublishers\DoctrineQueryObjects\ExecutableQueryObjectFactoryInterface $executableQueryObjectFactory
38		* @param \SixtyEightPublishers\User\ForgotPassword\Query\FindPasswordRequestByIdsQueryObjectFactoryInterface $findPasswordRequestByIdsQueryFactory
39		*/
40		public function __construct(TransactionFactoryInterface $transactionFactory, PasswordHashStrategyInterface $passwordHashStrategy, ExecutableQueryObjectFactoryInterface $executableQueryObjectFactory, FindPasswordRequestByIdsQueryObjectFactoryInterface $findPasswordRequestByIdsQueryFactory)
41		{
42		$this->transactionFactory = $transactionFactory;
43		$this->passwordHashStrategy = $passwordHashStrategy;
44		$this->executableQueryObjectFactory = $executableQueryObjectFactory;
45		$this->findPasswordRequestByIdsQueryFactory = $findPasswordRequestByIdsQueryFactory;
46		}
47
48		/**
49		* {@inheritdoc}
50		*/
51		public function findRequest($uid, $rid): PasswordRequestInterface
52		{
53		$request = $this->executableQueryObjectFactory->create($this->findPasswordRequestByIdsQueryFactory->create($uid, $rid))->fetchOne();
54
55		if (!$request instanceof PasswordRequestInterface) {
56		throw PasswordRequestProcessException::missingRequest($uid, $rid);
57		}
58
59		if (TRUE === $request->isExpired()) {
60		throw PasswordRequestProcessException::expiredRequest($request->getUser()->getId(), $request->getId());
61		}
62
63		return $request;
64		}
65
66		/**
67		* {@inheritdoc}
68		*
69		* @throws \Throwable
70		*/
71		public function reset(PasswordRequestInterface $passwordRequest, string $password): void
72		{
73		$transaction = $this->transactionFactory->create(function (EntityManagerInterface $em, PasswordRequestInterface $passwordRequest, string $password) {
74		$user = $passwordRequest->getUser();
75
76		if ($this->passwordHashStrategy->needRehash($password)) {
77		$password = $this->passwordHashStrategy->hash($password);
78		}
79
80		$passwordRequest->getResetDeviceInfo()->fill();
81		$passwordRequest->setStatus($passwordRequest::STATUS_COMPLETED);
82		$user->setPassword(new Password($password));
83
84		$em->persist($passwordRequest);
85		$em->persist($user);
86
87		return $user;
88		});
89
90	View Code Duplication	$transaction->error(static function (ErrorContextInterface $context) use ($passwordRequest) {
		0 ignored issues – show Duplication introduced 2020-11-25 02:03 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
91		$e = $context->getError();
92
93		if (!$e instanceof PasswordRequestProcessException) {
94		throw new PasswordRequestProcessException($passwordRequest->getUser()->getId(), $passwordRequest->getId(), $e->getMessage(), 0, $e);
95		}
96		});
97
98		$transaction->withArguments([
		0 ignored issues – show Documentation introduced 2020-11-25 02:03 UTC by Report Bug Copy Issue Report `array('passwordRequest' ...password' => $password)` is of type `array<string,object<Sixt...","password":"string"}>`, but the function expects a `object<SixtyEightPublish...nePersistence\iterable>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
99		'passwordRequest' => $passwordRequest,
100		'password' => $password,
101		])->run();
102		}
103
104		/**
105		* {@inheritdoc}
106		*
107		* @throws \Throwable
108		*/
109		public function cancel(PasswordRequestInterface $passwordRequest): void
110		{
111		$transaction = $this->transactionFactory->create(static function (EntityManagerInterface $em, PasswordRequestInterface $passwordRequest) {
112		$passwordRequest->getResetDeviceInfo()->fill();
113		$passwordRequest->setStatus($passwordRequest::STATUS_CANCELED);
114
115		$em->persist($passwordRequest);
116
117		return $passwordRequest;
118		});
119
120	View Code Duplication	$transaction->error(static function (ErrorContextInterface $context) use ($passwordRequest) {
		0 ignored issues – show Duplication introduced 2020-11-25 02:03 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
121		$e = $context->getError();
122
123		if (!$e instanceof PasswordRequestProcessException) {
124		throw new PasswordRequestProcessException($passwordRequest->getUser()->getId(), $passwordRequest->getId(), $e->getMessage(), 0, $e);
125		}
126		});
127
128		$transaction->withArguments(['passwordRequest' => $passwordRequest])->run();
		0 ignored issues – show Documentation introduced 2020-11-25 02:03 UTC by Report Bug Copy Issue Report `array('passwordRequest' => $passwordRequest)` is of type `array<string,object<Sixt...ordRequestInterface>"}>`, but the function expects a `object<SixtyEightPublish...nePersistence\iterable>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
129		}
130		}
131

68publishers / user

Push — master ( c495da...16538c )

PasswordRequestManager::cancel() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like