SixtyEightPublishers\Application\RemoteAccessManager\RemoteAccessManager

Complexity

Total Complexity

12

Size/Duplication

Total Lines	96
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	12	1
A	process()	0	6	2
C	isAllowed()	0	23	8
A	isAllowedAll()	0	4	1

<?php

declare(strict_types=1);

namespace SixtyEightPublishers\Application\RemoteAccessManager;

use Nette\Http\IRequest;
use Nette\SmartObject;
use SixtyEightPublishers\Application\RemoteAccessManager\Handler\IAccessHandler;

/**
 * @method  RemoteAccessManager   onAccess()
 * @method  RemoteAccessManager   onDeny()
 */
class RemoteAccessManager implements IRemoteAccessManager
{
	use SmartObject;

	const
		COOKIE_SECRET = 'ram-secret-key',
		ALLOWED_ALL = TRUE,
		DENY_ALL = FALSE;

	/** @var \Nette\Http\IRequest */
	private $request;

	/** @var array */
	private $whitelist;

	/** @var array */
	private $blacklist;

	/** @var string|null */
	private $key;

	/** @var bool|true */
	private $mode;

	/** @var \SixtyEightPublishers\Application\RemoteAccessManager\Handler\IAccessHandler */
	private $handler;

	/** @var null|callable */
	public $onAllow;

	/** @var null|callable */
	public $onDeny;

	/**
	 * @param \Nette\Http\IRequest    $request
	 * @param string|array            $blacklist
	 * @param string|array            $whitelist
	 * @param string                  $key
	 * @param bool|TRUE               $mode
	 * @param IAccessHandler          $handler
	 */
	public function __construct(IRequest $request, $blacklist = [], $whitelist = [], $mode = self::ALLOWED_ALL, $key = self::COOKIE_SECRET, IAccessHandler $handler)
	{
		$this->request = $request;
		$this->blacklist = $blacklist;

It seems like $blacklist can also be of type string. However, the property $blacklist is declared as type array. Maybe add an additional type check?

		$this->whitelist = $whitelist;

It seems like $whitelist can also be of type string. However, the property $whitelist is declared as type array. Maybe add an additional type check?

		$this->mode = $mode;
		$this->key = $key;
		$this->handler = $handler;

		$this->onAllow[] = [$this->handler, 'allow'];
		$this->onDeny[] = [$this->handler, 'deny'];
	}

	public function process()
	{
		$this->isAllowed()
			? $this->onAllow()

The method onAllow does not exist on object<SixtyEightPublishers\Application\RemoteAccessManager\RemoteAccessManager>? Since you implemented __call, maybe consider adding a @method annotation.

			: $this->onDeny();
	}

	/**
	 * @return bool
	 */
	private function isAllowed() : bool
	{
		$addr = $this->request->getRemoteAddress() ?: php_uname('n');
		$secret = $this->request->getCookie($this->key);

		if ($this->isAllowedAll()) {
			$blacklist = is_string($this->blacklist)
				? preg_split('#[,\s]+#', $this->blacklist)
				: (array) $this->blacklist;
			$allow = !(in_array($addr, $blacklist, TRUE) || in_array("$secret@$addr", $blacklist, TRUE));
		} else {
			$whitelist = is_string($this->whitelist)
				? preg_split('#[,\s]+#', $this->whitelist)
				: (array) $this->whitelist;
			if (!isset($_SERVER['HTTP_X_FORWARDED_FOR'])) {
				$whitelist[] = '127.0.0.1';
				$whitelist[] = '::1';
			}
			$allow = in_array($addr, $whitelist, TRUE) || in_array("$secret@$addr", $whitelist, TRUE);
		}

		return $allow;
	}

	/**
	 * @return bool
	 */
	private function isAllowedAll() : bool
	{
		return $this->mode === self::ALLOWED_ALL;
	}
}