SessionProfileStorage::__construct() - Code Metrics - Inspection of "Added ActiveProfile test" - 68publishers/application - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 9450db...32d720 )

by Vojtěch

created 2017-01-08 23:09 UTC

SessionProfileStorage::__construct() A

↳ Parent: SessionProfileStorage

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	1

<?php

namespace SixtyEightPublishers\Application\Storage;

use Nette\Http\Session;
use Nette\SmartObject;
use SixtyEightPublishers\Application\ActiveProfile;
use SixtyEightPublishers\Application\IProfile;
use SixtyEightPublishers\Application\IProfileStorage;
use SixtyEightPublishers\Application\ProfileConfigurationException;

class SessionProfileStorage implements IProfileStorage
{
	use SmartObject;

	const SESSION_SECTION = 'SixtyEightPublishers.Application';

	/** @var null|ActiveProfile */
	private $profile;

	/** @var \Nette\Http\SessionSection  */
	private $session;

	/** @var null|callable */
	public $onPersist;

	/** @var null|callable */
	public $onProfileSet;

	/**
	 * @param \Nette\Http\Session $session
	 */
	public function __construct(Session $session)
	{
		$this->session = $session->getSection(self::SESSION_SECTION);
	}


	/***************** interface \SixtyEightPublishers\Application\IProfileStorage *****************/

	/**
	 * {@inheritdoc}
	 */
	public function setProfile(IProfile $profile)
	{
		$this->profile = new ActiveProfile($profile, $this);

		if ($this->session['profileName'] === $this->profile->getName()) {
			try {
				$this->profile->changeCountry($this->session['profileCountry'], FALSE);
			} catch (ProfileConfigurationException $e) {

			}
			try {
				$this->profile->changeLanguage($this->session['profileLanguage'], FALSE);
			} catch (ProfileConfigurationException $e) {

			}
			try {
				$this->profile->changeCurrency($this->session['profileCurrency'], FALSE);
			} catch (ProfileConfigurationException $e) {

			}
		} else {
			$this->session['profileName'] = $this->profile->getName();
		}

		$this->onProfileSet($this->profile);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
	}

	/**
	 * @return \SixtyEightPublishers\Application\ActiveProfile
	 */
	public function getProfile() : ActiveProfile
	{
		return $this->profile;
	}

	/**
	 * {@inheritdoc}
	 */
	public function persist()
	{
		$this->onPersist($this->profile);

		$this->session['profileName'] = $this->profile->getName();
		$this->session['profileCountry'] = $this->profile->getCountry();
		$this->session['profileLanguage'] = $this->profile->getLanguage();
		$this->session['profileCurrency'] = $this->profile->getCurrency();
	}
}


1			<?php
2
3			namespace SixtyEightPublishers\Application\Storage;
4
5			use Nette\Http\Session;
6			use Nette\SmartObject;
7			use SixtyEightPublishers\Application\ActiveProfile;
8			use SixtyEightPublishers\Application\IProfile;
9			use SixtyEightPublishers\Application\IProfileStorage;
10			use SixtyEightPublishers\Application\ProfileConfigurationException;
11
12			class SessionProfileStorage implements IProfileStorage
13			{
14			use SmartObject;
15
16			const SESSION_SECTION = 'SixtyEightPublishers.Application';
17
18			/** @var null\|ActiveProfile */
19			private $profile;
20
21			/** @var \Nette\Http\SessionSection */
22			private $session;
23
24			/** @var null\|callable */
25			public $onPersist;
26
27			/** @var null\|callable */
28			public $onProfileSet;
29
30			/**
31			* @param \Nette\Http\Session $session
32			*/
33			public function __construct(Session $session)
34			{
35			$this->session = $session->getSection(self::SESSION_SECTION);
36			}
37
38
39			/*************** interface \SixtyEightPublishers\Application\IProfileStorage ***************/
40
41			/**
42			* {@inheritdoc}
43			*/
44			public function setProfile(IProfile $profile)
45			{
46			$this->profile = new ActiveProfile($profile, $this);
47
48			if ($this->session['profileName'] === $this->profile->getName()) {
49			try {
50			$this->profile->changeCountry($this->session['profileCountry'], FALSE);
51			} catch (ProfileConfigurationException $e) {
			0 ignored issues – show Coding Style Comprehensibility introduced 2017-01-08 23:06 UTC by Report Bug Copy Issue Report Consider adding a comment why this CATCH block is empty. Loading history...
52			}
53			try {
54			$this->profile->changeLanguage($this->session['profileLanguage'], FALSE);
55			} catch (ProfileConfigurationException $e) {
			0 ignored issues – show Coding Style Comprehensibility introduced 2017-01-08 23:06 UTC by Report Bug Copy Issue Report Consider adding a comment why this CATCH block is empty. Loading history...
56			}
57			try {
58			$this->profile->changeCurrency($this->session['profileCurrency'], FALSE);
59			} catch (ProfileConfigurationException $e) {
			0 ignored issues – show Coding Style Comprehensibility introduced 2017-01-08 23:06 UTC by Report Bug Copy Issue Report Consider adding a comment why this CATCH block is empty. Loading history...
60			}
61			} else {
62			$this->session['profileName'] = $this->profile->getName();
63			}
64
65			$this->onProfileSet($this->profile);
			0 ignored issues – show Documentation Bug introduced 2017-01-08 23:06 UTC by Report Bug Copy Issue Report The method `onProfileSet` does not exist on `object<SixtyEightPublish...\SessionProfileStorage>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
66			}
67
68			/**
69			* @return \SixtyEightPublishers\Application\ActiveProfile
70			*/
71			public function getProfile() : ActiveProfile
72			{
73			return $this->profile;
74			}
75
76			/**
77			* {@inheritdoc}
78			*/
79			public function persist()
80			{
81			$this->onPersist($this->profile);
			0 ignored issues – show Bug introduced 2017-01-08 23:06 UTC by Report Bug Copy Issue Report The method `onPersist()` does not exist on `SixtyEightPublishers\App...e\SessionProfileStorage`. Did you maybe mean `persist()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
82			$this->session['profileName'] = $this->profile->getName();
83			$this->session['profileCountry'] = $this->profile->getCountry();
84			$this->session['profileLanguage'] = $this->profile->getLanguage();
85			$this->session['profileCurrency'] = $this->profile->getCurrency();
86			}
87			}
88

68publishers / application

Push — master ( 9450db...32d720 )

SessionProfileStorage::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like