Field::mergeResolveConfig() - Code Metrics - Inspection of "refactor: use guesser" - 4rthem/graphql-mapper - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4bb4eb...402013 )

by Arthur

created 2016-03-06 22:04 UTC

Field::mergeResolveConfig() A

↳ Parent: Field

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	6
rs	9.4285
cc	1
eloc	3
nc	1
nop	1

<?php

namespace Arthem\GraphQLMapper\Mapping;

use GraphQL\Type\Definition\Type as GQLType;

class Field extends AbstractType
{
    /**
     * The model property name if different from the name
     *
     * @var string
     */
    private $property;

    /**
     * @var string
     */
    private $type;

    /**
     * @var callable|GQLType
     */
    private $resolvedType;

    /**
     * @var callable
     */
    private $resolve;

    /**
     * @var array
     */
    private $resolveConfig = array();

    /**
     * @var Field[]
     */
    private $arguments = [];

    /**
     * @return string
     */
    public function getProperty()
    {
        return $this->property;
    }

    /**
     * @param string $property
     * @return $this
     */
    public function setProperty($property)
    {
        $this->property = $property;

        return $this;
    }

    /**
     * @return string
     */
    public function getType()
    {
        return $this->type;
    }

    /**
     * @param string $type
     * @return $this
     */
    public function setType($type)
    {
        $this->type = $type;

        return $this;
    }

    /**
     * @return callable|GQLType
     */
    public function getResolvedType()
    {
        return $this->resolvedType;
    }

    /**
     * @param callable|GQLType $resolvedType
     * @return $this
     */
    public function setResolvedType($resolvedType)
    {
        $this->resolvedType = $resolvedType;

        return $this;
    }

    /**
     * @param array $resolveConfig
     * @return $this
     */
    public function mergeResolveConfig(array $resolveConfig)
    {
        $this->resolveConfig = array_merge($resolveConfig, $this->resolveConfig);

        return $this;
    }

    /**
     * @return callable
     */
    public function getResolve()
    {
        return $this->resolve;
    }

    /**
     * @param callable $resolve
     * @return $this
     */
    public function setResolve($resolve)
    {
        $this->resolve = $resolve;

        return $this;
    }

    /**
     * @return array
     */
    public function getResolveConfig()
    {
        return $this->resolveConfig;
    }

    /**
     * @param array $resolveConfig
     * @return $this
     */
    public function setResolveConfig(array $resolveConfig)
    {
        $this->resolveConfig = $resolveConfig;

        return $this;
    }

    /**
     * @param array $config
     * @return $this
     */
    public function mergeRevolveConfig(array $config)
    {
        $this->resolveConfig = array_merge($config, $this->resolveConfig);

        return $this;
    }

    /**
     * @return Field[]
     */
    public function getArguments()
    {
        return $this->arguments;
    }

    /**
     * @param Field[] $arguments
     * @return $this
     */
    public function setArguments(array $arguments)
    {
        $this->arguments = $arguments;

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function toMapping()
    {
        $mapping = [
                'type'           => $this->resolvedType,
                'resolve'        => $this->resolve,
                'resolve_config' => $this->resolveConfig,
            ] + parent::toMapping();

        if (!empty($this->arguments)) {
            $mapping['args'] = [];
            foreach ($this->arguments as $argument) {
                $mapping['args'][$argument->getName()] = $argument->toMapping();
            }
        }

        return $mapping;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }
}


1			<?php
2
3			namespace Arthem\GraphQLMapper\Mapping;
4
5			use GraphQL\Type\Definition\Type as GQLType;
6
7			class Field extends AbstractType
8			{
9			/**
10			* The model property name if different from the name
11			*
12			* @var string
13			*/
14			private $property;
15
16			/**
17			* @var string
18			*/
19			private $type;
20
21			/**
22			* @var callable\|GQLType
23			*/
24			private $resolvedType;
25
26			/**
27			* @var callable
28			*/
29			private $resolve;
30
31			/**
32			* @var array
33			*/
34			private $resolveConfig = array();
35
36			/**
37			* @var Field[]
38			*/
39			private $arguments = [];
40
41			/**
42			* @return string
43			*/
44			public function getProperty()
45			{
46			return $this->property;
47			}
48
49			/**
50			* @param string $property
51			* @return $this
52			*/
53			public function setProperty($property)
54			{
55			$this->property = $property;
56
57			return $this;
58			}
59
60			/**
61			* @return string
62			*/
63			public function getType()
64			{
65			return $this->type;
66			}
67
68			/**
69			* @param string $type
70			* @return $this
71			*/
72			public function setType($type)
73			{
74			$this->type = $type;
75
76			return $this;
77			}
78
79			/**
80			* @return callable\|GQLType
81			*/
82			public function getResolvedType()
83			{
84			return $this->resolvedType;
85			}
86
87			/**
88			* @param callable\|GQLType $resolvedType
89			* @return $this
90			*/
91			public function setResolvedType($resolvedType)
92			{
93			$this->resolvedType = $resolvedType;
94
95			return $this;
96			}
97
98			/**
99			* @param array $resolveConfig
100			* @return $this
101			*/
102			public function mergeResolveConfig(array $resolveConfig)
103			{
104			$this->resolveConfig = array_merge($resolveConfig, $this->resolveConfig);
105
106			return $this;
107			}
108
109			/**
110			* @return callable
111			*/
112			public function getResolve()
113			{
114			return $this->resolve;
115			}
116
117			/**
118			* @param callable $resolve
119			* @return $this
120			*/
121			public function setResolve($resolve)
122			{
123			$this->resolve = $resolve;
124
125			return $this;
126			}
127
128			/**
129			* @return array
130			*/
131			public function getResolveConfig()
132			{
133			return $this->resolveConfig;
134			}
135
136			/**
137			* @param array $resolveConfig
138			* @return $this
139			*/
140			public function setResolveConfig(array $resolveConfig)
141			{
142			$this->resolveConfig = $resolveConfig;
143
144			return $this;
145			}
146
147			/**
148			* @param array $config
149			* @return $this
150			*/
151			public function mergeRevolveConfig(array $config)
152			{
153			$this->resolveConfig = array_merge($config, $this->resolveConfig);
154
155			return $this;
156			}
157
158			/**
159			* @return Field[]
160			*/
161			public function getArguments()
162			{
163			return $this->arguments;
164			}
165
166			/**
167			* @param Field[] $arguments
168			* @return $this
169			*/
170			public function setArguments(array $arguments)
171			{
172			$this->arguments = $arguments;
173
174			return $this;
175			}
176
177			/**
178			* {@inheritdoc}
179			*/
180			public function toMapping()
181			{
182			$mapping = [
183			'type' => $this->resolvedType,
184			'resolve' => $this->resolve,
185			'resolve_config' => $this->resolveConfig,
186			] + parent::toMapping();
187
188			if (!empty($this->arguments)) {
189			$mapping['args'] = [];
190			foreach ($this->arguments as $argument) {
191			$mapping['args'][$argument->getName()] = $argument->toMapping();
192			}
193			}
194
195			return $mapping;
			0 ignored issues – show Bug Best Practice introduced 2016-01-03 19:27 UTC by Report Bug Copy Issue Report The return type of `return $mapping;` (`array<string,callable>`) is incompatible with the return type of the parent method `Arthem\GraphQLMapper\Map...AbstractType::toMapping` of type `array<string,string>`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
196			}
197			}
198

4rthem / graphql-mapper

Push — master ( 4bb4eb...402013 )

Field::mergeResolveConfig() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like