Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
14 | class MappingGuesserManager |
||
15 | { |
||
16 | /** |
||
17 | * @var GuesserInterface[] |
||
18 | */ |
||
19 | private $guessers; |
||
20 | |||
21 | /** |
||
22 | * @param SchemaContainer $schemaContainer |
||
23 | */ |
||
24 | public function guess(SchemaContainer $schemaContainer) |
||
37 | |||
38 | /** |
||
39 | * @param ContainerContext $containerContext |
||
40 | */ |
||
41 | private function guessFields(ContainerContext $containerContext) |
||
49 | |||
50 | /** |
||
51 | * @param FieldContext $fieldContext |
||
52 | */ |
||
53 | private function guessFieldType(FieldContext $fieldContext) |
||
76 | |||
77 | /** |
||
78 | * @param ContainerContext $containerContext |
||
79 | */ |
||
80 | private function guessTypeResolveConfig(ContainerContext $containerContext) |
||
94 | |||
95 | /** |
||
96 | * @param FieldContext $fieldContext |
||
97 | */ |
||
98 | private function guessFieldResolveConfig(FieldContext $fieldContext) |
||
112 | |||
113 | /** |
||
114 | * @param AbstractType|Type|Field $item |
||
115 | * @param array $guesses |
||
116 | */ |
||
117 | private function applyBestGuess(AbstractType $item, array $guesses) |
||
125 | |||
126 | /** |
||
127 | * Return the guess most likely to be correct from a list of guesses |
||
128 | * |
||
129 | * @param Guess[] $guesses An array of guesses |
||
130 | * @return Guess|null The guess with the highest confidence |
||
131 | */ |
||
132 | public function getBestGuess(array $guesses) |
||
146 | |||
147 | /** |
||
148 | * @param GuesserInterface $guesser |
||
149 | * @return $this |
||
150 | */ |
||
151 | public function addGuesser(GuesserInterface $guesser) |
||
157 | } |
||
158 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.