PlaceClient::details() - Code Metrics - Inspection of "reduce complexity" - 4rthem/google-api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 9df105...b9a551 )

by Arthur

created 2016-05-21 18:40 UTC

PlaceClient::details() A

↳ Parent: PlaceClient

Complexity

Conditions	2
Paths	2

Size

Total Lines	11
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	11
rs	9.4285
cc	2
eloc	6
nc	2
nop	1

<?php

namespace Arthem\GoogleApi\Infrastructure\Place;

use Arthem\GoogleApi\Domain\Place\Client\PlaceClientInterface;
use Arthem\GoogleApi\Infrastructure\Client\Client;
use Arthem\GoogleApi\Infrastructure\Place\Hydrator\PlaceHydrator;
use Arthem\GooglePlaces\Domain\Place\Exception\PlaceNotFoundException;
use GuzzleHttp\ClientInterface;

class PlaceClient extends Client implements PlaceClientInterface
{
    /**
     * {@inheritdoc}
     */
    protected $apiUrl = 'https://maps.googleapis.com/maps/api/place';

    /**
     * @var PlaceHydrator
     */
    private $placeHydrator;

    public function __construct(ClientInterface $httpClient, $decoder, $apiKey, PlaceHydrator $placeHydrator)
    {
        parent::__construct($httpClient, $decoder, $apiKey);
        $this->placeHydrator = $placeHydrator;
    }

    /**
     * {@inheritdoc}
     */
    public function nearbysearch(array $params)
    {
        $response = $this->request('GET', '/nearbysearch', $params);

        return $this->placeHydrator->hydratePlaces($response['results']);
    }

    /**
     * {@inheritdoc}
     */
    public function details(array $params)
    {
        $response = $this->request('GET', '/details', $params);
        $place = $this->placeHydrator->hydratePlace($response['result']);

        if (null === $place) {
            throw new PlaceNotFoundException(sprintf('The place was not found'));
        }

        return $place;
    }
}


1			<?php
2
3			namespace Arthem\GoogleApi\Infrastructure\Place;
4
5			use Arthem\GoogleApi\Domain\Place\Client\PlaceClientInterface;
6			use Arthem\GoogleApi\Infrastructure\Client\Client;
7			use Arthem\GoogleApi\Infrastructure\Place\Hydrator\PlaceHydrator;
8			use Arthem\GooglePlaces\Domain\Place\Exception\PlaceNotFoundException;
9			use GuzzleHttp\ClientInterface;
10
11			class PlaceClient extends Client implements PlaceClientInterface
12			{
13			/**
14			* {@inheritdoc}
15			*/
16			protected $apiUrl = 'https://maps.googleapis.com/maps/api/place';
17
18			/**
19			* @var PlaceHydrator
20			*/
21			private $placeHydrator;
22
23			public function __construct(ClientInterface $httpClient, $decoder, $apiKey, PlaceHydrator $placeHydrator)
24			{
25			parent::__construct($httpClient, $decoder, $apiKey);
26			$this->placeHydrator = $placeHydrator;
27			}
28
29			/**
30			* {@inheritdoc}
31			*/
32			public function nearbysearch(array $params)
33			{
34			$response = $this->request('GET', '/nearbysearch', $params);
35
36			return $this->placeHydrator->hydratePlaces($response['results']);
37			}
38
39			/**
40			* {@inheritdoc}
41			*/
42			public function details(array $params)
43			{
44			$response = $this->request('GET', '/details', $params);
45			$place = $this->placeHydrator->hydratePlace($response['result']);
46
47			if (null === $place) {
48			throw new PlaceNotFoundException(sprintf('The place was not found'));
49			}
50
51			return $place;
52			}
53			}
54

4rthem / google-api

Push — master ( 9df105...b9a551 )

PlaceClient::details() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like