| Conditions | 39 |
| Paths | 2 |
| Total Lines | 160 |
| Code Lines | 111 |
| Lines | 0 |
| Ratio | 0 % |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 29 | public function setRedTeamShipData($redTeamShipData) |
||
| 30 | { |
||
| 31 | // by Warringer\Types\Base |
||
| 32 | $converters = []; |
||
| 33 | $converters['physicsData'] = function ($value) { return $value; }; |
||
| 34 | $converters['missiles'] = function ($values) { |
||
| 35 | // by Warringer\Types\Dict |
||
| 36 | $converters = []; |
||
| 37 | $converters['itemID'] = function ($value) { return $value; }; |
||
| 38 | $converters['physicsData'] = function ($value) { return $value; }; |
||
| 39 | $converters['type'] = function ($value) { return new Reference($value); }; |
||
| 40 | |||
| 41 | $func = function ($value) use($converters) { |
||
| 42 | $return = new \ArrayObject($value, \ArrayObject::ARRAY_AS_PROPS); |
||
| 43 | $return['itemID'] = isset($value->{'itemID'}) ? $converters['itemID']($value->{'itemID'}) : null; |
||
| 44 | $return['physicsData'] = isset($value->{'physicsData'}) ? $converters['physicsData']($value->{'physicsData'}) : null; |
||
| 45 | $return['type'] = isset($value->{'type'}) ? $converters['type']($value->{'type'}) : null; |
||
| 46 | return $return; |
||
| 47 | }; |
||
| 48 | |||
| 49 | foreach ($values as $key => $value) { |
||
| 50 | $values[$key] = $func($value); |
||
| 51 | } |
||
| 52 | return $values; |
||
| 53 | }; |
||
| 54 | |||
| 55 | $converters['shield'] = function ($value) { return $value; }; |
||
| 56 | $converters['itemRef'] = function ($value) { return new Reference($value); }; |
||
| 57 | $converters['armor'] = function ($value) { return $value; }; |
||
| 58 | $converters['effects'] = function ($values) { |
||
| 59 | // by Warringer\Types\Base |
||
| 60 | $converters = []; |
||
| 61 | $converters['ammoGraphicResource'] = function ($value) { return new Reference($value); }; |
||
| 62 | $converters['targetID'] = function ($value) { return $value; }; |
||
| 63 | $converters['modules'] = function ($values) { |
||
| 64 | // by Warringer\Types\Dict |
||
| 65 | $converters = []; |
||
| 66 | $converters['moduleID'] = function ($value) { return $value; }; |
||
| 67 | |||
| 68 | $func = function ($value) use($converters) { |
||
| 69 | $return = new \ArrayObject($value, \ArrayObject::ARRAY_AS_PROPS); |
||
| 70 | $return['moduleID'] = isset($value->{'moduleID'}) ? $converters['moduleID']($value->{'moduleID'}) : null; |
||
| 71 | return $return; |
||
| 72 | }; |
||
| 73 | |||
| 74 | foreach ($values as $key => $value) { |
||
| 75 | $values[$key] = $func($value); |
||
| 76 | } |
||
| 77 | return $values; |
||
| 78 | }; |
||
| 79 | |||
| 80 | $converters['effectName'] = function ($value) { return $value; }; |
||
| 81 | $converters['startTime'] = function ($value) { return $value; }; |
||
| 82 | $converters['duration'] = function ($value) { return $value; }; |
||
| 83 | $converters['guid'] = function ($value) { return $value; }; |
||
| 84 | |||
| 85 | $func = function ($value) use($converters) { |
||
| 86 | $return = new \ArrayObject($value, \ArrayObject::ARRAY_AS_PROPS); |
||
| 87 | $return['ammoGraphicResource'] = isset($value->{'ammoGraphicResource'}) ? $converters['ammoGraphicResource']($value->{'ammoGraphicResource'}) : null; |
||
| 88 | $return['targetID'] = isset($value->{'targetID'}) ? $converters['targetID']($value->{'targetID'}) : null; |
||
| 89 | $return['modules'] = isset($value->{'modules'}) ? $converters['modules']($value->{'modules'}) : null; |
||
| 90 | $return['effectName'] = isset($value->{'effectName'}) ? $converters['effectName']($value->{'effectName'}) : null; |
||
| 91 | $return['startTime'] = isset($value->{'startTime'}) ? $converters['startTime']($value->{'startTime'}) : null; |
||
| 92 | $return['duration'] = isset($value->{'duration'}) ? $converters['duration']($value->{'duration'}) : null; |
||
| 93 | $return['guid'] = isset($value->{'guid'}) ? $converters['guid']($value->{'guid'}) : null; |
||
| 94 | return $return; |
||
| 95 | }; |
||
| 96 | |||
| 97 | foreach ($values as $key => $value) { |
||
| 98 | $values[$key] = $func($value); |
||
| 99 | } |
||
| 100 | return $values; |
||
| 101 | }; |
||
| 102 | |||
| 103 | $converters['drones'] = function ($values) { |
||
| 104 | // by Warringer\Types\Dict |
||
| 105 | $converters = []; |
||
| 106 | $converters['itemID'] = function ($value) { return $value; }; |
||
| 107 | $converters['physicsData'] = function ($value) { return $value; }; |
||
| 108 | $converters['type'] = function ($value) { return new Reference($value); }; |
||
| 109 | $converters['effects'] = function ($values) { |
||
| 110 | // by Warringer\Types\Base |
||
| 111 | $converters = []; |
||
| 112 | $converters['ammoGraphicResource'] = function ($value) { return new Reference($value); }; |
||
| 113 | $converters['targetID'] = function ($value) { return $value; }; |
||
| 114 | $converters['modules'] = function ($values) { |
||
| 115 | // by Warringer\Types\Dict |
||
| 116 | $converters = []; |
||
| 117 | $converters['moduleID'] = function ($value) { return $value; }; |
||
| 118 | |||
| 119 | $func = function ($value) use($converters) { |
||
| 120 | $return = new \ArrayObject($value, \ArrayObject::ARRAY_AS_PROPS); |
||
| 121 | $return['moduleID'] = isset($value->{'moduleID'}) ? $converters['moduleID']($value->{'moduleID'}) : null; |
||
| 122 | return $return; |
||
| 123 | }; |
||
| 124 | |||
| 125 | foreach ($values as $key => $value) { |
||
| 126 | $values[$key] = $func($value); |
||
| 127 | } |
||
| 128 | return $values; |
||
| 129 | }; |
||
| 130 | |||
| 131 | $converters['effectName'] = function ($value) { return $value; }; |
||
| 132 | $converters['startTime'] = function ($value) { return $value; }; |
||
| 133 | $converters['duration'] = function ($value) { return $value; }; |
||
| 134 | $converters['guid'] = function ($value) { return $value; }; |
||
| 135 | |||
| 136 | $func = function ($value) use($converters) { |
||
| 137 | $return = new \ArrayObject($value, \ArrayObject::ARRAY_AS_PROPS); |
||
| 138 | $return['ammoGraphicResource'] = isset($value->{'ammoGraphicResource'}) ? $converters['ammoGraphicResource']($value->{'ammoGraphicResource'}) : null; |
||
| 139 | $return['targetID'] = isset($value->{'targetID'}) ? $converters['targetID']($value->{'targetID'}) : null; |
||
| 140 | $return['modules'] = isset($value->{'modules'}) ? $converters['modules']($value->{'modules'}) : null; |
||
| 141 | $return['effectName'] = isset($value->{'effectName'}) ? $converters['effectName']($value->{'effectName'}) : null; |
||
| 142 | $return['startTime'] = isset($value->{'startTime'}) ? $converters['startTime']($value->{'startTime'}) : null; |
||
| 143 | $return['duration'] = isset($value->{'duration'}) ? $converters['duration']($value->{'duration'}) : null; |
||
| 144 | $return['guid'] = isset($value->{'guid'}) ? $converters['guid']($value->{'guid'}) : null; |
||
| 145 | return $return; |
||
| 146 | }; |
||
| 147 | |||
| 148 | foreach ($values as $key => $value) { |
||
| 149 | $values[$key] = $func($value); |
||
| 150 | } |
||
| 151 | return $values; |
||
| 152 | }; |
||
| 153 | |||
| 154 | |||
| 155 | $func = function ($value) use($converters) { |
||
| 156 | $return = new \ArrayObject($value, \ArrayObject::ARRAY_AS_PROPS); |
||
| 157 | $return['itemID'] = isset($value->{'itemID'}) ? $converters['itemID']($value->{'itemID'}) : null; |
||
| 158 | $return['physicsData'] = isset($value->{'physicsData'}) ? $converters['physicsData']($value->{'physicsData'}) : null; |
||
| 159 | $return['type'] = isset($value->{'type'}) ? $converters['type']($value->{'type'}) : null; |
||
| 160 | $return['effects'] = isset($value->{'effects'}) ? $converters['effects']($value->{'effects'}) : null; |
||
| 161 | return $return; |
||
| 162 | }; |
||
| 163 | |||
| 164 | foreach ($values as $key => $value) { |
||
| 165 | $values[$key] = $func($value); |
||
| 166 | } |
||
| 167 | return $values; |
||
| 168 | }; |
||
| 169 | |||
| 170 | $converters['structure'] = function ($value) { return $value; }; |
||
| 171 | |||
| 172 | $func = function ($value) use($converters) { |
||
| 173 | $return = new \ArrayObject($value, \ArrayObject::ARRAY_AS_PROPS); |
||
| 174 | $return['physicsData'] = isset($value->{'physicsData'}) ? $converters['physicsData']($value->{'physicsData'}) : null; |
||
| 175 | $return['missiles'] = isset($value->{'missiles'}) ? $converters['missiles']($value->{'missiles'}) : null; |
||
| 176 | $return['shield'] = isset($value->{'shield'}) ? $converters['shield']($value->{'shield'}) : null; |
||
| 177 | $return['itemRef'] = isset($value->{'itemRef'}) ? $converters['itemRef']($value->{'itemRef'}) : null; |
||
| 178 | $return['armor'] = isset($value->{'armor'}) ? $converters['armor']($value->{'armor'}) : null; |
||
| 179 | $return['effects'] = isset($value->{'effects'}) ? $converters['effects']($value->{'effects'}) : null; |
||
| 180 | $return['drones'] = isset($value->{'drones'}) ? $converters['drones']($value->{'drones'}) : null; |
||
| 181 | $return['structure'] = isset($value->{'structure'}) ? $converters['structure']($value->{'structure'}) : null; |
||
| 182 | return $return; |
||
| 183 | }; |
||
| 184 | |||
| 185 | foreach ($redTeamShipData as $key => $value) { |
||
| 186 | $this->redTeamShipData[$key] = $func($value); |
||
| 187 | } |
||
| 188 | } |
||
| 189 | |||
| 433 |