| Conditions | 39 |
| Paths | 2 |
| Total Lines | 160 |
| Code Lines | 111 |
| Lines | 0 |
| Ratio | 0 % |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 191 | public function setBlueTeamShipData($blueTeamShipData) |
||
| 192 | { |
||
| 193 | // by Warringer\Types\Base |
||
| 194 | $converters = []; |
||
| 195 | $converters['physicsData'] = function ($value) { return $value; }; |
||
| 196 | $converters['missiles'] = function ($values) { |
||
| 197 | // by Warringer\Types\Dict |
||
| 198 | $converters = []; |
||
| 199 | $converters['itemID'] = function ($value) { return $value; }; |
||
| 200 | $converters['physicsData'] = function ($value) { return $value; }; |
||
| 201 | $converters['type'] = function ($value) { return new Reference($value); }; |
||
| 202 | |||
| 203 | $func = function ($value) use($converters) { |
||
| 204 | $return = new \ArrayObject($value, \ArrayObject::ARRAY_AS_PROPS); |
||
| 205 | $return['itemID'] = isset($value->{'itemID'}) ? $converters['itemID']($value->{'itemID'}) : null; |
||
| 206 | $return['physicsData'] = isset($value->{'physicsData'}) ? $converters['physicsData']($value->{'physicsData'}) : null; |
||
| 207 | $return['type'] = isset($value->{'type'}) ? $converters['type']($value->{'type'}) : null; |
||
| 208 | return $return; |
||
| 209 | }; |
||
| 210 | |||
| 211 | foreach ($values as $key => $value) { |
||
| 212 | $values[$key] = $func($value); |
||
| 213 | } |
||
| 214 | return $values; |
||
| 215 | }; |
||
| 216 | |||
| 217 | $converters['shield'] = function ($value) { return $value; }; |
||
| 218 | $converters['itemRef'] = function ($value) { return new Reference($value); }; |
||
| 219 | $converters['armor'] = function ($value) { return $value; }; |
||
| 220 | $converters['effects'] = function ($values) { |
||
| 221 | // by Warringer\Types\Base |
||
| 222 | $converters = []; |
||
| 223 | $converters['ammoGraphicResource'] = function ($value) { return new Reference($value); }; |
||
| 224 | $converters['targetID'] = function ($value) { return $value; }; |
||
| 225 | $converters['modules'] = function ($values) { |
||
| 226 | // by Warringer\Types\Dict |
||
| 227 | $converters = []; |
||
| 228 | $converters['moduleID'] = function ($value) { return $value; }; |
||
| 229 | |||
| 230 | $func = function ($value) use($converters) { |
||
| 231 | $return = new \ArrayObject($value, \ArrayObject::ARRAY_AS_PROPS); |
||
| 232 | $return['moduleID'] = isset($value->{'moduleID'}) ? $converters['moduleID']($value->{'moduleID'}) : null; |
||
| 233 | return $return; |
||
| 234 | }; |
||
| 235 | |||
| 236 | foreach ($values as $key => $value) { |
||
| 237 | $values[$key] = $func($value); |
||
| 238 | } |
||
| 239 | return $values; |
||
| 240 | }; |
||
| 241 | |||
| 242 | $converters['effectName'] = function ($value) { return $value; }; |
||
| 243 | $converters['startTime'] = function ($value) { return $value; }; |
||
| 244 | $converters['duration'] = function ($value) { return $value; }; |
||
| 245 | $converters['guid'] = function ($value) { return $value; }; |
||
| 246 | |||
| 247 | $func = function ($value) use($converters) { |
||
| 248 | $return = new \ArrayObject($value, \ArrayObject::ARRAY_AS_PROPS); |
||
| 249 | $return['ammoGraphicResource'] = isset($value->{'ammoGraphicResource'}) ? $converters['ammoGraphicResource']($value->{'ammoGraphicResource'}) : null; |
||
| 250 | $return['targetID'] = isset($value->{'targetID'}) ? $converters['targetID']($value->{'targetID'}) : null; |
||
| 251 | $return['modules'] = isset($value->{'modules'}) ? $converters['modules']($value->{'modules'}) : null; |
||
| 252 | $return['effectName'] = isset($value->{'effectName'}) ? $converters['effectName']($value->{'effectName'}) : null; |
||
| 253 | $return['startTime'] = isset($value->{'startTime'}) ? $converters['startTime']($value->{'startTime'}) : null; |
||
| 254 | $return['duration'] = isset($value->{'duration'}) ? $converters['duration']($value->{'duration'}) : null; |
||
| 255 | $return['guid'] = isset($value->{'guid'}) ? $converters['guid']($value->{'guid'}) : null; |
||
| 256 | return $return; |
||
| 257 | }; |
||
| 258 | |||
| 259 | foreach ($values as $key => $value) { |
||
| 260 | $values[$key] = $func($value); |
||
| 261 | } |
||
| 262 | return $values; |
||
| 263 | }; |
||
| 264 | |||
| 265 | $converters['drones'] = function ($values) { |
||
| 266 | // by Warringer\Types\Dict |
||
| 267 | $converters = []; |
||
| 268 | $converters['itemID'] = function ($value) { return $value; }; |
||
| 269 | $converters['physicsData'] = function ($value) { return $value; }; |
||
| 270 | $converters['type'] = function ($value) { return new Reference($value); }; |
||
| 271 | $converters['effects'] = function ($values) { |
||
| 272 | // by Warringer\Types\Base |
||
| 273 | $converters = []; |
||
| 274 | $converters['ammoGraphicResource'] = function ($value) { return new Reference($value); }; |
||
| 275 | $converters['targetID'] = function ($value) { return $value; }; |
||
| 276 | $converters['modules'] = function ($values) { |
||
| 277 | // by Warringer\Types\Dict |
||
| 278 | $converters = []; |
||
| 279 | $converters['moduleID'] = function ($value) { return $value; }; |
||
| 280 | |||
| 281 | $func = function ($value) use($converters) { |
||
| 282 | $return = new \ArrayObject($value, \ArrayObject::ARRAY_AS_PROPS); |
||
| 283 | $return['moduleID'] = isset($value->{'moduleID'}) ? $converters['moduleID']($value->{'moduleID'}) : null; |
||
| 284 | return $return; |
||
| 285 | }; |
||
| 286 | |||
| 287 | foreach ($values as $key => $value) { |
||
| 288 | $values[$key] = $func($value); |
||
| 289 | } |
||
| 290 | return $values; |
||
| 291 | }; |
||
| 292 | |||
| 293 | $converters['effectName'] = function ($value) { return $value; }; |
||
| 294 | $converters['startTime'] = function ($value) { return $value; }; |
||
| 295 | $converters['duration'] = function ($value) { return $value; }; |
||
| 296 | $converters['guid'] = function ($value) { return $value; }; |
||
| 297 | |||
| 298 | $func = function ($value) use($converters) { |
||
| 299 | $return = new \ArrayObject($value, \ArrayObject::ARRAY_AS_PROPS); |
||
| 300 | $return['ammoGraphicResource'] = isset($value->{'ammoGraphicResource'}) ? $converters['ammoGraphicResource']($value->{'ammoGraphicResource'}) : null; |
||
| 301 | $return['targetID'] = isset($value->{'targetID'}) ? $converters['targetID']($value->{'targetID'}) : null; |
||
| 302 | $return['modules'] = isset($value->{'modules'}) ? $converters['modules']($value->{'modules'}) : null; |
||
| 303 | $return['effectName'] = isset($value->{'effectName'}) ? $converters['effectName']($value->{'effectName'}) : null; |
||
| 304 | $return['startTime'] = isset($value->{'startTime'}) ? $converters['startTime']($value->{'startTime'}) : null; |
||
| 305 | $return['duration'] = isset($value->{'duration'}) ? $converters['duration']($value->{'duration'}) : null; |
||
| 306 | $return['guid'] = isset($value->{'guid'}) ? $converters['guid']($value->{'guid'}) : null; |
||
| 307 | return $return; |
||
| 308 | }; |
||
| 309 | |||
| 310 | foreach ($values as $key => $value) { |
||
| 311 | $values[$key] = $func($value); |
||
| 312 | } |
||
| 313 | return $values; |
||
| 314 | }; |
||
| 315 | |||
| 316 | |||
| 317 | $func = function ($value) use($converters) { |
||
| 318 | $return = new \ArrayObject($value, \ArrayObject::ARRAY_AS_PROPS); |
||
| 319 | $return['itemID'] = isset($value->{'itemID'}) ? $converters['itemID']($value->{'itemID'}) : null; |
||
| 320 | $return['physicsData'] = isset($value->{'physicsData'}) ? $converters['physicsData']($value->{'physicsData'}) : null; |
||
| 321 | $return['type'] = isset($value->{'type'}) ? $converters['type']($value->{'type'}) : null; |
||
| 322 | $return['effects'] = isset($value->{'effects'}) ? $converters['effects']($value->{'effects'}) : null; |
||
| 323 | return $return; |
||
| 324 | }; |
||
| 325 | |||
| 326 | foreach ($values as $key => $value) { |
||
| 327 | $values[$key] = $func($value); |
||
| 328 | } |
||
| 329 | return $values; |
||
| 330 | }; |
||
| 331 | |||
| 332 | $converters['structure'] = function ($value) { return $value; }; |
||
| 333 | |||
| 334 | $func = function ($value) use($converters) { |
||
| 335 | $return = new \ArrayObject($value, \ArrayObject::ARRAY_AS_PROPS); |
||
| 336 | $return['physicsData'] = isset($value->{'physicsData'}) ? $converters['physicsData']($value->{'physicsData'}) : null; |
||
| 337 | $return['missiles'] = isset($value->{'missiles'}) ? $converters['missiles']($value->{'missiles'}) : null; |
||
| 338 | $return['shield'] = isset($value->{'shield'}) ? $converters['shield']($value->{'shield'}) : null; |
||
| 339 | $return['itemRef'] = isset($value->{'itemRef'}) ? $converters['itemRef']($value->{'itemRef'}) : null; |
||
| 340 | $return['armor'] = isset($value->{'armor'}) ? $converters['armor']($value->{'armor'}) : null; |
||
| 341 | $return['effects'] = isset($value->{'effects'}) ? $converters['effects']($value->{'effects'}) : null; |
||
| 342 | $return['drones'] = isset($value->{'drones'}) ? $converters['drones']($value->{'drones'}) : null; |
||
| 343 | $return['structure'] = isset($value->{'structure'}) ? $converters['structure']($value->{'structure'}) : null; |
||
| 344 | return $return; |
||
| 345 | }; |
||
| 346 | |||
| 347 | foreach ($blueTeamShipData as $key => $value) { |
||
| 348 | $this->blueTeamShipData[$key] = $func($value); |
||
| 349 | } |
||
| 350 | } |
||
| 351 | |||
| 433 |