Conditions | 10 |
Paths | 1 |
Total Lines | 41 |
Code Lines | 29 |
Lines | 0 |
Ratio | 0 % |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
37 | public function setExtraAttributes($extraAttributes) |
||
38 | { |
||
39 | // by Warringer\Types\Dict |
||
40 | $converters = []; |
||
41 | $converters['skeletalMeshMale'] = function ($value) { return $value; }; |
||
42 | $converters['modifier'] = function ($values) { |
||
43 | // by Warringer\Types\Dict |
||
44 | $converters = []; |
||
45 | $converters['modifierValue'] = function ($value) { return $value; }; |
||
46 | $converters['attributeName'] = function ($value) { return $value; }; |
||
47 | $converters['modifierType'] = function ($value) { return $value; }; |
||
48 | |||
49 | $func = function ($value) use($converters) { |
||
50 | $return = new \ArrayObject($value, \ArrayObject::ARRAY_AS_PROPS); |
||
51 | $return['modifierValue'] = isset($value->{'modifierValue'}) ? $converters['modifierValue']($value->{'modifierValue'}) : null; |
||
52 | $return['attributeName'] = isset($value->{'attributeName'}) ? $converters['attributeName']($value->{'attributeName'}) : null; |
||
53 | $return['modifierType'] = isset($value->{'modifierType'}) ? $converters['modifierType']($value->{'modifierType'}) : null; |
||
54 | return $return; |
||
55 | }; |
||
56 | |||
57 | foreach ($values as $key => $value) { |
||
58 | $values[$key] = $func($value); |
||
59 | } |
||
60 | return $values; |
||
61 | }; |
||
62 | |||
63 | $converters['slotType'] = function ($value) { return $value; }; |
||
64 | $converters['skeletalMeshFemale'] = function ($value) { return $value; }; |
||
65 | $converters['mVICProp'] = function ($value) { return $value; }; |
||
66 | |||
67 | $func = function ($value) use($converters) { |
||
68 | $return = new \ArrayObject($value, \ArrayObject::ARRAY_AS_PROPS); |
||
69 | $return['skeletalMeshMale'] = isset($value->{'skeletalMeshMale'}) ? $converters['skeletalMeshMale']($value->{'skeletalMeshMale'}) : null; |
||
70 | $return['modifier'] = isset($value->{'modifier'}) ? $converters['modifier']($value->{'modifier'}) : null; |
||
71 | $return['slotType'] = isset($value->{'slotType'}) ? $converters['slotType']($value->{'slotType'}) : null; |
||
72 | $return['skeletalMeshFemale'] = isset($value->{'skeletalMeshFemale'}) ? $converters['skeletalMeshFemale']($value->{'skeletalMeshFemale'}) : null; |
||
73 | $return['mVICProp'] = isset($value->{'mVICProp'}) ? $converters['mVICProp']($value->{'mVICProp'}) : null; |
||
74 | return $return; |
||
75 | }; |
||
76 | $this->extraAttributes = $func($extraAttributes); |
||
77 | } |
||
78 | |||
117 |