Conditions | 15 |
Paths | 2 |
Total Lines | 40 |
Code Lines | 33 |
Lines | 0 |
Ratio | 0 % |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
27 | public function setItems($items) |
||
28 | { |
||
29 | // by Warringer\Types\Base |
||
30 | $converters = []; |
||
31 | $converters['winner'] = function ($value) { return new Reference($value); }; |
||
32 | $converters['stats'] = function ($value) { return $value; }; |
||
33 | $converters['redTeam'] = function ($value) { return new Reference($value); }; |
||
34 | $converters['bans'] = function ($value) { return $value; }; |
||
35 | $converters['finalized'] = function ($value) { return $value; }; |
||
36 | $converters['series'] = function ($value) { return new Reference($value); }; |
||
37 | $converters['tournament'] = function ($value) { return new Reference($value); }; |
||
38 | $converters['staticSceneData'] = function ($value) { return new Reference($value); }; |
||
39 | $converters['firstReplayFrame'] = function ($value) { return new Reference($value); }; |
||
40 | $converters['lastReplayFrame'] = function ($value) { return new Reference($value); }; |
||
41 | $converters['blueTeam'] = function ($value) { return new Reference($value); }; |
||
42 | $converters['inProgress'] = function ($value) { return $value; }; |
||
43 | $converters['score'] = function ($value) { return $value; }; |
||
44 | |||
45 | $func = function ($value) use($converters) { |
||
46 | $return = new \ArrayObject($value, \ArrayObject::ARRAY_AS_PROPS); |
||
47 | $return['winner'] = isset($value->{'winner'}) ? $converters['winner']($value->{'winner'}) : null; |
||
48 | $return['stats'] = isset($value->{'stats'}) ? $converters['stats']($value->{'stats'}) : null; |
||
49 | $return['redTeam'] = isset($value->{'redTeam'}) ? $converters['redTeam']($value->{'redTeam'}) : null; |
||
50 | $return['bans'] = isset($value->{'bans'}) ? $converters['bans']($value->{'bans'}) : null; |
||
51 | $return['finalized'] = isset($value->{'finalized'}) ? $converters['finalized']($value->{'finalized'}) : null; |
||
52 | $return['series'] = isset($value->{'series'}) ? $converters['series']($value->{'series'}) : null; |
||
53 | $return['tournament'] = isset($value->{'tournament'}) ? $converters['tournament']($value->{'tournament'}) : null; |
||
54 | $return['staticSceneData'] = isset($value->{'staticSceneData'}) ? $converters['staticSceneData']($value->{'staticSceneData'}) : null; |
||
55 | $return['firstReplayFrame'] = isset($value->{'firstReplayFrame'}) ? $converters['firstReplayFrame']($value->{'firstReplayFrame'}) : null; |
||
56 | $return['lastReplayFrame'] = isset($value->{'lastReplayFrame'}) ? $converters['lastReplayFrame']($value->{'lastReplayFrame'}) : null; |
||
57 | $return['blueTeam'] = isset($value->{'blueTeam'}) ? $converters['blueTeam']($value->{'blueTeam'}) : null; |
||
58 | $return['inProgress'] = isset($value->{'inProgress'}) ? $converters['inProgress']($value->{'inProgress'}) : null; |
||
59 | $return['score'] = isset($value->{'score'}) ? $converters['score']($value->{'score'}) : null; |
||
60 | return $return; |
||
61 | }; |
||
62 | |||
63 | foreach ($items as $key => $value) { |
||
64 | $this->items[$key] = $func($value); |
||
65 | } |
||
66 | } |
||
67 | |||
87 |