| Conditions | 21 |
| Paths | 1 |
| Total Lines | 75 |
| Code Lines | 56 |
| Lines | 0 |
| Ratio | 0 % |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 91 | public function setVictim($victim) |
||
| 92 | { |
||
| 93 | // by Warringer\Types\Dict |
||
| 94 | $converters = []; |
||
| 95 | $converters['alliance'] = function ($value) { return new Reference($value); }; |
||
| 96 | $converters['faction'] = function ($value) { return new Reference($value); }; |
||
| 97 | $converters['corporation'] = function ($value) { return new Reference($value); }; |
||
| 98 | $converters['damageTaken'] = function ($value) { return $value; }; |
||
| 99 | $converters['character'] = function ($value) { return new Reference($value); }; |
||
| 100 | $converters['shipType'] = function ($value) { return new Reference($value); }; |
||
| 101 | $converters['items'] = function ($values) { |
||
| 102 | // by Warringer\Types\Base |
||
| 103 | $converters = []; |
||
| 104 | $converters['singleton'] = function ($value) { return $value; }; |
||
| 105 | $converters['itemType'] = function ($value) { return new Reference($value); }; |
||
| 106 | $converters['items'] = function ($values) { |
||
| 107 | // by Warringer\Types\Dict |
||
| 108 | $converters = []; |
||
| 109 | $converters['quantityDropped'] = function ($value) { return $value; }; |
||
| 110 | $converters['singleton'] = function ($value) { return $value; }; |
||
| 111 | $converters['quantityDestroyed'] = function ($value) { return $value; }; |
||
| 112 | $converters['flag'] = function ($value) { return $value; }; |
||
| 113 | $converters['itemType'] = function ($value) { return new Reference($value); }; |
||
| 114 | |||
| 115 | $func = function ($value) use($converters) { |
||
| 116 | $return = new \ArrayObject($value, \ArrayObject::ARRAY_AS_PROPS); |
||
| 117 | $return['quantityDropped'] = isset($value->{'quantityDropped'}) ? $converters['quantityDropped']($value->{'quantityDropped'}) : null; |
||
| 118 | $return['singleton'] = isset($value->{'singleton'}) ? $converters['singleton']($value->{'singleton'}) : null; |
||
| 119 | $return['quantityDestroyed'] = isset($value->{'quantityDestroyed'}) ? $converters['quantityDestroyed']($value->{'quantityDestroyed'}) : null; |
||
| 120 | $return['flag'] = isset($value->{'flag'}) ? $converters['flag']($value->{'flag'}) : null; |
||
| 121 | $return['itemType'] = isset($value->{'itemType'}) ? $converters['itemType']($value->{'itemType'}) : null; |
||
| 122 | return $return; |
||
| 123 | }; |
||
| 124 | |||
| 125 | foreach ($values as $key => $value) { |
||
| 126 | $values[$key] = $func($value); |
||
| 127 | } |
||
| 128 | return $values; |
||
| 129 | }; |
||
| 130 | |||
| 131 | $converters['flag'] = function ($value) { return $value; }; |
||
| 132 | $converters['quantityDropped'] = function ($value) { return $value; }; |
||
| 133 | $converters['quantityDestroyed'] = function ($value) { return $value; }; |
||
| 134 | |||
| 135 | $func = function ($value) use($converters) { |
||
| 136 | $return = new \ArrayObject($value, \ArrayObject::ARRAY_AS_PROPS); |
||
| 137 | $return['singleton'] = isset($value->{'singleton'}) ? $converters['singleton']($value->{'singleton'}) : null; |
||
| 138 | $return['itemType'] = isset($value->{'itemType'}) ? $converters['itemType']($value->{'itemType'}) : null; |
||
| 139 | $return['items'] = isset($value->{'items'}) ? $converters['items']($value->{'items'}) : null; |
||
| 140 | $return['flag'] = isset($value->{'flag'}) ? $converters['flag']($value->{'flag'}) : null; |
||
| 141 | $return['quantityDropped'] = isset($value->{'quantityDropped'}) ? $converters['quantityDropped']($value->{'quantityDropped'}) : null; |
||
| 142 | $return['quantityDestroyed'] = isset($value->{'quantityDestroyed'}) ? $converters['quantityDestroyed']($value->{'quantityDestroyed'}) : null; |
||
| 143 | return $return; |
||
| 144 | }; |
||
| 145 | |||
| 146 | foreach ($values as $key => $value) { |
||
| 147 | $values[$key] = $func($value); |
||
| 148 | } |
||
| 149 | return $values; |
||
| 150 | }; |
||
| 151 | |||
| 152 | |||
| 153 | $func = function ($value) use($converters) { |
||
| 154 | $return = new \ArrayObject($value, \ArrayObject::ARRAY_AS_PROPS); |
||
| 155 | $return['alliance'] = isset($value->{'alliance'}) ? $converters['alliance']($value->{'alliance'}) : null; |
||
| 156 | $return['faction'] = isset($value->{'faction'}) ? $converters['faction']($value->{'faction'}) : null; |
||
| 157 | $return['corporation'] = isset($value->{'corporation'}) ? $converters['corporation']($value->{'corporation'}) : null; |
||
| 158 | $return['damageTaken'] = isset($value->{'damageTaken'}) ? $converters['damageTaken']($value->{'damageTaken'}) : null; |
||
| 159 | $return['character'] = isset($value->{'character'}) ? $converters['character']($value->{'character'}) : null; |
||
| 160 | $return['shipType'] = isset($value->{'shipType'}) ? $converters['shipType']($value->{'shipType'}) : null; |
||
| 161 | $return['items'] = isset($value->{'items'}) ? $converters['items']($value->{'items'}) : null; |
||
| 162 | return $return; |
||
| 163 | }; |
||
| 164 | $this->victim = $func($victim); |
||
| 165 | } |
||
| 166 | |||
| 174 |