Conditions | 28 |
Paths | 2 |
Total Lines | 66 |
Code Lines | 59 |
Lines | 0 |
Ratio | 0 % |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
27 | public function setItems($items) |
||
28 | { |
||
29 | // by Warringer\Types\Base |
||
30 | $converters = []; |
||
31 | $converters['startDate'] = function ($value) { return $value; }; |
||
32 | $converters['updateClonesQuote'] = function ($value) { return new Reference($value); }; |
||
33 | $converters['owner'] = function ($value) { return new Reference($value); }; |
||
34 | $converters['reinforce'] = function ($value) { return $value; }; |
||
35 | $converters['href'] = function ($value) { return new Uri($value); }; |
||
36 | $converters['conquerable'] = function ($value) { return $value; }; |
||
37 | $converters['constellation'] = function ($value) { return new Reference($value); }; |
||
38 | $converters['id'] = function ($value) { return $value; }; |
||
39 | $converters['nextReinforce'] = function ($value) { return $value; }; |
||
40 | $converters['index'] = function ($value) { return $value; }; |
||
41 | $converters['system'] = function ($value) { return new Reference($value); }; |
||
42 | $converters['cloneCapacity'] = function ($value) { return $value; }; |
||
43 | $converters['latitude'] = function ($value) { return $value; }; |
||
44 | $converters['generating'] = function ($value) { return $value; }; |
||
45 | $converters['infrastructure'] = function ($value) { return new Reference($value); }; |
||
46 | $converters['attacked'] = function ($value) { return $value; }; |
||
47 | $converters['updateClones'] = function ($value) { return new Reference($value); }; |
||
48 | $converters['cloneRate'] = function ($value) { return $value; }; |
||
49 | $converters['clones'] = function ($value) { return $value; }; |
||
50 | $converters['locked'] = function ($value) { return $value; }; |
||
51 | $converters['name'] = function ($value) { return $value; }; |
||
52 | $converters['region'] = function ($value) { return new Reference($value); }; |
||
53 | $converters['longitude'] = function ($value) { return $value; }; |
||
54 | $converters['planet'] = function ($value) { return new Reference($value); }; |
||
55 | $converters['updateInfrastructure'] = function ($value) { return new Reference($value); }; |
||
56 | $converters['updateReinforce'] = function ($value) { return new Reference($value); }; |
||
57 | |||
58 | $func = function ($value) use($converters) { |
||
59 | $return = new \ArrayObject($value, \ArrayObject::ARRAY_AS_PROPS); |
||
60 | $return['startDate'] = isset($value->{'startDate'}) ? $converters['startDate']($value->{'startDate'}) : null; |
||
61 | $return['updateClonesQuote'] = isset($value->{'updateClonesQuote'}) ? $converters['updateClonesQuote']($value->{'updateClonesQuote'}) : null; |
||
62 | $return['owner'] = isset($value->{'owner'}) ? $converters['owner']($value->{'owner'}) : null; |
||
63 | $return['reinforce'] = isset($value->{'reinforce'}) ? $converters['reinforce']($value->{'reinforce'}) : null; |
||
64 | $return['href'] = isset($value->{'href'}) ? $converters['href']($value->{'href'}) : null; |
||
65 | $return['conquerable'] = isset($value->{'conquerable'}) ? $converters['conquerable']($value->{'conquerable'}) : null; |
||
66 | $return['constellation'] = isset($value->{'constellation'}) ? $converters['constellation']($value->{'constellation'}) : null; |
||
67 | $return['id'] = isset($value->{'id'}) ? $converters['id']($value->{'id'}) : null; |
||
68 | $return['nextReinforce'] = isset($value->{'nextReinforce'}) ? $converters['nextReinforce']($value->{'nextReinforce'}) : null; |
||
69 | $return['index'] = isset($value->{'index'}) ? $converters['index']($value->{'index'}) : null; |
||
70 | $return['system'] = isset($value->{'system'}) ? $converters['system']($value->{'system'}) : null; |
||
71 | $return['cloneCapacity'] = isset($value->{'cloneCapacity'}) ? $converters['cloneCapacity']($value->{'cloneCapacity'}) : null; |
||
72 | $return['latitude'] = isset($value->{'latitude'}) ? $converters['latitude']($value->{'latitude'}) : null; |
||
73 | $return['generating'] = isset($value->{'generating'}) ? $converters['generating']($value->{'generating'}) : null; |
||
74 | $return['infrastructure'] = isset($value->{'infrastructure'}) ? $converters['infrastructure']($value->{'infrastructure'}) : null; |
||
75 | $return['attacked'] = isset($value->{'attacked'}) ? $converters['attacked']($value->{'attacked'}) : null; |
||
76 | $return['updateClones'] = isset($value->{'updateClones'}) ? $converters['updateClones']($value->{'updateClones'}) : null; |
||
77 | $return['cloneRate'] = isset($value->{'cloneRate'}) ? $converters['cloneRate']($value->{'cloneRate'}) : null; |
||
78 | $return['clones'] = isset($value->{'clones'}) ? $converters['clones']($value->{'clones'}) : null; |
||
79 | $return['locked'] = isset($value->{'locked'}) ? $converters['locked']($value->{'locked'}) : null; |
||
80 | $return['name'] = isset($value->{'name'}) ? $converters['name']($value->{'name'}) : null; |
||
81 | $return['region'] = isset($value->{'region'}) ? $converters['region']($value->{'region'}) : null; |
||
82 | $return['longitude'] = isset($value->{'longitude'}) ? $converters['longitude']($value->{'longitude'}) : null; |
||
83 | $return['planet'] = isset($value->{'planet'}) ? $converters['planet']($value->{'planet'}) : null; |
||
84 | $return['updateInfrastructure'] = isset($value->{'updateInfrastructure'}) ? $converters['updateInfrastructure']($value->{'updateInfrastructure'}) : null; |
||
85 | $return['updateReinforce'] = isset($value->{'updateReinforce'}) ? $converters['updateReinforce']($value->{'updateReinforce'}) : null; |
||
86 | return $return; |
||
87 | }; |
||
88 | |||
89 | foreach ($items as $key => $value) { |
||
90 | $this->items[$key] = $func($value); |
||
91 | } |
||
92 | } |
||
93 | |||
113 |