Conditions | 10 |
Paths | 2 |
Total Lines | 37 |
Code Lines | 25 |
Lines | 0 |
Ratio | 0 % |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
27 | public function setItems($items) |
||
28 | { |
||
29 | // by Warringer\Types\Base |
||
30 | $converters = []; |
||
31 | $converters['queue'] = function ($value) { return $value; }; |
||
32 | $converters['help'] = function ($value) { return $value; }; |
||
33 | $converters['description'] = function ($value) { return $value; }; |
||
34 | $converters['regions'] = function ($values) { |
||
35 | // by Warringer\Types\Reference |
||
36 | $func = function ($value) { return new Reference($value); }; |
||
37 | |||
38 | foreach ($values as $key => $value) { |
||
39 | $values[$key] = $func($value); |
||
40 | } |
||
41 | return $values; |
||
42 | }; |
||
43 | |||
44 | $converters['key'] = function ($value) { return $value; }; |
||
45 | $converters['icon'] = function ($value) { return new Reference($value); }; |
||
46 | $converters['name'] = function ($value) { return $value; }; |
||
47 | |||
48 | $func = function ($value) use($converters) { |
||
49 | $return = new \ArrayObject($value, \ArrayObject::ARRAY_AS_PROPS); |
||
50 | $return['queue'] = isset($value->{'queue'}) ? $converters['queue']($value->{'queue'}) : null; |
||
51 | $return['help'] = isset($value->{'help'}) ? $converters['help']($value->{'help'}) : null; |
||
52 | $return['description'] = isset($value->{'description'}) ? $converters['description']($value->{'description'}) : null; |
||
53 | $return['regions'] = isset($value->{'regions'}) ? $converters['regions']($value->{'regions'}) : null; |
||
54 | $return['key'] = isset($value->{'key'}) ? $converters['key']($value->{'key'}) : null; |
||
55 | $return['icon'] = isset($value->{'icon'}) ? $converters['icon']($value->{'icon'}) : null; |
||
56 | $return['name'] = isset($value->{'name'}) ? $converters['name']($value->{'name'}) : null; |
||
57 | return $return; |
||
58 | }; |
||
59 | |||
60 | foreach ($items as $key => $value) { |
||
61 | $this->items[$key] = $func($value); |
||
62 | } |
||
63 | } |
||
64 | |||
84 |