DefaultEmailChangeStrategy::run() - Code Metrics - Inspection of "Close #15 added two factor authentication" - 2amigos/yii2-usuario - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5ee4c9...308b6a )

by Antonio

created 2017-09-21 15:48 UTC

DefaultEmailChangeStrategy::run() A

↳ Parent: DefaultEmailChangeStrategy

Complexity

Conditions	2
Paths	2

Size

Total Lines	18
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	18
ccs	0
cts	13
cp	0
rs	9.4285
cc	2
eloc	10
nc	2
nop	0
crap	6

<?php

/*
 * This file is part of the 2amigos/yii2-usuario project.
 *
 * (c) 2amigOS! <http://2amigos.us/>
 *
 * For the full copyright and license information, please view
 * the LICENSE file that was distributed with this source code.
 */

namespace Da\User\Strategy;

use Da\User\Contracts\MailChangeStrategyInterface;
use Da\User\Factory\MailFactory;
use Da\User\Factory\TokenFactory;
use Da\User\Form\SettingsForm;
use Da\User\Traits\ContainerAwareTrait;
use Yii;

class DefaultEmailChangeStrategy implements MailChangeStrategyInterface
{
    use ContainerAwareTrait;

    protected $form;

    public function __construct(SettingsForm $form)
    {
        $this->form = $form;
    }

    public function run()
    {
        $this->form->getUser()->unconfirmed_email = $this->form->email;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}

        $token = TokenFactory::makeConfirmNewMailToken($this->form->getUser()->id);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}

        $mailService = MailFactory::makeReconfirmationMailerService($this->form->getUser(), $token);


        if ($mailService->run()) {
            Yii::$app
                ->session
                ->setFlash('info', Yii::t('usuario', 'A confirmation message has been sent to your new email address'));

            return $this->form->getUser()->save();
        }

        return false;
    }
}


Push — master ( 5ee4c9...308b6a )

DefaultEmailChangeStrategy::run() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

1			<?php
2
3			/*
4			* This file is part of the 2amigos/yii2-usuario project.
5			*
6			* (c) 2amigOS! <http://2amigos.us/>
7			*
8			* For the full copyright and license information, please view
9			* the LICENSE file that was distributed with this source code.
10			*/
11
12			namespace Da\User\Strategy;
13
14			use Da\User\Contracts\MailChangeStrategyInterface;
15			use Da\User\Factory\MailFactory;
16			use Da\User\Factory\TokenFactory;
17			use Da\User\Form\SettingsForm;
18			use Da\User\Traits\ContainerAwareTrait;
19			use Yii;
20
21			class DefaultEmailChangeStrategy implements MailChangeStrategyInterface
22			{
23			use ContainerAwareTrait;
24
25			protected $form;
26
27			public function __construct(SettingsForm $form)
28			{
29			$this->form = $form;
30			}
31
32			public function run()
33			{
34			$this->form->getUser()->unconfirmed_email = $this->form->email;
			0 ignored issues – show Bug introduced 2016-12-20 20:43 UTC by Report Bug Copy Issue Report Accessing `unconfirmed_email` on the interface `yii\web\IdentityInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
35
36			$token = TokenFactory::makeConfirmNewMailToken($this->form->getUser()->id);
			0 ignored issues – show Bug introduced 2016-12-20 20:43 UTC by Report Bug Copy Issue Report Accessing `id` on the interface `yii\web\IdentityInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
37
38			$mailService = MailFactory::makeReconfirmationMailerService($this->form->getUser(), $token);
			0 ignored issues – show Compatibility introduced 2016-12-20 20:43 UTC by Report Bug Copy Issue Report `$this->form->getUser()` of type `object<yii\web\IdentityInterface>` is not a sub-type of `object<Da\User\Model\User>`. It seems like you assume a concrete implementation of the interface `yii\web\IdentityInterface` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
39
40			if ($mailService->run()) {
41			Yii::$app
42			->session
43			->setFlash('info', Yii::t('usuario', 'A confirmation message has been sent to your new email address'));
44
45			return $this->form->getUser()->save();
46			}
47
48			return false;
49			}
50			}
51

2amigos / yii2-usuario

Push — master ( 5ee4c9...308b6a )

DefaultEmailChangeStrategy::run() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like