RuleSearch::rules() - Code Metrics - 2amigos/yii2-usuario - Measure and Improve Code Quality continuously with Scrutinizer

RuleSearch::rules() A
last analyzed 2021-05-22 12:13 UTC

↳ Parent: RuleSearch

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	6
ccs	0
cts	6
cp	0
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0
crap	2

<?php

/*
 * This file is part of the 2amigos/yii2-usuario project.
 *
 * (c) 2amigOS! <http://2amigos.us/>
 *
 * For the full copyright and license information, please view
 * the LICENSE file that was distributed with this source code.
 */

namespace Da\User\Search;

use Da\User\Model\Rule;
use Da\User\Traits\ContainerAwareTrait;
use yii\base\InvalidConfigException;
use yii\base\InvalidParamException;
use yii\base\Model;
use yii\data\ActiveDataProvider;
use yii\db\Query;

class RuleSearch extends Rule
{
    use ContainerAwareTrait;

    /**
     * @var string
     */
    public $created_at;

    /**
     * @inheritdoc
     */
    public function scenarios()
    {
        return Model::scenarios();
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * @inheritdoc
     */
    public function rules()
    {
        return [
            ['name', 'string'],
        ];
    }

    /**
     * @param array $params
     *
     * @throws InvalidConfigException
     * @throws InvalidParamException
     * @return ActiveDataProvider
     */
    public function search(array $params = [])
    {
        $query = (new Query())
            ->select(['name', 'data', 'created_at', 'updated_at'])
            ->from($this->getAuthManager()->ruleTable)
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            ->orderBy(['name' => SORT_ASC]);

        if ($this->load($params)) {
            $query->andFilterWhere(['name' => $this->name]);
        }

        if (!$this->validate()) {
            $query->where('0=1');
        }

        return $this->make(
            ActiveDataProvider::class,
            [],
            [
                'query' => $query,
                'db' => $this->getAuthManager()->db,
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
                'sort' => [
                    'attributes' => ['name', 'created_at', 'updated_at']
                ]
            ]
        );
    }
}


1			<?php
2
3			/*
4			* This file is part of the 2amigos/yii2-usuario project.
5			*
6			* (c) 2amigOS! <http://2amigos.us/>
7			*
8			* For the full copyright and license information, please view
9			* the LICENSE file that was distributed with this source code.
10			*/
11
12			namespace Da\User\Search;
13
14			use Da\User\Model\Rule;
15			use Da\User\Traits\ContainerAwareTrait;
16			use yii\base\InvalidConfigException;
17			use yii\base\InvalidParamException;
18			use yii\base\Model;
19			use yii\data\ActiveDataProvider;
20			use yii\db\Query;
21
22			class RuleSearch extends Rule
23			{
24			use ContainerAwareTrait;
25
26			/**
27			* @var string
28			*/
29			public $created_at;
30
31			/**
32			* @inheritdoc
33			*/
34			public function scenarios()
35			{
36			return Model::scenarios();
			0 ignored issues – show Bug Best Practice introduced 2017-07-31 12:27 UTC by Report Bug Copy Issue Report The return type of `return \yii\base\Model::scenarios();` (`array<string,array>`) is incompatible with the return type of the parent method `Da\User\Model\Rule::scenarios` of type `array<string,string[]>`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
37			}
38
39			/**
40			* @inheritdoc
41			*/
42			public function rules()
43			{
44			return [
45			['name', 'string'],
46			];
47			}
48
49			/**
50			* @param array $params
51			*
52			* @throws InvalidConfigException
53			* @throws InvalidParamException
54			* @return ActiveDataProvider
55			*/
56			public function search(array $params = [])
57			{
58			$query = (new Query())
59			->select(['name', 'data', 'created_at', 'updated_at'])
60			->from($this->getAuthManager()->ruleTable)
			0 ignored issues – show Bug introduced 2017-07-16 00:30 UTC by Report Bug Copy Issue Report Accessing `ruleTable` on the interface `yii\rbac\ManagerInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
61			->orderBy(['name' => SORT_ASC]);
62
63			if ($this->load($params)) {
64			$query->andFilterWhere(['name' => $this->name]);
65			}
66
67			if (!$this->validate()) {
68			$query->where('0=1');
69			}
70
71			return $this->make(
72			ActiveDataProvider::class,
73			[],
74			[
75			'query' => $query,
76			'db' => $this->getAuthManager()->db,
			0 ignored issues – show Bug introduced 2017-07-16 00:30 UTC by Report Bug Copy Issue Report Accessing `db` on the interface `yii\rbac\ManagerInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
77			'sort' => [
78			'attributes' => ['name', 'created_at', 'updated_at']
79			]
80			]
81			);
82			}
83			}
84

2amigos / yii2-usuario

RuleSearch::rules() A last analyzed 2021-05-22 12:13 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

RuleSearch::rules() A
last analyzed 2021-05-22 12:13 UTC