AbstractAuthItemSearch::search() - Code Metrics - 2amigos/yii2-usuario - Measure and Improve Code Quality continuously with Scrutinizer

AbstractAuthItemSearch::search() A
last analyzed 2021-05-22 12:13 UTC

↳ Parent: AbstractAuthItemSearch

Complexity

Conditions	3
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

Metric	Value
dl	0
loc	21
ccs	0
cts	16
cp	0
rs	9.584
c	0
b	0
f	0
cc	3
nc	2
nop	1
crap	12

<?php

/*
 * This file is part of the 2amigos/yii2-usuario project.
 *
 * (c) 2amigOS! <http://2amigos.us/>
 *
 * For the full copyright and license information, please view
 * the LICENSE file that was distributed with this source code.
 */

namespace Da\User\Search;

use Da\User\Traits\AuthManagerAwareTrait;
use Da\User\Traits\ContainerAwareTrait;
use yii\base\Model;
use yii\data\ArrayDataProvider;
use yii\db\Query;

abstract class AbstractAuthItemSearch extends Model
{
    use AuthManagerAwareTrait;
    use ContainerAwareTrait;

    /**
     * @var string
     */
    public $name;
    /**
     * @var string
     */
    public $description;
    /**
     * @var string
     */
    public $rule_name;

    /**
     * @return int
     */
    abstract public function getType();

    /**
     * @return array
     */
    public function scenarios()
    {
        return [
            'default' => ['name', 'description', 'rule_name'],
        ];
    }

    public function search($params = [])
    {
        /** @var ArrayDataProvider $dataProvider */
        $dataProvider = $this->make(ArrayDataProvider::class);

        $query = (new Query())
            ->select(['name', 'description', 'rule_name'])
            ->andWhere(['type' => $this->getType()])
            ->from($this->getAuthManager()->itemTable);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}

        if ($this->load($params) && $this->validate()) {
            $query
                ->andFilterWhere(['like', 'name', $this->name])
                ->andFilterWhere(['like', 'description', $this->description])
                ->andFilterWhere(['like', 'rule_name', $this->rule_name]);
        }

        $dataProvider->allModels = $query->all($this->getAuthManager()->db);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}

        return $dataProvider;
    }
}


1			<?php
2
3			/*
4			* This file is part of the 2amigos/yii2-usuario project.
5			*
6			* (c) 2amigOS! <http://2amigos.us/>
7			*
8			* For the full copyright and license information, please view
9			* the LICENSE file that was distributed with this source code.
10			*/
11
12			namespace Da\User\Search;
13
14			use Da\User\Traits\AuthManagerAwareTrait;
15			use Da\User\Traits\ContainerAwareTrait;
16			use yii\base\Model;
17			use yii\data\ArrayDataProvider;
18			use yii\db\Query;
19
20			abstract class AbstractAuthItemSearch extends Model
21			{
22			use AuthManagerAwareTrait;
23			use ContainerAwareTrait;
24
25			/**
26			* @var string
27			*/
28			public $name;
29			/**
30			* @var string
31			*/
32			public $description;
33			/**
34			* @var string
35			*/
36			public $rule_name;
37
38			/**
39			* @return int
40			*/
41			abstract public function getType();
42
43			/**
44			* @return array
45			*/
46			public function scenarios()
47			{
48			return [
49			'default' => ['name', 'description', 'rule_name'],
50			];
51			}
52
53			public function search($params = [])
54			{
55			/** @var ArrayDataProvider $dataProvider */
56			$dataProvider = $this->make(ArrayDataProvider::class);
57
58			$query = (new Query())
59			->select(['name', 'description', 'rule_name'])
60			->andWhere(['type' => $this->getType()])
61			->from($this->getAuthManager()->itemTable);
			0 ignored issues – show Bug introduced 2016-12-20 20:43 UTC by Report Bug Copy Issue Report Accessing `itemTable` on the interface `yii\rbac\ManagerInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
62
63			if ($this->load($params) && $this->validate()) {
64			$query
65			->andFilterWhere(['like', 'name', $this->name])
66			->andFilterWhere(['like', 'description', $this->description])
67			->andFilterWhere(['like', 'rule_name', $this->rule_name]);
68			}
69
70			$dataProvider->allModels = $query->all($this->getAuthManager()->db);
			0 ignored issues – show Bug introduced 2016-12-20 20:43 UTC by Report Bug Copy Issue Report Accessing `db` on the interface `yii\rbac\ManagerInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
71
72			return $dataProvider;
73			}
74			}
75

2amigos / yii2-usuario

AbstractAuthItemSearch::search() A last analyzed 2021-05-22 12:13 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

AbstractAuthItemSearch::search() A
last analyzed 2021-05-22 12:13 UTC