Conditions | 5 |
Paths | 5 |
Total Lines | 25 |
Code Lines | 19 |
Lines | 0 |
Ratio | 0 % |
Tests | 0 |
CRAP Score | 30 |
Changes | 0 |
1 | <?php |
||
25 | public static function create($writerType) |
||
26 | { |
||
27 | $writer = null; |
||
|
|||
28 | |||
29 | switch ($writerType) { |
||
30 | case TypeHelper::TXT: |
||
31 | $writer = new TextWriter(); |
||
32 | break; |
||
33 | case TypeHelper::JSON: |
||
34 | $writer = new JsonWriter(); |
||
35 | break; |
||
36 | case TypeHelper::XML: |
||
37 | $writer = new XmlWriter(); |
||
38 | break; |
||
39 | case TypeHelper::HTML: |
||
40 | $writer = new HtmlWriter(); |
||
41 | break; |
||
42 | default: |
||
43 | return parent::create($writerType); |
||
44 | } |
||
45 | |||
46 | $writer->setGlobalFunctionsHelper(new GlobalFunctionsHelper()); |
||
47 | |||
48 | return $writer; |
||
49 | } |
||
50 | } |
||
51 |
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
Both the
$myVar
assignment in line 1 and the$higher
assignment in line 2 are dead. The first because$myVar
is never used and the second because$higher
is always overwritten for every possible time line.