Da\QrCode\Writer\SvgWriter

Complexity

Total Complexity

6

Size/Duplication

Total Lines	77
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

0%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	getContentType()	0	4	1
A	__construct()	0	4	1
A	writeString()	0	21	1
B	addMargin()	0	27	3

<?php

/*
 * This file is part of the 2amigos/yii2-qrcode-component project.
 *
 * (c) 2amigOS! <http://2amigos.us/>
 *
 * For the full copyright and license information, please view
 * the LICENSE file that was distributed with this source code.
 */

namespace Da\QrCode\Writer;

use BaconQrCode\Renderer\Image\Svg;
use BaconQrCode\Writer;
use Da\QrCode\Contracts\QrCodeInterface;
use SimpleXMLElement;

class SvgWriter extends AbstractWriter
{
    /**
     * SvgWriter constructor.
     */
    public function __construct()
    {
        parent::__construct(new Svg());
    }

    /**
     * @inheritdoc
     */
    public function writeString(QrCodeInterface $qrCode)
    {
        /** @var Svg $renderer */
        $renderer = $this->renderer;
        $renderer->setWidth($qrCode->getSize());
        $renderer->setHeight($qrCode->getSize());
        $renderer->setMargin(0);
        $renderer->setForegroundColor($this->convertColor($qrCode->getForegroundColor()));
        $renderer->setBackgroundColor($this->convertColor($qrCode->getBackgroundColor()));
        $writer = new Writer($renderer);

        $string = $writer->writeString(
            $qrCode->getText(),
            $qrCode->getEncoding(),
            $this->convertErrorCorrectionLevel($qrCode->getErrorCorrectionLevel())
        );

        $string = $this->addMargin($string, $qrCode->getMargin(), $qrCode->getSize());

The expression $this->addMargin($string, $qrCode->getMargin(), $qrCode->getSize()); of type string|false adds false to the return on line 51 which is incompatible with the return type declared by the interface Da\QrCode\Contracts\WriterInterface::writeString of type string. It seems like you forgot to handle an error condition.

        return $string;
    }

    /**
     * @return string
     */
    public function getContentType()
    {
        return 'image/svg+xml';
    }

    /**
     * @param  string $string
     * @param  int    $margin
     * @param  int    $size
     * @return string
     */
    protected function addMargin($string, $margin, $size)
    {
        $targetSize = $size + $margin * 2;
        $xml = new SimpleXMLElement($string);

        $xml['width'] = $targetSize;
        $xml['height'] = $targetSize;
        $xml['viewBox'] = '0 0 '.$targetSize.' '.$targetSize;
        $xml->rect['width'] = $targetSize;
        $xml->rect['height'] = $targetSize;
        $additionalWhitespace = $targetSize;

        foreach ($xml->use as $block) {
            $additionalWhitespace = min($additionalWhitespace, (int) $block['x']);
        }
        $sourceBlockSize = (int) $xml->defs->rect['width'];
        $blockCount = ($size - 2 * $additionalWhitespace) / $sourceBlockSize;
        $targetBlockSize = $size / $blockCount;
        $xml->defs->rect['width'] = $targetBlockSize;
        $xml->defs->rect['height'] = $targetBlockSize;

        foreach ($xml->use as $block) {
            $block['x'] = $margin + $targetBlockSize * ($block['x'] - $additionalWhitespace) / $sourceBlockSize;
            $block['y'] = $margin + $targetBlockSize * ($block['y'] - $additionalWhitespace) / $sourceBlockSize;
        }
        return $xml->asXML();
    }
}