Da\tests\Queue\Database\PdoQueueStoreAdapterTest

Complexity

Total Complexity

4

Size/Duplication

Total Lines	69
Duplicated Lines	36.23 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	6	1
B	testEnqueueDequeueAndAcknowledge()	25	25	1
A	testAcknowledgementToUpdateMailJobs()	0	19	1
A	testBadMethodCallExceptionOnAck()	0	5	1

<?php
namespace Da\tests\Queue\Database;

use Da\Mailer\Model\MailMessage;
use Da\Mailer\Test\Fixture\FixtureHelper;
use Da\Mailer\Queue\Backend\Pdo\PdoQueueStoreAdapter;
use Da\Mailer\Test\AbstractMySqlDatabaseTestCase;

class PdoQueueStoreAdapterTest extends AbstractMySqlDatabaseTestCase
{
    /**
     * @var PdoQueueStoreAdapter
     */
    private $pdoQueueStore;

    protected function setUp()
    {
        parent::setUp();

        $this->pdoQueueStore = new PdoQueueStoreAdapter(self::getPdoQueueStoreConnection());
    }

    public function testEnqueueDequeueAndAcknowledge()

This method seems to be duplicated in your project.

    {
        $mailJob = FixtureHelper::getMailJob();

        $this->assertSame($this->pdoQueueStore, $this->pdoQueueStore->init());

        $this->assertTrue($this->pdoQueueStore->enqueue($mailJob));

        $this->assertTrue($this->pdoQueueStore->isEmpty() === false);

        $mailJob = $this->pdoQueueStore->dequeue();

        $this->assertTrue($this->pdoQueueStore->isEmpty() === true); // message set to 'A' on process

        $this->assertTrue(!empty($mailJob->getMessage()));

        $dequeuedMailMessage = MailMessage::fromArray(json_decode($mailJob->getMessage(), true));

        $this->assertEquals(FixtureHelper::getMailMessage(), $dequeuedMailMessage);

        $mailJob->markAsCompleted();
        $this->pdoQueueStore->ack($mailJob);

It seems like $mailJob defined by $this->pdoQueueStore->dequeue() on line 33 can be null; however, Da\Mailer\Queue\Backend\Pdo\PdoQueueStoreAdapter::ack() does not accept null, maybe add an additional type check?

        $this->assertTrue($this->pdoQueueStore->dequeue() === null);
    }

    public function testAcknowledgementToUpdateMailJobs()
    {
        $mailJob = FixtureHelper::getMailJob();

        $this->pdoQueueStore->enqueue($mailJob);
        $this->assertTrue($this->pdoQueueStore->isEmpty() === false);
        $dequedMailJob = $this->pdoQueueStore->dequeue();
        $this->assertTrue($this->pdoQueueStore->isEmpty() === true);
        // enqueue it back to be able to get it
        // we could actually set the time to be processed in the future :)
        // lets simply update the increment
        $dequedMailJob->incrementAttempt();
        $dequedMailJob->setTimeToSend(date('Y-m-d H:i:s', time() + 1));
        $this->assertEquals(1, $dequedMailJob->getAttempt());
        $dequedMailJob->markAsNew();
        $this->pdoQueueStore->ack($dequedMailJob);

It seems like $dequedMailJob defined by $this->pdoQueueStore->dequeue() on line 55 can be null; however, Da\Mailer\Queue\Backend\Pdo\PdoQueueStoreAdapter::ack() does not accept null, maybe add an additional type check?

        sleep(1);
        $this->assertTrue($this->pdoQueueStore->isEmpty() === false);
    }

    /**
     * @expectedException \BadMethodCallException
     */
    public function testBadMethodCallExceptionOnAck()
    {
        $mailJob = FixtureHelper::getMailJob();
        $this->pdoQueueStore->ack($mailJob);
    }
}