MailerBuilder::make() - Code Metrics - 2amigos/mailer-library - Measure and Improve Code Quality continuously with Scrutinizer

MailerBuilder::make() A
last analyzed 2024-01-20 08:57 UTC

↳ Parent: MailerBuilder

Complexity

Conditions	1
Paths	1

Size

Total Lines	9
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	5
c	1
b	0
f	0
nc	1
nop	1
dl	0
loc	9
rs	10

<?php

namespace Da\Mailer\Builder;

use Da\Mailer\Mailer;
use Da\Mailer\Transport\TransportFactory;
use Exception;

class MailerBuilder extends Buildable
{
    /**
     * @param string|null $broker
     * @return Mailer
     * @throws Exception
     */
    public static function make($broker = null)
    {
        $config = self::getConfig();

        $transportType = $broker ?? $config['config']['transport'];
        $connectionValues = $config['transports'][$transportType];
        $transport = TransportFactory::create($connectionValues, $transportType)->create();

        return new Mailer($transport);
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
    }
}


1			<?php
2
3			namespace Da\Mailer\Builder;
4
5			use Da\Mailer\Mailer;
6			use Da\Mailer\Transport\TransportFactory;
7			use Exception;
8
9			class MailerBuilder extends Buildable
10			{
11			/**
12			* @param string\|null $broker
13			* @return Mailer
14			* @throws Exception
15			*/
16			public static function make($broker = null)
17			{
18			$config = self::getConfig();
19
20			$transportType = $broker ?? $config['config']['transport'];
21			$connectionValues = $config['transports'][$transportType];
22			$transport = TransportFactory::create($connectionValues, $transportType)->create();
23
24			return new Mailer($transport);
			0 ignored issues – show Bug Best Practice introduced 2024-01-20 08:33 UTC by Report Bug Copy Issue Report The expression `return new Da\Mailer\Mailer($transport)` returns the type `Da\Mailer\Mailer` which is incompatible with the return type mandated by `Da\Mailer\Builder\Buildable::make()` of `void`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
25			}
26			}
27

2amigos / mailer-library

MailerBuilder::make() A last analyzed 2024-01-20 08:57 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

MailerBuilder::make() A
last analyzed 2024-01-20 08:57 UTC