Da\Mailer\Builder\MailJobBuilder::make()

Complexity

Conditions	6
Paths	6

Size

Total Lines	18
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public static function make($jobAttributes = null, ?string $broker = null): MailJob
    {
        $config = self::getConfig();
        $messageBroker = $broker ?? $config['config']['message_broker'];

        switch ($messageBroker) {
            case MessageBrokerEnum::BROKER_REDIS:
                return new RedisMailJob($jobAttributes);

It seems like $jobAttributes can also be of type null; however, parameter $config of Da\Mailer\Queue\Backend\Redis\RedisMailJob::__construct() does only seem to accept array, maybe add an additional type check?

The expression return new Da\Mailer\Queue\Backend\Redis\RedisMailJob($jobAttributes) returns the type Da\Mailer\Queue\Backend\Redis\RedisMailJob which is incompatible with the return type mandated by Da\Mailer\Builder\Buildable::make() of void.

            case MessageBrokerEnum::BROKER_SQS:
                return new SqsMailJob($jobAttributes);

The expression return new Da\Mailer\Queue\Backend\Sqs\SqsMailJob($jobAttributes) returns the type Da\Mailer\Queue\Backend\Sqs\SqsMailJob which is incompatible with the return type mandated by Da\Mailer\Builder\Buildable::make() of void.

It seems like $jobAttributes can also be of type null; however, parameter $config of Da\Mailer\Queue\Backend\Sqs\SqsMailJob::__construct() does only seem to accept array, maybe add an additional type check?

            case MessageBrokerEnum::BROKER_BEANSTALKD:
                return new BeanstalkdMailJob($jobAttributes);

The expression return new Da\Mailer\Queue\Backend\Beanstalkd\BeanstalkdMailJob($jobAttributes) returns the type Da\Mailer\Queue\Backend\Beanstalkd\BeanstalkdMailJob which is incompatible with the return type mandated by Da\Mailer\Builder\Buildable::make() of void.

It seems like $jobAttributes can also be of type null; however, parameter $config of Da\Mailer\Queue\Backend\Beanstalkd\BeanstalkdMailJob::__construct() does only seem to accept array, maybe add an additional type check?

            case MessageBrokerEnum::BROKER_PDO:
                return new PdoMailJob($jobAttributes);

The expression return new Da\Mailer\Queue\Backend\Pdo\PdoMailJob($jobAttributes) returns the type Da\Mailer\Queue\Backend\Pdo\PdoMailJob which is incompatible with the return type mandated by Da\Mailer\Builder\Buildable::make() of void.

It seems like $jobAttributes can also be of type null; however, parameter $config of Da\Mailer\Queue\Backend\Pdo\PdoMailJob::__construct() does only seem to accept array, maybe add an additional type check?

            case MessageBrokerEnum::BROKER_RABBITMQ:
                return new RabbitMqJob($jobAttributes);

It seems like $jobAttributes can also be of type null; however, parameter $config of Da\Mailer\Queue\Backend\RabbitMq\RabbitMqJob::__construct() does only seem to accept array, maybe add an additional type check?

The expression return new Da\Mailer\Queue\Backend\RabbitMq\RabbitMqJob($jobAttributes) returns the type Da\Mailer\Queue\Backend\RabbitMq\RabbitMqJob which is incompatible with the return type mandated by Da\Mailer\Builder\Buildable::make() of void.

            default:
                throw new UndefinedMessageBrokerException();
        }