LocalizerController::setLocale() - Code Metrics - Inspection of "Docs" - 24aitor/Localizer - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6ff9ea...81d6fd )

by Aitor Riba

created 2017-04-15 17:52 UTC

LocalizerController::setLocale() A

↳ Parent: LocalizerController

Complexity

Conditions	3
Paths	4

Size

Total Lines	13
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	13
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	9
nc	4
nop	2

<?php

namespace Aitor24\Localizer\Controllers;

use Aitor24\Localizer\Facades\LocalizerFacade as Localizer;
use App\Http\Controllers\Controller;
use Illuminate\Http\Request;
use Illuminate\Support\Facades\Auth;

class LocalizerController extends Controller
{
    /**
	 *
     * Set locale if it's allowed.
     *
     * @param string $locale
     * @param \Illuminate\Http\Request $request
	 *
     **/
    private function setLocale($locale, $request)
    {
        if (!in_array($locale, array_keys(Localizer::allowedLanguages()))) {
            abort(404, "Lang '".$locale."' not found");
        }
        if (Auth::check()) {
            $user = Auth::User();
            $user->locale = $locale;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            $user->save();
        } else {
            $request->session()->put('locale', $locale);

        }
    }

    /**
	 *
     * Set locale and return home url.
     *
     * @param string $locale
     * @param \Illuminate\Http\Request $request
	 *
     **/
    public function setHome($locale, Request $request)
    {
        $this->setLocale($locale, $request);

        return redirect(url('/'));

    }

    /**
	 *
     * Set locale and return back.
     *
     * @param string $locale
     * @param \Illuminate\Http\Request $request
	 *
     **/
    public function set($locale, Request $request)
    {
        $this->setLocale($locale, $request);

        return redirect()->back();
    }
}


1			<?php
2
3			namespace Aitor24\Localizer\Controllers;
4
5			use Aitor24\Localizer\Facades\LocalizerFacade as Localizer;
6			use App\Http\Controllers\Controller;
7			use Illuminate\Http\Request;
8			use Illuminate\Support\Facades\Auth;
9
10			class LocalizerController extends Controller
11			{
12			/**
13			*
14			* Set locale if it's allowed.
15			*
16			* @param string $locale
17			* @param \Illuminate\Http\Request $request
18			*
19			**/
20			private function setLocale($locale, $request)
21			{
22			if (!in_array($locale, array_keys(Localizer::allowedLanguages()))) {
23			abort(404, "Lang '".$locale."' not found");
24			}
25			if (Auth::check()) {
26			$user = Auth::User();
27			$user->locale = $locale;
			0 ignored issues – show Bug introduced 2017-04-15 17:48 UTC by Report Bug Copy Issue Report Accessing `locale` on the interface `Illuminate\Contracts\Auth\Authenticatable` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
28			$user->save();
29			} else {
30			$request->session()->put('locale', $locale);
			0 ignored issues – show Bug introduced 2017-04-15 17:54 UTC by Report Bug Copy Issue Report The method `put()` does not seem to exist on `object<Symfony\Component...ssion\SessionInterface>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
31			}
32			}
33
34			/**
35			*
36			* Set locale and return home url.
37			*
38			* @param string $locale
39			* @param \Illuminate\Http\Request $request
40			*
41			**/
42			public function setHome($locale, Request $request)
43			{
44			$this->setLocale($locale, $request);
45
46			return redirect(url('/'));
			0 ignored issues – show Bug introduced 2017-04-15 17:54 UTC by Report Bug Copy Issue Report It seems like `url('/')` targeting `url()` can also be of type `object<Illuminate\Contracts\Routing\UrlGenerator>`; however, `redirect()` does only seem to accept `string\|null`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
47			}
48
49			/**
50			*
51			* Set locale and return back.
52			*
53			* @param string $locale
54			* @param \Illuminate\Http\Request $request
55			*
56			**/
57			public function set($locale, Request $request)
58			{
59			$this->setLocale($locale, $request);
60
61			return redirect()->back();
62			}
63			}
64

24aitor / Localizer

Push — master ( 6ff9ea...81d6fd )

LocalizerController::setLocale() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like