Aitor24\Localizer\Controllers\LocalizerController

Complexity

Total Complexity

6

Size/Duplication

Total Lines	50
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes	1
Bugs	1	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	setLocale()	0	15	4
A	setHome()	0	6	1
A	set()	0	6	1

<?php

namespace Aitor24\Localizer\Controllers;

use Aitor24\Localizer\Facades\LocalizerFacade as Localizer;
use App\Http\Controllers\Controller;
use Illuminate\Http\Request;
use Illuminate\Support\Facades\Auth;

class LocalizerController extends Controller
{
    /**
     * Set locale if it's allowed.
     *
     * @param string                   $locale
     * @param \Illuminate\Http\Request $request
     **/
    private function setLocale($locale, $request)
    {
        $allowedLangs = array_keys(Localizer::allowedLanguages());
        if (config('localizer.block_unallowed_langs') && !in_array($locale, $allowedLangs)) {
            abort(404, 'Unallowed language');
        }

        if (Auth::check()) {
            $user = Auth::User();
            $user->locale = $locale;

Accessing locale on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

            $user->save();
        } else {
            $request->session()->put('locale', $locale);

The method put() does not seem to exist on object<Symfony\Component\HttpFoundation\Session\SessionInterface>.

        }
    }

    /**
     * Set locale and return home url.
     *
     * @param string                   $locale
     * @param \Illuminate\Http\Request $request
     **/
    public function setHome($locale, Request $request)
    {
        $this->setLocale($locale, $request);

        return redirect(url('/'));

It seems like url('/') targeting url() can also be of type object<Illuminate\Contracts\Routing\UrlGenerator>; however, redirect() does only seem to accept string|null, maybe add an additional type check?

    }

    /**
     * Set locale and return back.
     *
     * @param string                   $locale
     * @param \Illuminate\Http\Request $request
     **/
    public function set($locale, Request $request)
    {
        $this->setLocale($locale, $request);

        return redirect()->back();
    }
}