User::__construct() - Code Metrics - Inspection of "Implemented support for user's safe-deletion featu..." - 24Slides/auth-connector - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1)

by Artem

created 2018-10-31 09:05 UTC

User::__construct() A

↳ Parent: User

Complexity

Conditions	2
Paths	2

Size

Total Lines	21
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
cc	2
eloc	9
nc	2
nop	9
dl	0
loc	21
ccs	0
cts	10
cp	0
crap	6
rs	9.9666
c	0
b	0
f	0

How to fix Many Parameters

<?php

namespace Slides\Connector\Auth\Sync;

use Carbon\Carbon;

/**
 * Class User describes a remote user
 *
 * @package Slides\Connector\Auth\Sync
 */
final class User
{
    /**
     * User's remote ID
     *
     * @var int
     */
    protected $remoteId;

    /**
     * User's name
     *
     * @var string
     */
    protected $name;

    /**
     * User's email
     *
     * @var string
     */
    protected $email;

    /**
     * User's country code
     *
     * @var string
     */
    protected $country;

    /**
     * User's encrypted password
     *
     * @var string
     */
    protected $password;

    /**
     * The date of last update.
     *
     * @var Carbon
     */
    protected $updated;

    /**
     * The creation date.
     *
     * @var Carbon
     */
    protected $created;

    /**
     * The deletion date.
     *
     * @var Carbon|null
     */
    protected $deleted;

    /**
     * The instance of the user locally
     *
     * @var \Illuminate\Contracts\Auth\Authenticatable
     */
    protected $localUser;

    /**
     * Whether a user exist only locally
     *
     * @var bool
     */
    protected $isLocal = false;

    /**
     * The action for a remote sync client
     *
     * @var string
     */
    protected $remoteAction;

    /**
     * User constructor.
     *
     * @param int $remoteId
     * @param string|null $name
     * @param string $email
     * @param string|null $password
     * @param string|null $updated
     * @param string $created
     * @param string|null $country
     * @param string|null $deleted
     * @param string $action
     */
    public function __construct(
        int $remoteId,
        ?string $name,
        string $email,
        ?string $password,
        ?string $updated,
        string $created,
        ?string $deleted,
        ?string $country,
        string $action = null
    )
    {
        $this->remoteId = $remoteId;
        $this->name = $name;
        $this->email = $email;
        $this->password = $password;
        $this->updated = new Carbon($updated);
        $this->created = new Carbon($created);
        $this->country = $country;
        $this->deleted = ($deleted ? new Carbon($deleted) : null);
        $this->remoteAction = $action;
    }

    /**
     * Get user's name
     *
     * @return string|null
     */
    public function getName()
    {
        return $this->name;
    }

    /**
     * Get user's email
     *
     * @return string
     */
    public function getEmail(): string
    {
        return $this->email;
    }

    /**
     * Get user's password
     *
     * @return string|null
     */
    public function getPassword()
    {
        return $this->password;
    }

    /**
     * Get a creation date.
     *
     * @return Carbon
     */
    public function getCreated(): Carbon
    {
        return $this->created;
    }

    /**
     * Get updated_at date
     *
     * @return Carbon|null
     */
    public function getUpdated()
    {
        return $this->updated;
    }

    /**
     * Get remote action
     *
     * @return string|null
     */
    public function getRemoteAction(): ?string
    {
        return $this->remoteAction;
    }

    /**
     * Get remote user ID
     *
     * @return int
     */
    public function getRemoteId(): int
    {
        return $this->remoteId;
    }

    /**
     * Get user's country
     *
     * @return string|null
     */
    public function getCountry()
    {
        return $this->country;
    }

    /**
     * Reset the password.
     *
     * @return void
     */
    public function resetPassword()
    {
        $this->password = null;
    }

    /**
     * Create a user from the response
     *
     * @param array $response
     *
     * @return static
     */
    public static function createFromResponse(array $response)
    {
        $user = array_get($response, 'user');

        return new static(
            array_get($user, 'id'),
            /** @scrutinizer ignore-type */ array_get($user, 'id'),
            array_get($user, 'name'),
            array_get($user, 'email'),
            /** @scrutinizer ignore-type */ array_get($user, 'email'),
            array_get($user, 'password'),
            array_get($user, 'updated_at'),
            array_get($user, 'created_at'),
            /** @scrutinizer ignore-type */ array_get($user, 'created_at'),
            array_get($user, 'deleted_at'),
            array_get($user, 'country'),
            array_get($user, 'action')
        );
    }

    /**
     * Get a deletion date.
     *
     * @return Carbon|null
     */
    public function getDeleted(): ?Carbon
    {
        return $this->deleted;
    }
}

24Slides / auth-connector

Pull Request — master (#1)

User::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Many Parameters

Many Parameters

Duplication Side-by-Side

Filter issues like