Slides\Connector\Auth\Concerns\ResetsPasswords

Complexity

Total Complexity

5

Size/Duplication

Total Lines	48
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	reset()	0	16	3
A	showResetForm()	0	8	2

<?php

namespace Slides\Connector\Auth\Concerns;

use Illuminate\Http\Request;
use Slides\Connector\Auth\Facades\AuthService;
use Illuminate\Auth\Passwords\PasswordBroker;
use Illuminate\Foundation\Auth\ResetsPasswords as BaseResetsPassword;

/**
 * Trait SendsPasswordResetEmails
 *
 * @package Slides\Connector\Auth\Concerns
 */
trait ResetsPasswords
{
    use BaseResetsPassword;

    /**
     * Display the password reset view for the given token.
     *
     * If no token is present, display the link request form.
     *
     * @param string $token
     * @param string $email
     *
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function showResetForm(string $token, string $email)
    {
        if(!$email = AuthService::validatePasswordResetToken($token, $email)) {

The method validatePasswordResetToken() does not exist on Slides\Connector\Auth\Facades\AuthService. Since you implemented __callStatic, consider adding a @method annotation.

            throw new \Symfony\Component\HttpKernel\Exception\NotFoundHttpException();
        }

        return view('auth.passwords.reset')->with(
            ['token' => $token, 'email' => $email]
        );
    }

    /**
     * Reset user's password
     *
     * @param Request $request
     *
     * @return \Illuminate\Http\RedirectResponse
     */
    public function reset(Request $request)
    {
        $this->validate($request, $this->rules(), $this->validationErrorMessages());

It seems like validate() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        if(AuthService::resetPassword(

The method resetPassword() does not exist on Slides\Connector\Auth\Facades\AuthService. Since you implemented __callStatic, consider adding a @method annotation.

            $request->input('token'),
            $email = $request->input('email'),
            $password = $request->input('password'),
            $request->input('password_confirmation')
        )) {
            if(AuthService::login($email, $password)) {

The method login() does not exist on Slides\Connector\Auth\Facades\AuthService. Since you implemented __callStatic, consider adding a @method annotation.

                return $this->sendResetResponse(PasswordBroker::PASSWORD_RESET);

The call to Slides\Connector\Auth\Concerns\ResetsPasswords::sendResetResponse() has too few arguments starting with response.

Illuminate\Auth\Passwords\PasswordBroker::PASSWORD_RESET of type string is incompatible with the type Illuminate\Http\Request expected by parameter $request of Slides\Connector\Auth\Concerns\ResetsPasswords::sendResetResponse().

            }
        }

        return $this->sendResetFailedResponse($request, PasswordBroker::INVALID_PASSWORD);
    }
}