Issues in LogEntry.class.php (master) - Issues in master - 1n9i9c7om/ClashOfClans-API-PHP - Measure and Improve Code Quality continuously with Scrutinizer

Issues (93)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

ClashAPI/LogEntry.class.php (8 issues)

Labels

Severity

Minor 8

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

class CoC_LogEntry
{
	protected $logEntry;
	
	/**
	 * Constructor of CoC_Warlog
	 * 
	 * @logEntry $logEntry, obtained by Warlog.class.php
	 */
	public function __construct($logEntry)
	{
		$this->logEntry = $logEntry;
	}
	
	protected function getLogEntry()
	{
		return $this->logEntry;
	}
	
	public function getResult()
	{
		return $this->getLogEntry()->result;
	}
	
	public function getEndTime()
	{
		return $this->getLogEntry()->endTime;
	}
	
	public function getTeamSize()
	{
		return $this->getLogEntry()->teamSize();
	}
	
	public function getClanTag()
	{
		return $this->getLogEntry()->clan->tag;
	}
	
	public function getClanName()
	{
		return $this->getLogEntry()->clan->name;
	}
	
	public function getClanBadeUrl($size = "")
	{
		switch ($size)
		{
			case "small":
				return $this->getLogEntry()->clan->badgeUrls->small; 
				break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
			case "medium":
				return $this->getLogEntry()->clan->badgeUrls->medium;
				break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
			case "large":
				return $this->getLogEntry()->clan->badgeUrls->large;
				break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
			default:
				return $this->getLogEntry()->clan->badgeUrls->large; //return the largest because it can be resized using HTML
				break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
		}
	}
	
	public function getClanLevel()
	{
		return $this->getLogEntry()->clan->clanLevel;
	}
	
	public function getClanAttacks()
	{
		return $this->getLogEntry()->clan->attacks;
	}
	
	public function getClanStars()
	{
		return $this->getLogEntry()->clan->stars;
	}
	
	public function getDestructionPercentage()
	{
		return $this->getLogEntry()->clan->destructionPercentage;
	}
	
	public function getExpEarned()
	{
		return $this->getLogEntry()->clan->expEarned;
	}
	
	public function getOpponentTag()
	{
		return $this->getLogEntry()->opponent->tag;
	}
	
	public function getOpponentName()
	{
		return $this->getLogEntry()->opponent->name;
	}
	
	public function getOpponentBadgeUrls($size = "")
	{
		switch ($size)
		{
			case "small":
				return $this->getLogEntry()->opponent->badgeUrls->small; 
				break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
			case "medium":
				return $this->getLogEntry()->opponent->badgeUrls->medium;
				break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
			case "large":
				return $this->getLogEntry()->opponent->badgeUrls->large;
				break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
			default:
				return $this->getLogEntry()->opponent->badgeUrls->large; //return the largest because it can be resized using HTML
				break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
		}
	}
	
	public function getOpponentLevel()
	{
		return $this->getLogEntry()->opponent->clanLevel;
	}
	
	public function getOpponentStars()
	{
		return $this->getLogEntry()->opponent->stars;
	}
	
	public function getOpponentDestructionPercentage()
	{
		return $this->getLogEntry()->opponent->destructionPercentage;
	}
}

1		<?php
2
3		class CoC_LogEntry
4		{
5		protected $logEntry;
6
7		/**
8		* Constructor of CoC_Warlog
9		*
10		* @logEntry $logEntry, obtained by Warlog.class.php
11		*/
12		public function __construct($logEntry)
13		{
14		$this->logEntry = $logEntry;
15		}
16
17		protected function getLogEntry()
18		{
19		return $this->logEntry;
20		}
21
22		public function getResult()
23		{
24		return $this->getLogEntry()->result;
25		}
26
27		public function getEndTime()
28		{
29		return $this->getLogEntry()->endTime;
30		}
31
32		public function getTeamSize()
33		{
34		return $this->getLogEntry()->teamSize();
35		}
36
37		public function getClanTag()
38		{
39		return $this->getLogEntry()->clan->tag;
40		}
41
42		public function getClanName()
43		{
44		return $this->getLogEntry()->clan->name;
45		}
46
47	View Code Duplication	public function getClanBadeUrl($size = "")
48		{
49		switch ($size)
50		{
51		case "small":
52		return $this->getLogEntry()->clan->badgeUrls->small;
53		break;
		0 ignored issues – show Unused Code introduced 2016-08-03 12:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
54		case "medium":
55		return $this->getLogEntry()->clan->badgeUrls->medium;
56		break;
		0 ignored issues – show Unused Code introduced 2016-08-03 12:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
57		case "large":
58		return $this->getLogEntry()->clan->badgeUrls->large;
59		break;
		0 ignored issues – show Unused Code introduced 2016-08-03 12:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
60		default:
61		return $this->getLogEntry()->clan->badgeUrls->large; //return the largest because it can be resized using HTML
62		break;
		0 ignored issues – show Unused Code introduced 2016-08-03 12:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
63		}
64		}
65
66		public function getClanLevel()
67		{
68		return $this->getLogEntry()->clan->clanLevel;
69		}
70
71		public function getClanAttacks()
72		{
73		return $this->getLogEntry()->clan->attacks;
74		}
75
76		public function getClanStars()
77		{
78		return $this->getLogEntry()->clan->stars;
79		}
80
81		public function getDestructionPercentage()
82		{
83		return $this->getLogEntry()->clan->destructionPercentage;
84		}
85
86		public function getExpEarned()
87		{
88		return $this->getLogEntry()->clan->expEarned;
89		}
90
91		public function getOpponentTag()
92		{
93		return $this->getLogEntry()->opponent->tag;
94		}
95
96		public function getOpponentName()
97		{
98		return $this->getLogEntry()->opponent->name;
99		}
100
101	View Code Duplication	public function getOpponentBadgeUrls($size = "")
102		{
103		switch ($size)
104		{
105		case "small":
106		return $this->getLogEntry()->opponent->badgeUrls->small;
107		break;
		0 ignored issues – show Unused Code introduced 2016-08-03 12:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
108		case "medium":
109		return $this->getLogEntry()->opponent->badgeUrls->medium;
110		break;
		0 ignored issues – show Unused Code introduced 2016-08-03 12:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
111		case "large":
112		return $this->getLogEntry()->opponent->badgeUrls->large;
113		break;
		0 ignored issues – show Unused Code introduced 2016-08-03 12:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
114		default:
115		return $this->getLogEntry()->opponent->badgeUrls->large; //return the largest because it can be resized using HTML
116		break;
		0 ignored issues – show Unused Code introduced 2016-08-03 12:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
117		}
118		}
119
120		public function getOpponentLevel()
121		{
122		return $this->getLogEntry()->opponent->clanLevel;
123		}
124
125		public function getOpponentStars()
126		{
127		return $this->getLogEntry()->opponent->stars;
128		}
129
130		public function getOpponentDestructionPercentage()
131		{
132		return $this->getLogEntry()->opponent->destructionPercentage;
133		}
134		}

1n9i9c7om / ClashOfClans-API-PHP

Issues (93)

Security Analysis no request data

ClashAPI/LogEntry.class.php (8 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like