Issues in League.class.php (master) - Issues in master - 1n9i9c7om/ClashOfClans-API-PHP - Measure and Improve Code Quality continuously with Scrutinizer

Issues (93)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

ClashAPI/League.class.php (11 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

class CoC_League
{
	protected $api;
	protected $leagueId;
	protected $league = NULL;
    
	/**
	 * Constructor of CoC_League
	 * 
	 * @param $leagueId
	 */
	public function __construct($league)
	{
		$this->api      = new ClashOfClans();
		if(is_object($league))
		{
			$this->league = $league;
		}
		else
		{
			$this->leagueId = $league;
			$this->getLeague();
		}
	}
    
	/**
	 * Gets an stdClass containing league-information
	 *
	 * @return stdClass, league

	 */
	protected function getLeague()
	{
		if($this->league == NULL)
		{
			foreach ($this->api->getLeagueList()->items as $league) 

			{
				if ($league->id == $this->leagueId) 
				{
					$this->league = $league;
					return $this->league;
				}
			}
			return 0;
		}
		else
		{
			return $this->league;
		}
		
	}
    
	/**
	 * Sets the league by providing it's exact name
	 *
	 * @param string, league name
	 * @return bool, success or fail

	 */
	public function setLeagueByName($name)
	{
		foreach ($this->api->getLeagueList()->items as $league) 

		{
			if ($league->name == $name) 
			{
				$this->leagueId = $league->id;
				$this->league = $league;
				return 1;
			}
		}
		return 0;
	}
    
	/**
	 * Gets the league ID
	 *
	 * @return int
	 */
	 public function getLeagueId()
	 {
		 return $this->getLeague()->id;
	 }
	
	/**
	 * Gets the league name
	 *
	 * @return string, name

	 */
	public function getLeagueName()
	{
		return $this->getLeague()->name;
	}
    
	/**
	 * Sets the league by providing it's exact name
	 *
	 * @param (optional) $size ("tiny", "small", "medium")
	 * @return string, URL to the picture

	 */
	public function getLeagueIcon($size = "") //small, tiny, medium
	{
		$league = $this->getLeague();
		switch ($size) {
			case "small":
				return $league->iconUrls->small;
				break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
			case "medium":
				return $league->iconUrls->medium;
				break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
			case "tiny":
				return $league->iconUrls->tiny;
				break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
			default:
				return $league->iconUrls->small; //medium is not always available, so lets chose small on default
				break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
		}
	}
}

?>


1		<?php
2
3		class CoC_League
4		{
5		protected $api;
6		protected $leagueId;
7		protected $league = NULL;
8
9		/**
10		* Constructor of CoC_League
11		*
12		* @param $leagueId
13		*/
14		public function __construct($league)
15		{
16		$this->api = new ClashOfClans();
17		if(is_object($league))
18		{
19		$this->league = $league;
20		}
21		else
22		{
23		$this->leagueId = $league;
24		$this->getLeague();
25		}
26		}
27
28		/**
29		* Gets an stdClass containing league-information
30		*
31		* @return stdClass, league
		0 ignored issues – show Documentation introduced 2016-02-05 15:21 UTC by Report Bug Copy Issue Report Show Similar Issues like this The doc-type `stdClass,` could not be parsed: Expected "\|" or "end of type", but got "," at position 8. (view supported doc-types) This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types. Loading history...
32		*/
33		protected function getLeague()
34		{
35		if($this->league == NULL)
36		{
37	View Code Duplication	foreach ($this->api->getLeagueList()->items as $league)
		0 ignored issues – show Duplication introduced 2016-02-06 17:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
38		{
39		if ($league->id == $this->leagueId)
40		{
41		$this->league = $league;
42		return $this->league;
43		}
44		}
45		return 0;
46		}
47		else
48		{
49		return $this->league;
50		}
51
52		}
53
54		/**
55		* Sets the league by providing it's exact name
56		*
57		* @param string, league name
58		* @return bool, success or fail
		0 ignored issues – show Documentation introduced 2016-02-05 15:21 UTC by Report Bug Copy Issue Report Show Similar Issues like this The doc-type `bool,` could not be parsed: Expected "\|" or "end of type", but got "," at position 4. (view supported doc-types) This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types. Loading history...
59		*/
60		public function setLeagueByName($name)
61		{
62	View Code Duplication	foreach ($this->api->getLeagueList()->items as $league)
		0 ignored issues – show Duplication introduced 2016-02-06 17:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
63		{
64		if ($league->name == $name)
65		{
66		$this->leagueId = $league->id;
67		$this->league = $league;
68		return 1;
69		}
70		}
71		return 0;
72		}
73
74		/**
75		* Gets the league ID
76		*
77		* @return int
78		*/
79		public function getLeagueId()
80		{
81		return $this->getLeague()->id;
82		}
83
84		/**
85		* Gets the league name
86		*
87		* @return string, name
		0 ignored issues – show Documentation introduced 2016-02-05 15:21 UTC by Report Bug Copy Issue Report Show Similar Issues like this The doc-type `string,` could not be parsed: Expected "\|" or "end of type", but got "," at position 6. (view supported doc-types) This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types. Loading history...
88		*/
89		public function getLeagueName()
90		{
91		return $this->getLeague()->name;
92		}
93
94		/**
95		* Sets the league by providing it's exact name
96		*
97		* @param (optional) $size ("tiny", "small", "medium")
98		* @return string, URL to the picture
		0 ignored issues – show Documentation introduced 2016-02-05 15:21 UTC by Report Bug Copy Issue Report Show Similar Issues like this The doc-type `string,` could not be parsed: Expected "\|" or "end of type", but got "," at position 6. (view supported doc-types) This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types. Loading history...
99		*/
100		public function getLeagueIcon($size = "") //small, tiny, medium
101		{
102		$league = $this->getLeague();
103		switch ($size) {
104		case "small":
105		return $league->iconUrls->small;
106		break;
		0 ignored issues – show Unused Code introduced 2016-02-05 15:21 UTC by Report Bug Copy Issue Report Show Similar Issues like this `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
107		case "medium":
108		return $league->iconUrls->medium;
109		break;
		0 ignored issues – show Unused Code introduced 2016-02-05 15:21 UTC by Report Bug Copy Issue Report Show Similar Issues like this `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
110		case "tiny":
111		return $league->iconUrls->tiny;
112		break;
		0 ignored issues – show Unused Code introduced 2016-02-05 15:21 UTC by Report Bug Copy Issue Report Show Similar Issues like this `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
113		default:
114		return $league->iconUrls->small; //medium is not always available, so lets chose small on default
115		break;
		0 ignored issues – show Unused Code introduced 2016-02-05 15:21 UTC by Report Bug Copy Issue Report Show Similar Issues like this `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
116		}
117		}
118		}
119
120		?>
		0 ignored issues – show Best Practice introduced 2016-02-05 15:21 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is not recommended to use PHP's closing tag `?>` in files other than templates. Using a closing tag in PHP files that only contain PHP code is not recommended as you might accidentally add whitespace after the closing tag which would then be output by PHP. This can cause severe problems, for example headers cannot be sent anymore. A simple precaution is to leave off the closing tag as it is not required, and it also has no negative effects whatsoever. Loading history...

1n9i9c7om / ClashOfClans-API-PHP

Issues (93)

Security Analysis no request data

ClashAPI/League.class.php (11 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like