RequestSerializer::fixTarget() - Code Metrics - Inspection of "scraped response signing and verification because..." - 1ma/Psr7Hmac - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a03880...647009 )

by Marcel

created 2017-04-17 19:31 UTC

RequestSerializer::fixTarget() A

↳ Parent: RequestSerializer

Complexity

Conditions	2
Paths	2

Size

Total Lines	12
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	12
ccs	6
cts	6
cp	1
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	6
nc	2
nop	1
crap	2

<?php

namespace UMA\Psr7Hmac\Internal;

use Psr\Http\Message\RequestInterface;

final class RequestSerializer
{
    const CRLF = "\r\n";

    /**
     * Returns the string representation of an HTTP request.
     *
     * @param RequestInterface $request Request to convert to a string.
     *
     * @return string
     */
    public static function serialize(RequestInterface $request)
    {
        return self::requestLine($request).self::headers($request).$request->getBody();
    }

    private static function requestLine(RequestInterface $request)
    {
        $method = $request->getMethod();
        $target = self::fixTarget(trim($request->getRequestTarget()));
        $protocol = 'HTTP/'.$request->getProtocolVersion();

        return "$method $target $protocol".self::CRLF;
    }

    private static function headers(RequestInterface $request)
    {
        $headers = $request->getHeaders();

        unset($headers['host']);
        unset($headers['Host']);

        $headerLines = [];
        foreach ($headers as $name => $value) {
            $value = is_array($value) ? $value : [$value];
            $normalizedName = (new HeaderNameNormalizer())->normalize($name);

            $headerLines[$normalizedName] = $normalizedName.': '.implode(',', $value).self::CRLF;
        }

        ksort($headerLines);

        $host = $request->getUri()->getHost();

        return "host: $host".self::CRLF.implode($headerLines).self::CRLF;
    }

    private static function fixTarget($target)
    {
        if (!array_key_exists('query', $parsedTarget = parse_url($target))) {
            return $target;
        }

        parse_str($parsedTarget['query'], $query);

        ksort($query);

        return $parsedTarget['path'].'?'.http_build_query($query);
    }
}


1		<?php
2
3		namespace UMA\Psr7Hmac\Internal;
4
5		use Psr\Http\Message\RequestInterface;
6
7		final class RequestSerializer
8		{
9		const CRLF = "\r\n";
10
11		/**
12		* Returns the string representation of an HTTP request.
13		*
14		* @param RequestInterface $request Request to convert to a string.
15		*
16		* @return string
17		*/
18	136	public static function serialize(RequestInterface $request)
19		{
20	136	return self::requestLine($request).self::headers($request).$request->getBody();
21		}
22
23	136	private static function requestLine(RequestInterface $request)
24		{
25	136	$method = $request->getMethod();
26	136	$target = self::fixTarget(trim($request->getRequestTarget()));
27	136	$protocol = 'HTTP/'.$request->getProtocolVersion();
28
29	136	return "$method $target $protocol".self::CRLF;
30		}
31
32	136	private static function headers(RequestInterface $request)
33		{
34	136	$headers = $request->getHeaders();
35
36	136	unset($headers['host']);
37	136	unset($headers['Host']);
38
39	136	$headerLines = [];
40	136	foreach ($headers as $name => $value) {
41	127	$value = is_array($value) ? $value : [$value];
42	127	$normalizedName = (new HeaderNameNormalizer())->normalize($name);
43
44	127	$headerLines[$normalizedName] = $normalizedName.': '.implode(',', $value).self::CRLF;
45	136	}
46
47	136	ksort($headerLines);
48
49	136	$host = $request->getUri()->getHost();
50
51	136	return "host: $host".self::CRLF.implode($headerLines).self::CRLF;
52		}
53
54	136	private static function fixTarget($target)
55		{
56	136	if (!array_key_exists('query', $parsedTarget = parse_url($target))) {
57	118	return $target;
58		}
59
60	18	parse_str($parsedTarget['query'], $query);
61
62	18	ksort($query);
63
64	18	return $parsedTarget['path'].'?'.http_build_query($query);
65		}
66		}
67

1ma / Psr7Hmac

Push — master ( a03880...647009 )

RequestSerializer::fixTarget() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like