AbstractClient::__construct() - Code Metrics - Inspection of "Issues/15 auto reconnect to producer node" - 0x20h/phloppy - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#16)

by Jan

created 2016-03-11 22:09 UTC

AbstractClient::__construct() A

↳ Parent: AbstractClient

Complexity

Conditions	3
Paths	4

Size

Total Lines	17
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	3

Importance

Changes	2
Bugs	0	Features	1

Metric	Value
c	2
b	0
f	1
dl	0
loc	17
ccs	5
cts	5
cp	1
rs	9.4285
cc	3
eloc	11
nc	4
nop	3
crap	3

<?php
namespace Phloppy\Client;

use Phloppy\Exception\CommandException;
use Phloppy\Job;
use Phloppy\RespUtils;
use Phloppy\Stream\StreamException;
use Phloppy\Stream\StreamInterface;
use Psr\Log\LoggerInterface;
use Psr\Log\NullLogger;
use Symfony\Component\EventDispatcher\EventDispatcher;
use Symfony\Component\EventDispatcher\EventDispatcherInterface;
use Symfony\Component\EventDispatcher\ImmutableEventDispatcher;

/**
 * Abstract Disque Client.
 */
abstract class AbstractClient {

    /**
     * @var StreamInterface
     */
    protected $stream;

    /**
     * @var LoggerInterface
     */
    protected $log;

    /**
     * @var EventDispatcherInterface
     */
    private $dispatcher;


    /**
     * @param StreamInterface      $stream
     * @param LoggerInterface|null $log Logger instance.
     */
    public function __construct(
        StreamInterface $stream,
        LoggerInterface $log = null,
        EventDispatcherInterface $dispatcher = null
    ) {
        if (!$log) {
            $log = new NullLogger();
        }

        if (!$dispatcher) {
            $dispatcher = new EventDispatcher();
        }

        $this->log = $log;
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->stream = $stream;
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->dispatcher = $dispatcher;
    }


    /**
     * @return EventDispatcherInterface
     */
    public function getDispatcher()
    {
        return new $this->dispatcher;
    }


    /**
     * Send request and retrieve response to the connected disque node.
     *
     * @param array $args
     *
     * @return array|int|null|string
     *
     * @throws CommandException
     * @throws StreamException
     */
    protected function send(array $args = [])
    {
        $this->log->debug('send()ing command', $args);
        $response = RespUtils::deserialize($this->stream->write(RespUtils::serialize($args)));
        $this->log->debug('response', [$response]);

        return $response;
    }


    /**
     * Map Disque's job responses to Job objects.
     *
     * @param array $list Job response array from the disque server.
     *
     * @return Job[]
     */
    protected function mapJobs(array $list)
    {
        return array_map(
            function ($element) {
                return Job::create([
                    'queue' => $element[0],
                    'id' => $element[1],
                    'body' => isset($element[2]) ? $element[2] : '',
                ]);
            },
            $list
        );
    }
}


1		<?php
2		namespace Phloppy\Client;
3
4		use Phloppy\Exception\CommandException;
5		use Phloppy\Job;
6		use Phloppy\RespUtils;
7		use Phloppy\Stream\StreamException;
8		use Phloppy\Stream\StreamInterface;
9		use Psr\Log\LoggerInterface;
10		use Psr\Log\NullLogger;
11		use Symfony\Component\EventDispatcher\EventDispatcher;
12		use Symfony\Component\EventDispatcher\EventDispatcherInterface;
13		use Symfony\Component\EventDispatcher\ImmutableEventDispatcher;
14
15		/**
16		* Abstract Disque Client.
17		*/
18		abstract class AbstractClient {
19
20		/**
21		* @var StreamInterface
22		*/
23		protected $stream;
24
25		/**
26		* @var LoggerInterface
27		*/
28		protected $log;
29
30		/**
31		* @var EventDispatcherInterface
32	39	*/
33		private $dispatcher;
34	39
35	39
36	39	/**
37		* @param StreamInterface $stream
38	39	* @param LoggerInterface\|null $log Logger instance.
39	39	*/
40	39	public function __construct(
41		StreamInterface $stream,
42		LoggerInterface $log = null,
43		EventDispatcherInterface $dispatcher = null
44		) {
45		if (!$log) {
46		$log = new NullLogger();
47		}
48
49		if (!$dispatcher) {
50		$dispatcher = new EventDispatcher();
51		}
52	30
53		$this->log = $log;
		0 ignored issues – show Coding Style introduced 2016-03-11 22:20 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 8 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
54	30	$this->stream = $stream;
		0 ignored issues – show Coding Style introduced 2016-03-11 22:20 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
55	30	$this->dispatcher = $dispatcher;
56	25	}
57	25
58
59		/**
60		* @return EventDispatcherInterface
61		*/
62		public function getDispatcher()
63		{
64		return new $this->dispatcher;
65		}
66
67	8
68	8	/**
69	8	* Send request and retrieve response to the connected disque node.
70	7	*
71	7	* @param array $args
72	7	*
73	8	* @return array\|int\|null\|string
74		*
75	8	* @throws CommandException
76		* @throws StreamException
77		*/
78		protected function send(array $args = [])
79		{
80		$this->log->debug('send()ing command', $args);
81		$response = RespUtils::deserialize($this->stream->write(RespUtils::serialize($args)));
82		$this->log->debug('response', [$response]);
83
84		return $response;
85		}
86
87
88		/**
89		* Map Disque's job responses to Job objects.
90		*
91		* @param array $list Job response array from the disque server.
92		*
93		* @return Job[]
94		*/
95		protected function mapJobs(array $list)
96		{
97		return array_map(
98		function ($element) {
99		return Job::create([
100		'queue' => $element[0],
101		'id' => $element[1],
102		'body' => isset($element[2]) ? $element[2] : '',
103		]);
104		},
105		$list
106		);
107		}
108		}
109

0x20h / phloppy

Pull Request — master (#16)

AbstractClient::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like