personroles.politician_role

Complexity

Total Complexity

29

Size/Duplication

Total Lines	166
Duplicated Lines	0 %

Importance

Changes

0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	_Politician_default.fix_voter_count()	0	8	3
A	Politician.align_party_entries()	0	8	5
A	Politician.party_is_in_parties()	0	13	3
A	Politician.change_ward()	0	8	3
A	Politician.add_Party()	0	11	3
A	_Politician_default.scrape_wiki_table_for_ward()	0	10	4
A	Politician.__post_init__()	0	12	4
A	_Politician_default.renamed_wards()	0	11	3
A	_Politician_default.scrape_wiki_for_ward()	0	11	1

#!/usr/bin/env python
# -*- coding: utf-8 -*-
"""A set of dataclasses concerning roles of persons and their particulars."""
import os
import sys
from dataclasses import dataclass, field
from typing import List, Optional

PACKAGE_PARENT = ".."
SCRIPT_DIR = os.path.dirname(
    os.path.realpath(os.path.join(os.getcwd(), os.path.expanduser(__file__)))
)  # isort:skip # noqa # pylint: disable=wrong-import-position
sys.path.append(
    os.path.normpath(os.path.join(SCRIPT_DIR, PACKAGE_PARENT))
)  # isort: skip # noqa # pylint: disable=wrong-import-position

from personroles.person import Person  # type: ignore  # noqa
from personroles.resources import helpers  # type: ignore  # noqa
from personroles.resources.constants import (  # type: ignore # noqa

Unused PEERTITLES imported from personroles.resources.constants

    GERMAN_PARTIES,
    PEERTITLES,
)
from personroles.resources.helpers import AttrDisplay  # type: ignore # noqa
from personroles.resources.helpers import Party  # type: ignore # noqa


@dataclass

Class name "_Politician_default" doesn't conform to PascalCase naming style ('[^\\W\\da-z][^\\W_]+$' pattern)

class _Politician_default:
    """Data about the politician's party, ward and office(s)."""
    electoral_ward: str = field(default="ew")
    ward_no: Optional[int] = field(default=None)
    voter_count: Optional[int] = field(default=None)
    minister: Optional[str] = field(default=None)
    offices: List[str] = field(default_factory=lambda: [])
    parties: List[str] = field(default_factory=lambda: [])

    def renamed_wards(self):
        """Some electoral wards have been renamed in the Wikipedia."""
        wards = {
            "Kreis Aachen I": "Aachen III",
            "Hochsauerlandkreis II – Soest III": "Hochsauerlandkreis II",
            "Kreis Aachen II": "Aachen IV"
            if self.last_name in ["Wirtz", "Weidenhaupt"]

Wrong continued indentation (add 19 spaces).

The Instance of _Politician_default does not seem to have a member named last_name.

            else "Kreis Aachen I",

Wrong continued indentation (add 19 spaces).

        }
        if self.electoral_ward in wards.keys():
            self.electoral_ward = wards[self.electoral_ward]

    def scrape_wiki_for_ward(self) -> None:
        """Find tables in Wikipedia containing informations about electoral wards."""  # noqa
        import requests

Import outside toplevel (requests)

Unable to import 'requests'

        from bs4 import BeautifulSoup  # type: ignore

Unable to import 'bs4'

Import outside toplevel (bs4.BeautifulSoup)

        URL_base = "https://de.wikipedia.org/wiki/Landtagswahlkreis_{}"

Variable name "URL_base" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

        URL = URL_base.format(self.electoral_ward)

Variable name "URL" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

        req = requests.get(URL)
        bsObj = BeautifulSoup(req.text, "lxml")

Variable name "bsObj" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

        table = bsObj.find(class_="infobox float-right toptextcells")
        self.scrape_wiki_table_for_ward(table)

    def scrape_wiki_table_for_ward(self, table) -> None:

Missing function or method docstring

        for td in table.find_all("td"):

Variable name "td" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

            if "Wahlkreisnummer" in td.text:
                ward_no = td.find_next().text.strip()
                ward_no = ward_no.split(" ")[0]
                self.ward_no = int(ward_no)
            elif "Wahlberechtigte" in td.text:
                voter_count = td.find_next().text.strip()
                voter_count = self.fix_voter_count(voter_count)
                self.voter_count = int(voter_count)

    def fix_voter_count(self, voter_count):

Missing function or method docstring

This method could be written as a function/class method.

        if voter_count[-1] == "]":
            voter_count = voter_count[:-3]
        if " " in voter_count:
            voter_count = "".join(voter_count.split(" "))
        else:
            voter_count = "".join(voter_count.split("."))
        return voter_count


@dataclass

Too many ancestors (12/7)

class Politician(
    _Politician_default,

Wrong hanging indentation before block (add 4 spaces).

    helpers._Party_default,

Wrong hanging indentation before block (add 4 spaces).

It seems like _Party_default was declared protected and should not be accessed from this context.

    Person,

Wrong hanging indentation before block (add 4 spaces).

    helpers._Party_base,

Wrong hanging indentation before block (add 4 spaces).

It seems like _Party_base was declared protected and should not be accessed from this context.

    AttrDisplay,

Wrong hanging indentation before block (add 4 spaces).

):

    """
    Module politician_role.py is collecting electoral ward, ward no., voter
    count of that ward, minister (like "JM": Justizminister), offices (in case
    more than one ministry position is filled (i.e. ["JM", "FM"]), and parties.
    """

    def __post_init__(self):
        Party.__post_init__(self)
        Person.__post_init__(self)
        Person.get_sex(self)
        Person.get_age(self)
        self.change_ward()
        if self.party_name in GERMAN_PARTIES:
            self.parties.append(
                Party(self.party_name, self.party_entry, self.party_exit)
            )
        if self.minister and self.minister not in self.offices:
            self.offices.append(self.minister)

    def add_Party(

Method name "add_Party" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

Missing function or method docstring

        self, party_name, party_entry="unknown", party_exit="unknown"

Wrong hanging indentation before block (add 4 spaces).

    ):  # noqa
        if party_name in GERMAN_PARTIES:
            if self.party_is_in_parties(party_name, party_entry, party_exit):
                pass
            else:
                self.parties.append(Party(party_name, party_entry, party_exit))
                self.party_name = party_name

The attribute party_name was defined outside __init__.

                self.party_entry = party_entry
                self.party_exit = party_exit

    def align_party_entries(

Missing function or method docstring

This method could be written as a function/class method.

        self, party, party_name, party_entry, party_exit

Wrong hanging indentation before block (add 4 spaces).

The argument party_name seems to be unused.

    ) -> Party:  # noqa
        if party_entry != "unknown" and party.party_entry == "unknown":
            party.party_entry = party_entry
        if party_exit != "unknown" and party.party_exit == "unknown":
            party.party_exit = party_exit
        return party

    def party_is_in_parties(self, party_name, party_entry, party_exit):

Missing function or method docstring

        parties_tmp = self.parties[:]
        for party in parties_tmp:
            if party_name == party.party_name:
                party_updated = self.align_party_entries(
                    party, party_name, party_entry, party_exit
                )
                self.parties.remove(party)
                self.parties.append(party_updated)
                self.party_entry = party_updated.party_entry
                self.party_exit = party_updated.party_exit
                return True
        return False

    def change_ward(self, ward=None):

Missing function or method docstring

        if ward:
            self.electoral_ward = ward
        if self.electoral_ward not in ["ew", "Landesliste"]:
            self.renamed_wards()
            self.scrape_wiki_for_ward()
        else:
            self.electoral_ward = "ew"


if __name__ == "__main__":

    politician = Politician(
        "SPD",
        "Bärbel",
        "Gutherz",
        academic_title="Dr.",
        date_of_birth="1980",
        electoral_ward="Köln I",
    )
    print(politician)