table_helper.BuildRequest - Code Metrics - Inspection of "BuildRequest -> helpers" - webdivane/table - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 192c6a...bb68c7 )

by Plamen

created 2019-03-17 07:51 UTC

table_helper.BuildRequest B

↳ Parent: add/table_helper.js

Complexity

Conditions	1
Paths	1

Size

Total Lines	81
Code Lines	55

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	55
nc	1
nop	1
dl	0
loc	81
rs	8.4727
c	0
b	0
f	0

2 Functions

Rating	Name	Duplication	Size	Complexity
A		0	50	3
A		0	24	5

How to fix Long Method

var table_helper = {
    Init: function(tableId){
        var tContainer = document.getElementById(tableId);
        if(!this.IePrior(9)){
            SetColumnsHoverEffect(tContainer, tableId);
        }
        var tfoot = tContainer.getElementsByTagName("tfoot")[0];
        this.ProcessPaginationLinks(tfoot);
        
        function SetColumnsHoverEffect(tContainer, tableId){
            var tHcells = tContainer.rows[0].cells;
            for(var i = 0; i < tHcells.length; i++){
                if(tHcells[i].firstChild.tagName === "A"){
                    tHcells[i].firstChild.setAttribute("onmouseover",
                            "table.ColumnHover('" + tableId + "'," + i + ");");
                    tHcells[i].firstChild.setAttribute("onmouseout",
                            "table.ColumnHover('" + tableId + "');");
                }
            }
        }
    },
    ColumnHover: function(tableContainer, index){
        var rows = document.getElementById(tableContainer).rows;
        var upto = rows.length - 1;
        if(typeof index === "undefined"){
            ColumnHoverRelease(rows, upto);
        }else{
            for(var i = 0; i < upto; i++){
                rows[i].cells[index].setAttribute("lang", "col-hover");
            }
        }
        function ColumnHoverRelease(rows, upto){
            for(var i = 0; i < upto; i++){
                for(var j = 0; j < rows[i].cells.length; j++){
                    if(rows[i].cells[j].lang){
                        rows[i].cells[j].removeAttribute("lang");
                    }
                }
            }
        };
    },
    BuildRequest: function(tableId){
        var rq = this.helper.RqObject.call(this, tableId);
        Sort(rq);
        Filter(rq);
        return rq;
        
        function Sort(rq){
            var thTags = document.getElementById(rq.tableId)
                    .getElementsByTagName("thead")[0]
                    .getElementsByTagName("th");
            var length = thTags.length;
            for(var i = 0; i < length; i++){
                var link = thTags[i].getElementsByTagName("a")[0];
                if(link){
                    var span = link.getElementsByTagName("span")[0];
                    if(span && sortBySpan(span, i)){
                        break;
                    }
                }
            }
            
            function sortBySpan(span, i){
                var order = span.innerHTML;
                if(order.length === 1){
                    rq.colNo = i;
                    rq.colOrd = order === rq.strDesc ? "desc" : "asc";
                }
                return rq.colNo === i;
            }
        }
        function Filter(rq){
            var r = getFilterFieldsByTableID(rq.tableId);
            if(r.filter !== null){
                rq.filter = r.filter;
            }
            if(r.filterBy !== null){
                rq.filterBy = r.filterBy;
            }
            
            function getFilterFieldsByTableID(tableID){
                var fields = {filterBy: null, filter: null};
                var filterDiv = getFilterDivByTableIDOrNull(tableID);
                if(filterDiv !== null){
                    setFilterBy(fields, filterDiv);
                    setFilterValue(fields, filterDiv);
                }
                return fields;
                
                function getFilterDivByTableIDOrNull(tableID){
                    if(document.getElementById(tableID).parentNode
                            .getElementsByTagName("div").length > 0
                            ){
                        var containerDivs = document.getElementById(tableID)
                                .parentNode.getElementsByTagName("div");
                        for(var i = 0; i < containerDivs.length; i++){
                            if(containerDivs[i].getAttribute("class") === "filter"){
                                return containerDivs[i];
                            }
                        }

                    }
                    return null;
                }
                
                function setFilterBy(fields, filterDiv){
                    var select = filterDiv.getElementsByTagName("select")[0];
                    if(select &&
                            select.options[select.selectedIndex].value !== "all"
                            ){
                        fields.filterBy = select.options[select.selectedIndex].value;
                    }
                }
                function setFilterValue(fields, filterDiv){
                    var textObj = filterDiv.getElementsByTagName("input")[0];
                    if(textObj && textObj.value && textObj.value.length !== 0){
                        fields.filter = encodeURIComponent(textObj.value.trim());
                    }
                }
            }
        }
    },
    IePrior: function(v){
        var rv = false;
        if(window.navigator.appName === 'Microsoft Internet Explorer'){
            var ua = window.navigator.userAgent;
            var re = new RegExp("MSIE ([0-9]{1,}[\.0-9]{0,})");
            if(re.exec(ua) !== null){
                rv = parseFloat(RegExp.$1);
            }
            rv = rv < v ? true : false;
        }
        return rv;
    },
    GetParent: function(obj, objType){
        while(obj && obj.tagName !== objType.toUpperCase()){
            obj = obj.parentNode;
        }
        return obj;
    },
    ProcessPaginationLinks: function(tfoot){
        var pLinks = tfoot.querySelectorAll(".paging a");
        if(pLinks.length > 0){
            for(var j = 0; j < pLinks.length; j++){
                pLinks[j].setAttribute("href", "javascript:void(0);");
                pLinks[j].setAttribute("onclick", "return table.GoPage(this);");
            }
        }
    },
    RequestToUrl: function(rq){
        var url = location.pathname + ".json" + location.search;
        if(typeof rq === "object"){
            var getUrlVarName = {
                colNo: "col", colOrd: "ord", filter: "filter",
                filterBy: "filter-by", pageNo: "pg", exportType: "export",
                tableId: "table-id"
            };
            var flagFirst = location.search.length < 1 ? true : false;
            for(var r in rq){
var someObject;
for (var key in someObject) {
    if ( ! someObject.hasOwnProperty(key)) {
        continue; // Skip keys from the prototype.
    }

    doSomethingWith(key);
}
                var clue = flagFirst === true ? "?" : "&";
                url += clue + getUrlVarName[r] + "=" + rq[r];
                flagFirst = false;
            }
        }
        return url;
    },
    RqObject: function(tableId){
        var rq = {};
        rq.tableId = tableId;
        rq.strDesc = this.strDesc;
        rq.strAsc = this.strAsc;
        return rq;
    }
};


1			var table_helper = {
2			Init: function(tableId){
3			var tContainer = document.getElementById(tableId);
4			if(!this.IePrior(9)){
5			SetColumnsHoverEffect(tContainer, tableId);
6			}
7			var tfoot = tContainer.getElementsByTagName("tfoot")[0];
8			this.ProcessPaginationLinks(tfoot);
9
10			function SetColumnsHoverEffect(tContainer, tableId){
11			var tHcells = tContainer.rows[0].cells;
12			for(var i = 0; i < tHcells.length; i++){
13			if(tHcells[i].firstChild.tagName === "A"){
14			tHcells[i].firstChild.setAttribute("onmouseover",
15			"table.ColumnHover('" + tableId + "'," + i + ");");
16			tHcells[i].firstChild.setAttribute("onmouseout",
17			"table.ColumnHover('" + tableId + "');");
18			}
19			}
20			}
21			},
22			ColumnHover: function(tableContainer, index){
23			var rows = document.getElementById(tableContainer).rows;
24			var upto = rows.length - 1;
25			if(typeof index === "undefined"){
26			ColumnHoverRelease(rows, upto);
27			}else{
28			for(var i = 0; i < upto; i++){
29			rows[i].cells[index].setAttribute("lang", "col-hover");
30			}
31			}
32			function ColumnHoverRelease(rows, upto){
33			for(var i = 0; i < upto; i++){
34			for(var j = 0; j < rows[i].cells.length; j++){
35			if(rows[i].cells[j].lang){
36			rows[i].cells[j].removeAttribute("lang");
37			}
38			}
39			}
40			};
41			},
42			BuildRequest: function(tableId){
43			var rq = this.helper.RqObject.call(this, tableId);
44			Sort(rq);
45			Filter(rq);
46			return rq;
47
48			function Sort(rq){
49			var thTags = document.getElementById(rq.tableId)
50			.getElementsByTagName("thead")[0]
51			.getElementsByTagName("th");
52			var length = thTags.length;
53			for(var i = 0; i < length; i++){
54			var link = thTags[i].getElementsByTagName("a")[0];
55			if(link){
56			var span = link.getElementsByTagName("span")[0];
57			if(span && sortBySpan(span, i)){
58			break;
59			}
60			}
61			}
62
63			function sortBySpan(span, i){
64			var order = span.innerHTML;
65			if(order.length === 1){
66			rq.colNo = i;
67			rq.colOrd = order === rq.strDesc ? "desc" : "asc";
68			}
69			return rq.colNo === i;
70			}
71			}
72			function Filter(rq){
73			var r = getFilterFieldsByTableID(rq.tableId);
74			if(r.filter !== null){
75			rq.filter = r.filter;
76			}
77			if(r.filterBy !== null){
78			rq.filterBy = r.filterBy;
79			}
80
81			function getFilterFieldsByTableID(tableID){
82			var fields = {filterBy: null, filter: null};
83			var filterDiv = getFilterDivByTableIDOrNull(tableID);
84			if(filterDiv !== null){
85			setFilterBy(fields, filterDiv);
86			setFilterValue(fields, filterDiv);
87			}
88			return fields;
89
90			function getFilterDivByTableIDOrNull(tableID){
91			if(document.getElementById(tableID).parentNode
92			.getElementsByTagName("div").length > 0
93			){
94			var containerDivs = document.getElementById(tableID)
95			.parentNode.getElementsByTagName("div");
96			for(var i = 0; i < containerDivs.length; i++){
97			if(containerDivs[i].getAttribute("class") === "filter"){
98			return containerDivs[i];
99			}
100			}
101
102			}
103			return null;
104			}
105
106			function setFilterBy(fields, filterDiv){
107			var select = filterDiv.getElementsByTagName("select")[0];
108			if(select &&
109			select.options[select.selectedIndex].value !== "all"
110			){
111			fields.filterBy = select.options[select.selectedIndex].value;
112			}
113			}
114			function setFilterValue(fields, filterDiv){
115			var textObj = filterDiv.getElementsByTagName("input")[0];
116			if(textObj && textObj.value && textObj.value.length !== 0){
117			fields.filter = encodeURIComponent(textObj.value.trim());
118			}
119			}
120			}
121			}
122			},
123			IePrior: function(v){
124			var rv = false;
125			if(window.navigator.appName === 'Microsoft Internet Explorer'){
126			var ua = window.navigator.userAgent;
127			var re = new RegExp("MSIE ([0-9]{1,}[\.0-9]{0,})");
128			if(re.exec(ua) !== null){
129			rv = parseFloat(RegExp.$1);
130			}
131			rv = rv < v ? true : false;
132			}
133			return rv;
134			},
135			GetParent: function(obj, objType){
136			while(obj && obj.tagName !== objType.toUpperCase()){
137			obj = obj.parentNode;
138			}
139			return obj;
140			},
141			ProcessPaginationLinks: function(tfoot){
142			var pLinks = tfoot.querySelectorAll(".paging a");
143			if(pLinks.length > 0){
144			for(var j = 0; j < pLinks.length; j++){
145			pLinks[j].setAttribute("href", "javascript:void(0);");
146			pLinks[j].setAttribute("onclick", "return table.GoPage(this);");
147			}
148			}
149			},
150			RequestToUrl: function(rq){
151			var url = location.pathname + ".json" + location.search;
152			if(typeof rq === "object"){
153			var getUrlVarName = {
154			colNo: "col", colOrd: "ord", filter: "filter",
155			filterBy: "filter-by", pageNo: "pg", exportType: "export",
156			tableId: "table-id"
157			};
158			var flagFirst = location.search.length < 1 ? true : false;
159			for(var r in rq){
			1 ignored issue – show Complexity introduced 2019-03-04 18:06 UTC by Report Bug Copy Issue Report A for in loop automatically includes the property of any prototype object, consider checking the key using `hasOwnProperty`. When iterating over the keys of an object, this includes not only the keys of the object, but also keys contained in the prototype of that object. It is generally a best practice to check for these keys specifically: var someObject; for (var key in someObject) { if ( ! someObject.hasOwnProperty(key)) { continue; // Skip keys from the prototype. } doSomethingWith(key); } Loading history...
160			var clue = flagFirst === true ? "?" : "&";
161			url += clue + getUrlVarName[r] + "=" + rq[r];
162			flagFirst = false;
163			}
164			}
165			return url;
166			},
167			RqObject: function(tableId){
168			var rq = {};
169			rq.tableId = tableId;
170			rq.strDesc = this.strDesc;
171			rq.strAsc = this.strAsc;
172			return rq;
173			}
174			};
175

webdivane / table

Push — master ( 192c6a...bb68c7 )

table_helper.BuildRequest B

Complexity

Size

Duplication

Importance

2 Functions

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like