Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 10 | class SubscriptionEventRepository extends EntityRepository |
||
| 11 | { |
||
| 12 | /** |
||
| 13 | * @return int |
||
| 14 | */ |
||
| 15 | 4 | public function getLastDayEventsCount(): int |
|
| 16 | { |
||
| 17 | 4 | $qb = $this->createQueryBuilder('se'); |
|
| 18 | |||
| 19 | 4 | $now = new \DateTime(); |
|
| 20 | |||
| 21 | return $qb |
||
| 22 | 4 | ->select('COUNT(se)') |
|
| 23 | 4 | ->where('se.date > :time') |
|
| 24 | 4 | ->setParameter('time', $now->sub(new \DateInterval('PT24H'))) |
|
| 25 | 4 | ->getQuery()->getSingleScalarResult() |
|
| 26 | ; |
||
| 27 | } |
||
| 28 | |||
| 29 | /** |
||
| 30 | * Creates QueryBuilder object for pagination of user subscribers events |
||
| 31 | * |
||
| 32 | * @param User $user |
||
| 33 | * |
||
| 34 | * @return QueryBuilder |
||
| 35 | */ |
||
| 36 | 3 | View Code Duplication | public function createUserLastSubscribersEventsQuery(User $user): QueryBuilder |
| 48 | |||
| 49 | /** |
||
| 50 | * Get last user subscriber events |
||
| 51 | * |
||
| 52 | * @param User $user |
||
| 53 | * @param int $limit |
||
| 54 | * |
||
| 55 | * @return SubscriptionEvent[] |
||
| 56 | */ |
||
| 57 | public function getUserLastSubscribersEvents(User $user, int $limit = 20): array |
||
| 64 | |||
| 65 | /** |
||
| 66 | * Get last global subscriptions QueryBuilder for pagination |
||
| 67 | * |
||
| 68 | * @return QueryBuilder |
||
| 69 | */ |
||
| 70 | 2 | View Code Duplication | public function createLastSubscriptionEventsQuery(): QueryBuilder |
| 81 | |||
| 82 | /** |
||
| 83 | * Get last global subscription events |
||
| 84 | * |
||
| 85 | * @param int $limit |
||
| 86 | * |
||
| 87 | * @return SubscriptionEvent[] |
||
| 88 | */ |
||
| 89 | public function getLastSubscriptionEvents(int $limit = 20): array |
||
| 96 | |||
| 97 | /** |
||
| 98 | * @return SubscriptionEvent[] |
||
| 99 | */ |
||
| 100 | public function getLastEventsByDay(int $days = 30): array |
||
| 126 | } |