UserFactory::findOrCreateFromDTO() - Code Metrics - Inspection of "fix #30. Factories and API clients refactored to D..." - skobkin/point-tools - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Push — master ( 80a7cc...26b8e4 )

by Alexey

created 2017-01-15 02:58 UTC

UserFactory::findOrCreateFromDTO() A

↳ Parent: UserFactory

Complexity

Conditions	3
Paths	3

Size

Total Lines	23
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	23
ccs	0
cts	9
cp	0
rs	9.0856
cc	3
eloc	10
nc	3
nop	1
crap	12

<?php

namespace Skobkin\Bundle\PointToolsBundle\Service\Factory;

use Psr\Log\LoggerInterface;
use Skobkin\Bundle\PointToolsBundle\DTO\Api\User as UserDTO;
use Skobkin\Bundle\PointToolsBundle\Entity\User;
use Skobkin\Bundle\PointToolsBundle\Repository\UserRepository;
use Skobkin\Bundle\PointToolsBundle\Exception\Factory\InvalidUserDataException;

class UserFactory extends AbstractFactory
{
    /**
     * @var UserRepository
     */
    private $userRepository;


    public function __construct(LoggerInterface $logger, UserRepository $userRepository)
    {
        parent::__construct($logger);
        $this->userRepository = $userRepository;
    }

    /**
     * @param UserDTO $userData
     *
     * @return User
     *
     * @throws InvalidUserDataException
     */
    public function findOrCreateFromDTO(UserDTO $userData): User
    {
        // @todo LOG

        if (!$userData->isValid()) {
            throw new InvalidUserDataException('Invalid user data', $userData);
        }

        /** @var User $user */
        if (null === ($user = $this->userRepository->find($userData->getId()))) {
            // Creating new user
            $user = new User($userData->getId());
            $this->userRepository->add($user);
        }

        // Updating data
        $user
            ->setLogin($userData->getLogin())
            ->setName($userData->getName())
        ;

        return $user;
    }

    public function findOrCreateFromDTOArray(array $usersData): array
    {
        // @todo LOG

        $result = [];

        foreach ($usersData as $userData) {
            $result[] = $this->findOrCreateFromDTO($userData);
        }

        return $result;
    }
}

1			<?php
2
3			namespace Skobkin\Bundle\PointToolsBundle\Service\Factory;
4
5			use Psr\Log\LoggerInterface;
6			use Skobkin\Bundle\PointToolsBundle\DTO\Api\User as UserDTO;
7			use Skobkin\Bundle\PointToolsBundle\Entity\User;
8			use Skobkin\Bundle\PointToolsBundle\Repository\UserRepository;
9			use Skobkin\Bundle\PointToolsBundle\Exception\Factory\InvalidUserDataException;
10
11			class UserFactory extends AbstractFactory
12			{
13			/**
14			* @var UserRepository
15			*/
16			private $userRepository;
17
18
19			public function __construct(LoggerInterface $logger, UserRepository $userRepository)
20			{
21			parent::__construct($logger);
22			$this->userRepository = $userRepository;
23			}
24
25			/**
26			* @param UserDTO $userData
27			*
28			* @return User
29			*
30			* @throws InvalidUserDataException
31			*/
32			public function findOrCreateFromDTO(UserDTO $userData): User
33			{
34			// @todo LOG
35
36			if (!$userData->isValid()) {
37			throw new InvalidUserDataException('Invalid user data', $userData);
38			}
39
40			/** @var User $user */
41			if (null === ($user = $this->userRepository->find($userData->getId()))) {
42			// Creating new user
43			$user = new User($userData->getId());
44			$this->userRepository->add($user);
45			}
46
47			// Updating data
48			$user
49			->setLogin($userData->getLogin())
50			->setName($userData->getName())
51			;
52
53			return $user;
54			}
55
56			public function findOrCreateFromDTOArray(array $usersData): array
57			{
58			// @todo LOG
59
60			$result = [];
61
62			foreach ($usersData as $userData) {
63			$result[] = $this->findOrCreateFromDTO($userData);
64			}
65
66			return $result;
67			}
68			}

skobkin / point-tools

Push — master ( 80a7cc...26b8e4 )

UserFactory::findOrCreateFromDTO() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like