SubscriptionsManager::updateUserSubscribers() - Code Metrics - Inspection of "User renaming Telegram notifications. User renamin..." - skobkin/point-tools - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 6c1980...4e24b5 )

by Alexey

created 2017-01-06 21:38 UTC

SubscriptionsManager::updateUserSubscribers() B

↳ Parent: SubscriptionsManager

Complexity

Conditions	7
Paths	24

Size

Total Lines	66
Code Lines	34

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	56

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	66
ccs	0
cts	43
cp	0
rs	7.0832
cc	7
eloc	34
nc	24
nop	2
crap	56

How to fix Long Method

<?php

namespace Skobkin\Bundle\PointToolsBundle\Service;

use Doctrine\ORM\EntityManager;
use Doctrine\ORM\QueryBuilder;
use Skobkin\Bundle\PointToolsBundle\Entity\Subscription;
use Skobkin\Bundle\PointToolsBundle\Entity\SubscriptionEvent;
use Skobkin\Bundle\PointToolsBundle\Entity\User;

class SubscriptionsManager
{
    /**
     * @var EntityManager
     */
    protected $em;


    // @todo Add logger
    public function __construct(EntityManager $entityManager)
function someFunction(ManagerRegistry $registry) {
    $em = $registry->getManager();
    $em->getConnection()->beginTransaction();
    try {
        // Do something.
        $em->getConnection()->commit();
    } catch (\Exception $ex) {
        $em->getConnection()->rollback();
        $em->close();

        throw $ex;
    }
}
    {
        $this->em = $entityManager;
    }

    /**
     * @param User $user
     * @param User[]|array $newSubscribersList
     */
    public function updateUserSubscribers(User $user, $newSubscribersList = [])
    {
        /** @var Subscription[] $tmpOldSubscribers */
        $tmpOldSubscribers = $user->getSubscribers();

        $oldSubscribersList = [];

        foreach ($tmpOldSubscribers as $subscription) {
            $oldSubscribersList[] = $subscription->getSubscriber();
        }

        $isFirstTime = false;

        // Preventing to add garbage subscriptions for first processing
        // @todo improve algorithm
        if ((count($oldSubscribersList) === 0) && (count($newSubscribersList) > 1)) {
            $isFirstTime = true;
        }

        unset($tmpOldSubscribers);

        $subscribedList = $this->getUsersListsDiff($newSubscribersList, $oldSubscribersList);
        $unsubscribedList = $this->getUsersListsDiff($oldSubscribersList, $newSubscribersList);

        /** @var User $subscribedUser */
        foreach ($subscribedList as $subscribedUser) {
            $subscription = new Subscription($user, $subscribedUser);

            $user->addSubscriber($subscription);
            $this->em->persist($subscription);

            // If it's not first processing
            if (!$isFirstTime) {
                $logEvent = new SubscriptionEvent($user, $subscribedUser, SubscriptionEvent::ACTION_SUBSCRIBE);
                $this->em->persist($logEvent);

                $user->addNewSubscriberEvent($logEvent);
            }
        }

        unset($subscribedList);

        /** @var QueryBuilder $unsubscribedQuery */
        $unsubscribedQuery = $this->em->getRepository('SkobkinPointToolsBundle:Subscription')->createQueryBuilder('s');
        $unsubscribedQuery
            ->delete()
            ->where('s.author = :author')
            ->andWhere('s.subscriber IN (:subscribers)')
        ;

        /** @var User $unsubscribedUser */
        foreach ($unsubscribedList as $unsubscribedUser) {
            $logEvent = new SubscriptionEvent($user, $unsubscribedUser, SubscriptionEvent::ACTION_UNSUBSCRIBE);
            $this->em->persist($logEvent);

            $user->addNewSubscriberEvent($logEvent);
        }

        $unsubscribedQuery
            ->setParameter('author', $user->getId())
            ->setParameter('subscribers', $unsubscribedList)
            ->getQuery()->execute();
        ;

        unset($unsubscribedList);
    }

    /**
     * Compares $list1 against $list2 and returns the values in $list1 that are not present in $list2.
     *
     * @param User[] $list1
     * @param User[] $list2
     *
     * @return User[] Diff
     */
    public function getUsersListsDiff(array $list1 = [], array $list2 = [])
    {
        $hash1 = [];
        $hash2 = [];

        foreach ($list1 as $user) {
            $hash1[$user->getId()] = $user;
        }
        foreach ($list2 as $user) {
            $hash2[$user->getId()] = $user;
        }

        return array_diff_key($hash1, $hash2);
    }
}

1			<?php
2
3			namespace Skobkin\Bundle\PointToolsBundle\Service;
4
5			use Doctrine\ORM\EntityManager;
6			use Doctrine\ORM\QueryBuilder;
7			use Skobkin\Bundle\PointToolsBundle\Entity\Subscription;
8			use Skobkin\Bundle\PointToolsBundle\Entity\SubscriptionEvent;
9			use Skobkin\Bundle\PointToolsBundle\Entity\User;
10
11			class SubscriptionsManager
12			{
13			/**
14			* @var EntityManager
15			*/
16			protected $em;
17
18
19			// @todo Add logger
20			public function __construct(EntityManager $entityManager)
			0 ignored issues – show Bug introduced 2016-12-12 18:42 UTC by Report Bug Copy Issue Report You have injected the EntityManager via parameter `$entityManager`. This is generally not recommended as it might get closed and become unusable. Instead, it is recommended to inject the ManagerRegistry and retrieve the EntityManager via `getManager()` each time you need it. The `EntityManager` might become unusable for example if a transaction is rolled back and it gets closed. Let’s assume that somewhere in your application, or in a third-party library, there is code such as the following: function someFunction(ManagerRegistry $registry) { $em = $registry->getManager(); $em->getConnection()->beginTransaction(); try { // Do something. $em->getConnection()->commit(); } catch (\Exception $ex) { $em->getConnection()->rollback(); $em->close(); throw $ex; } } If that code throws an exception and the `EntityManager` is closed. Any other code which depends on the same instance of the `EntityManager` during this request will fail. On the other hand, if you instead inject the `ManagerRegistry`, the `getManager()` method guarantees that you will always get a usable manager instance. Loading history...
21			{
22			$this->em = $entityManager;
23			}
24
25			/**
26			* @param User $user
27			* @param User[]\|array $newSubscribersList
28			*/
29			public function updateUserSubscribers(User $user, $newSubscribersList = [])
30			{
31			/** @var Subscription[] $tmpOldSubscribers */
32			$tmpOldSubscribers = $user->getSubscribers();
33
34			$oldSubscribersList = [];
35
36			foreach ($tmpOldSubscribers as $subscription) {
37			$oldSubscribersList[] = $subscription->getSubscriber();
38			}
39
40			$isFirstTime = false;
41
42			// Preventing to add garbage subscriptions for first processing
43			// @todo improve algorithm
44			if ((count($oldSubscribersList) === 0) && (count($newSubscribersList) > 1)) {
45			$isFirstTime = true;
46			}
47
48			unset($tmpOldSubscribers);
49
50			$subscribedList = $this->getUsersListsDiff($newSubscribersList, $oldSubscribersList);
51			$unsubscribedList = $this->getUsersListsDiff($oldSubscribersList, $newSubscribersList);
52
53			/** @var User $subscribedUser */
54			foreach ($subscribedList as $subscribedUser) {
55			$subscription = new Subscription($user, $subscribedUser);
56
57			$user->addSubscriber($subscription);
58			$this->em->persist($subscription);
59
60			// If it's not first processing
61			if (!$isFirstTime) {
62			$logEvent = new SubscriptionEvent($user, $subscribedUser, SubscriptionEvent::ACTION_SUBSCRIBE);
63			$this->em->persist($logEvent);
64
65			$user->addNewSubscriberEvent($logEvent);
66			}
67			}
68
69			unset($subscribedList);
70
71			/** @var QueryBuilder $unsubscribedQuery */
72			$unsubscribedQuery = $this->em->getRepository('SkobkinPointToolsBundle:Subscription')->createQueryBuilder('s');
73			$unsubscribedQuery
74			->delete()
75			->where('s.author = :author')
76			->andWhere('s.subscriber IN (:subscribers)')
77			;
78
79			/** @var User $unsubscribedUser */
80			foreach ($unsubscribedList as $unsubscribedUser) {
81			$logEvent = new SubscriptionEvent($user, $unsubscribedUser, SubscriptionEvent::ACTION_UNSUBSCRIBE);
82			$this->em->persist($logEvent);
83
84			$user->addNewSubscriberEvent($logEvent);
85			}
86
87			$unsubscribedQuery
88			->setParameter('author', $user->getId())
89			->setParameter('subscribers', $unsubscribedList)
90			->getQuery()->execute();
91			;
92
93			unset($unsubscribedList);
94			}
95
96			/**
97			* Compares $list1 against $list2 and returns the values in $list1 that are not present in $list2.
98			*
99			* @param User[] $list1
100			* @param User[] $list2
101			*
102			* @return User[] Diff
103			*/
104			public function getUsersListsDiff(array $list1 = [], array $list2 = [])
105			{
106			$hash1 = [];
107			$hash2 = [];
108
109			foreach ($list1 as $user) {
110			$hash1[$user->getId()] = $user;
111			}
112			foreach ($list2 as $user) {
113			$hash2[$user->getId()] = $user;
114			}
115
116			return array_diff_key($hash1, $hash2);
117			}
118			}

skobkin / point-tools

Push — master ( 6c1980...4e24b5 )

SubscriptionsManager::updateUserSubscribers() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like