Skobkin\Bundle\PointToolsBundle\Service\Factory\UserFactory

Complexity

Total Complexity

12

Size/Duplication

Total Lines	99
Duplicated Lines	5.05 %

Coupling/Cohesion

Components	1
Dependencies	6

Test Coverage

Coverage

0%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	createFromArray()	5	19	2
A	createFromDTO()	0	19	2
A	validateArrayData()	0	6	4
A	validateDTOData()	0	6	3

<?php

namespace Skobkin\Bundle\PointToolsBundle\Service\Factory;

use Doctrine\ORM\EntityManager;
use Doctrine\ORM\EntityManagerInterface;
use Doctrine\ORM\EntityRepository;
use Skobkin\Bundle\PointToolsBundle\DTO\Api\Crawler\User as UserDTO;
use Skobkin\Bundle\PointToolsBundle\Entity\User;
use Skobkin\Bundle\PointToolsBundle\Service\Exceptions\ApiException;
use Skobkin\Bundle\PointToolsBundle\Service\Exceptions\Factory\InvalidUserDataException;
use Skobkin\Bundle\PointToolsBundle\Service\Exceptions\InvalidResponseException;


class UserFactory
{
    /**
     * @var EntityManager
     */
    private $em;

    /**
     * @var EntityRepository
     */
    private $userRepository;

    /**
     * @param EntityManager $em
     */
    public function __construct(EntityManager $em)

You have injected the EntityManager via parameter $em. This is generally not recommended as it might get closed and become unusable. Instead, it is recommended to inject the ManagerRegistry and retrieve the EntityManager via getManager() each time you need it.

    {
        $this->em = $em;
        $this->userRepository = $em->getRepository('SkobkinPointToolsBundle:User');
    }

    /**
     * @param array $data
     *
     * @return User
     * @throws ApiException
     * @throws InvalidResponseException
     */
    public function createFromArray(array $data)
    {
        $this->validateArrayData($data);

        /** @var User $user */
        if (null === ($user = $this->userRepository->find($data['id']))) {

This code seems to be duplicated across your project.

            // Creating new user
            $user = new User($data['id']);
            $this->em->persist($user);
        }

        // Updating data
        $user
            ->setLogin($data['login'])
            ->setName($data['name'])
        ;

        return $user;
    }

    /**
     * @param UserDTO $userData
     *
     * @return User
     * @throws ApiException
     * @throws InvalidUserDataException
     */
    public function createFromDTO(UserDTO $userData)
    {
        $this->validateDTOData($userData);

        /** @var User $user */
        if (null === ($user = $this->userRepository->find($userData->getId()))) {
            // Creating new user
            $user = new User($userData->getId());
            $this->em->persist($user);
        }

        // Updating data
        $user
            ->setLogin($userData->getLogin())
            ->setName($userData->getName())
        ;

        return $user;
    }

    /**
     * @param array $data
     *
     * @throws InvalidResponseException
     */
    private function validateArrayData(array $data)
    {
        if (!(array_key_exists('id', $data) || !!array_key_exists('login', $data) || !array_key_exists('name', $data))) {
            throw new InvalidResponseException('Invalid user data');
        }
    }

    /**
     * @param array $data
     *
     * @throws InvalidResponseException
     */
    private function validateDTOData(UserDTO $data)
    {
        if (!$data->getId() || !$data->getLogin()) {
            throw new InvalidUserDataException('User have no id or login', $data);
        }
    }
}