Skobkin\Bundle\PointToolsBundle\Service\Factory\Blogs\CommentFactory

Complexity

Total Complexity

14

Size/Duplication

Total Lines	105
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Test Coverage

Coverage

0%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
A	createFromArray()	0	22	3
A	createFromListArray()	0	10	2
B	validateData()	0	18	8

<?php

namespace Skobkin\Bundle\PointToolsBundle\Service\Factory\Blogs;

use Doctrine\ORM\EntityManager;
use Doctrine\ORM\EntityRepository;
use Skobkin\Bundle\PointToolsBundle\Entity\Blogs\Comment;
use Skobkin\Bundle\PointToolsBundle\Service\Exceptions\ApiException;
use Skobkin\Bundle\PointToolsBundle\Service\Exceptions\InvalidResponseException;
use Skobkin\Bundle\PointToolsBundle\Service\Factory\UserFactory;


class CommentFactory
{
    /**
     * @var EntityManager
     */
    private $em;

    /**
     * @var EntityRepository
     */
    private $commentRepository;

    /**
     * @var EntityRepository
     */
    private $postRepository;

    /**
     * @var UserFactory
     */
    private $userFactory;

    /**
     * @param EntityManager $em
     * @param UserFactory $userFactory
     */
    public function __construct(EntityManager $em, UserFactory $userFactory)

You have injected the EntityManager via parameter $em. This is generally not recommended as it might get closed and become unusable. Instead, it is recommended to inject the ManagerRegistry and retrieve the EntityManager via getManager() each time you need it.

    {
        $this->em = $em;
        $this->userFactory = $userFactory;
        $this->commentRepository = $em->getRepository('SkobkinPointToolsBundle:Blogs\Comment');
        $this->postRepository = $em->getRepository('SkobkinPointToolsBundle:Blogs\Post');
    }

    /**
     * @param array $data
     *
     * @return Comment
     * @throws ApiException
     * @throws InvalidResponseException
     */
    public function createFromArray(array $data)
    {
        $this->validateData($data);

        if (null === ($comment = $this->commentRepository->find(['post' => $data['post_id'], 'id' => $data['id']]))) {
            // @fixme rare non-existing post bug
            $post = $this->postRepository->find($data['post_id']);
            $author = $this->userFactory->createFromArray($data['author']);
            if (null !== $data['to_comment_id']) {
                $toComment = $this->commentRepository->find(['post' => $data['post_id'], 'id' => $data['to_comment_id']]);
            } else {
                $toComment = null;
            }
            $createdAt = new \DateTime($data['created']);

            $comment = new Comment($data['id'], $post, $author, $toComment, $data['text'], $createdAt, $data['is_rec']);

The call to Comment::__construct() has too many arguments starting with $data['id'].

            $this->em->persist($comment);
        }

        return $comment;
    }

    /**
     * @param array $data
     *
     * @return Comment[]
     * @throws ApiException
     */
    public function createFromListArray(array $data)
    {
        $comments = [];

        foreach ($data as $commentData) {
            $comments[] = $this->createFromArray($commentData);
        }

        return $comments;
    }

    /**
     * @param array $data
     *
     * @throws InvalidResponseException
     */
    private function validateData(array $data)
    {
        if (!array_key_exists('author', $data)) {
            throw new InvalidResponseException('Comment author data not found in API response');
        }

        // Post
        if (!(
            array_key_exists('id', $data) &&
            array_key_exists('is_rec', $data) &&
            array_key_exists('to_comment_id', $data) &&
            array_key_exists('post_id', $data) &&
            array_key_exists('text', $data) &&
            array_key_exists('created', $data)
            )) {
            throw new InvalidResponseException('Comment data not found in API response');
        }
    }
}