Skobkin\Bundle\PointToolsBundle\Service\Factory\Blogs\FileFactory

Complexity

Total Complexity

8

Size/Duplication

Total Lines	70
Duplicated Lines	22.86 %

Coupling/Cohesion

Components	1
Dependencies	5

Test Coverage

Coverage

0%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	createFromUrlsArray()	16	16	3
A	createFromUrl()	0	15	2
A	validateData()	0	7	2

<?php

namespace Skobkin\Bundle\PointToolsBundle\Service\Factory\Blogs;

use Psr\Log\LoggerInterface;
use Skobkin\Bundle\PointToolsBundle\Entity\Blogs\File;
use Skobkin\Bundle\PointToolsBundle\Repository\Blogs\FileRepository;
use Skobkin\Bundle\PointToolsBundle\Exception\Api\InvalidResponseException;
use Skobkin\Bundle\PointToolsBundle\Service\Factory\AbstractFactory;

class FileFactory extends AbstractFactory
{
    /** @var FileRepository */
    private $fileRepository;


    public function __construct(LoggerInterface $logger, FileRepository $fileRepository)
    {
        parent::__construct($logger);
        $this->fileRepository = $fileRepository;
    }

    /**
     * @param string[] $urlStrings
     *
     * @return File[]
     */
    public function createFromUrlsArray(array $urlStrings): array

This method seems to be duplicated in your project.

    {
        $files = [];

        foreach ($urlStrings as $url) {
            try {
                $file = $this->createFromUrl($url);
                $files[] = $file;
            } catch (\Exception $e) {
                $this->logger->error('Error while creating file from DTO', ['file' => $url, 'message' => $e->getMessage()]);
                continue;
            }
        }

        return $files;
    }

    /**
     * @param string $url
     *
     * @return File
     *
     * @throws InvalidResponseException
     */
    public function createFromUrl(string $url): File
    {
        $this->validateData($url);

        // Replacing HTTP with HTTPS
        $url = str_replace('http://', 'https://', $url);

        if (null === ($file = $this->fileRepository->findOneBy(['remoteUrl' => $url]))) {
            // Creating new file
            $file = new File($url);
            $this->fileRepository->add($file);
        }

        return $file;
    }

    /**
     * @param $data
     *
     * @throws InvalidResponseException
     */
    private function validateData($data): void
    {
        if (!is_string($data)) {
            // @todo Change exception
            throw new InvalidResponseException('File data must be a string');
        }
    }
}