newicon / neon

neon/phoebe/services/PhoebeService.php

Braces +8 added lines, -6 removed lines

@@ -82,13 +82,15 @@
 		$types = $this->listPhoebeTypes();
 		$requested = isset($types[$phoebeKey]) ? $types[$phoebeKey] : null;
 		// check that we can create the requested type
-		if (!($requested && in_array($requested['status'], ['AVAILABLE', 'IN_DEVELOPMENT'])))
-			return null;
+		if (!($requested && in_array($requested['status'], ['AVAILABLE', 'IN_DEVELOPMENT']))) {
+					return null;
+		}
 		$adapter = $requested['adapter'];
-		if (strpos($adapter, '\\') !== false)
-			$type = $adapter;
-		else
-			$type = str_replace('ADAPTER', $requested['adapter'], $this->genericTypePath);
+		if (strpos($adapter, '\\') !== false) {
+					$type = $adapter;
+		} else {
+					$type = str_replace('ADAPTER', $requested['adapter'], $this->genericTypePath);
+		}
 		return $type ? new $type : null;
 	}
 

neon/phoebe/services/adapters/appforms/PhoebeObject.php

Spacing +4 added lines, -4 removed lines

@@ -106,13 +106,13 @@ 
 	 *
 	 * @param type $objects
 	 */
-	protected function updateDataFromDds(&$objects, $isTree=true)
+	protected function updateDataFromDds(&$objects, $isTree = true)
 	{
 		// It may be better to flatten the data and make a more intelligent
 		// set of selects from the database, or use the idea of requests and
 		// do this in two passes
 		$dds = neon('dds')->getIDdsObjectManagement();
-		foreach($objects as &$object) {
+		foreach ($objects as &$object) {
 			if (!empty($object['_uuid'])) {
 				// update the object definition to pick up any new fields from the definition
 				$object = array_merge($this->getAllowedFieldsForClass($object['_classType']), $object);
@@ -191,7 +191,7 @@ 
 	 * @param array &$objects
 	 * @return array
 	 */
-	protected function extractObjects(&$objects, &$extractedObjectIds=null)
+	protected function extractObjects(&$objects, &$extractedObjectIds = null)
 	{
 		//
 		// TODO - this code is particularly messy - refactor
@@ -394,7 +394,7 @@ 
 		if (!empty($objRend['dataSourceMap'])) {
 			foreach ($objRend['dataSourceMap'] as $member => $dsMap) {
 				$dsDef = $this->getDataSourceDefinition($dsMap['id']);
-				if (($dsObj = $this->getDataSourceObject($dsDef['label']))!==null) {
+				if (($dsObj = $this->getDataSourceObject($dsDef['label'])) !== null) {
 					$object[$member] = $dsObj[$dsMap['memberRef']];
 				}
 			}

Braces +33 added lines, -22 removed lines

@@ -41,8 +41,9 @@ 
 	public function editObject($changes)
 	{
 		// check if there's anything to do
-		if (empty($changes) || $changes == $this->data)
-			return true;
+		if (empty($changes) || $changes == $this->data) {
+					return true;
+		}
 
 		// extract the data and save appropriately to
 		// the associated database tables ... if any
@@ -59,8 +60,9 @@ 
 	public function setDataSources($sources)
 	{
 		foreach ($sources as $key=>$value) {
-			if (empty($value))
-				unset($sources[$key]);
+			if (empty($value)) {
+							unset($sources[$key]);
+			}
 		}
 		$this->dataSourceIds = $sources;
 	}
@@ -97,8 +99,9 @@ 
 	 */
 	protected function getDataSources()
 	{
-		foreach ($this->dataSourceIds as $key=>$id)
-			$this->dataSourceObjects[$key] = $this->getDds()->getObject($id);
+		foreach ($this->dataSourceIds as $key=>$id) {
+					$this->dataSourceObjects[$key] = $this->getDds()->getObject($id);
+		}
 	}
 
 	/**
@@ -118,8 +121,9 @@ 
 				$object = array_merge($this->getAllowedFieldsForClass($object['_classType']), $object);
 				// now update the object with the data from daedalus
 				$data = $dds->getObject($object['_uuid']);
-				if ($data)
-					$object = array_replace($object, array_intersect_key($data, $object));
+				if ($data) {
+									$object = array_replace($object, array_intersect_key($data, $object));
+				}
 			}
 			// recursively update if this is in a tree structure
 			if ($isTree && is_array($object)) {
@@ -179,8 +183,9 @@ 
 				}
 			}
 		}
-		if (count($relations))
-			$this->saveLinkedObjects($relations);
+		if (count($relations)) {
+					$this->saveLinkedObjects($relations);
+		}
 	}
 
 	/**
@@ -216,8 +221,9 @@ 
 							$relations = $renderables[$subRenderable]['relations'];
 							foreach ($relations as $relation) {
 								$memberRef = $relation['memberRef'];
-								if (!isset($extracted['__relations'][$objId][$memberRef]))
-									$extracted['__relations'][$objId][$memberRef] = [];
+								if (!isset($extracted['__relations'][$objId][$memberRef])) {
+																	$extracted['__relations'][$objId][$memberRef] = [];
+								}
 								$extracted['__relations'][$objId][$memberRef] = array_merge($extracted['__relations'][$objId][$memberRef], $newObjectIds);
 							}
 						}
@@ -259,8 +265,9 @@ 
 		if (empty($fieldsForClass[$classType])) {
 			$definition = $this->getDefinition();
 			foreach ($definition['renderables'] as $r) {
-				if ($r['type'] == 'MemberComponent')
-					$fieldsForClass[$r['class_type']][$r['member_ref']] = null;
+				if ($r['type'] == 'MemberComponent') {
+									$fieldsForClass[$r['class_type']][$r['member_ref']] = null;
+				}
 			}
 		}
 		return $fieldsForClass[$classType];
@@ -322,8 +329,9 @@ 
 			if (isset($renderables[$phoebeKey])) {
 				// check the renderable exists and is a class component
 				$ren = $renderables[$phoebeKey];
-				if ($ren['type'] != 'ClassComponent')
-					continue;
+				if ($ren['type'] != 'ClassComponent') {
+									continue;
+				}
 
 				// create the object and any required data params
 				$object = [
@@ -334,8 +342,9 @@ 
 				foreach ($ren['items'] as $item) {
 					if (isset($renderables[$item])) {
 						$iRen = $renderables[$item];
-						if ($iRen['type'] != 'MemberComponent')
-							continue;
+						if ($iRen['type'] != 'MemberComponent') {
+													continue;
+						}
 						$object[$iRen['member_ref']] = null;
 					}
 				}
@@ -455,8 +464,9 @@ 
 	private $_class = null;
 	private function getClass()
 	{
-		if (!$this->_class)
-			$this->_class = neon('phoebe')->getIPhoebeType($this->phoebeType)->getClass($this->classType);
+		if (!$this->_class) {
+					$this->_class = neon('phoebe')->getIPhoebeType($this->phoebeType)->getClass($this->classType);
+		}
 		return $this->_class;
 	}
 
@@ -469,8 +479,9 @@ 
 	private $_dds = null;
 	private function getDds()
 	{
-		if (!$this->_dds)
-			$this->_dds = neon('dds')->getIDdsObjectManagement();
+		if (!$this->_dds) {
+					$this->_dds = neon('dds')->getIDdsObjectManagement();
+		}
 		return $this->_dds;
 	}
 

neon/phoebe/services/adapters/appforms/PhoebeClass.php

Spacing +8 added lines, -8 removed lines

@@ -23,7 +23,7 @@ 
 	/**
 	 * @inheritdoc
 	 */
-	public function getClassFormDefinition(array $fields=[])
+	public function getClassFormDefinition(array $fields = [])
 	{
 		// if there is no definition return an empty form
 		if (empty($this->definition))
@@ -133,19 +133,19 @@ 
 	protected function convertRenderablesToFields($key, $renderables) {
 		if (!isset($renderables[$key])) {
 			dd("Key $key doesn't exist in the form definition", $renderables);
-		throw new \RuntimeException("Key $key doesn't exist in the form definition");}
+		throw new \RuntimeException("Key $key doesn't exist in the form definition"); }
 		$rend = $renderables[$key];
-		$field=[];
+		$field = [];
 		if (!empty($rend['type'])) {
 			$field = [];
-			switch($rend['type']) {
+			switch ($rend['type']) {
 				case 'FormComponent':
 					if (isset($rend['items']))
 						$field['fields'] = $this->addItems($rend['items'], $renderables);
 				break;
 				case 'ClassComponent':
 					$classDefinition = isset($rend['definition']) ? $rend['definition'] : [];
-					if (count($rend['items'])>0) {
+					if (count($rend['items']) > 0) {
 						$field['fields'] = [];
 						$field['label'] = '';
 						if (isset($classDefinition['showLabel']) && $classDefinition['showLabel'])
@@ -217,7 +217,7 @@ 
 		$field['allowRemove'] = $allowChangeOfRepeats;
 
 		// now set the template header part
-		$field['template']['class'] =  "neon\\core\\form\\Form";
+		$field['template']['class'] = "neon\\core\\form\\Form";
 	}
 
 	/**
@@ -225,7 +225,7 @@ 
 	 * so we know what object it belongs to if set
 	 * @return array
 	 */
-	protected function createHiddenField($name, $value=null)
+	protected function createHiddenField($name, $value = null)
 	{
 		return [
 			'class' => "neon\\core\\form\\fields\\Hidden",
@@ -238,7 +238,7 @@ 
 	protected function createFieldName($field)
 	{
 		$uuid = isset($field['id']) ? $field['id'] : Hash::uuid64();
-		return str_replace(['-','_'],['a','Z'], $uuid);
+		return str_replace(['-', '_'], ['a', 'Z'], $uuid);
 	}
 
 }
\ No newline at end of file

Braces +29 added lines, -20 removed lines

@@ -26,8 +26,9 @@ 
 	public function getClassFormDefinition(array $fields=[])
 	{
 		// if there is no definition return an empty form
-		if (empty($this->definition))
-			return [];
+		if (empty($this->definition)) {
+					return [];
+		}
 
 		// TODO - NJ20180426 - see if we can get Phoebe to listen to $fields
 
@@ -55,8 +56,9 @@ 
 	 */
 	public function editClass($changes)
 	{
-		if (isset($changes['definition']))
-			$changes['definition'] = $this->prepareDefinition($changes['definition']);
+		if (isset($changes['definition'])) {
+					$changes['definition'] = $this->prepareDefinition($changes['definition']);
+		}
 		parent::editClass($changes);
 	}
 
@@ -84,8 +86,9 @@ 
 	{
 		$definition = $this->definition;
 		$applicationDataPhoebeUuids = [];
-		foreach ($ddsClassTypes as $ct)
-			$applicationDataPhoebeUuids[$ct] = null;
+		foreach ($ddsClassTypes as $ct) {
+					$applicationDataPhoebeUuids[$ct] = null;
+		}
 		foreach ($definition['renderables'] as $k=>$r) {
 			if ($r['type'] == 'ClassComponent' && in_array($r['class_type'], $ddsClassTypes)) {
 				$applicationDataPhoebeUuids[$r['class_type']] = $k;
@@ -125,8 +128,9 @@ 
 		$fields = $this->convertRenderablesToFields($definition['rootNode'], $definition['renderables']);
 		$form['fields'] = $fields['fields'];
 		// apply any overrides to the form
-		if ($this->_overrides)
-			$form = array_replace_recursive($form, $this->_overrides);
+		if ($this->_overrides) {
+					$form = array_replace_recursive($form, $this->_overrides);
+		}
 		return $form;
 	}
 
@@ -140,23 +144,27 @@ 
 			$field = [];
 			switch($rend['type']) {
 				case 'FormComponent':
-					if (isset($rend['items']))
-						$field['fields'] = $this->addItems($rend['items'], $renderables);
+					if (isset($rend['items'])) {
+											$field['fields'] = $this->addItems($rend['items'], $renderables);
+					}
 				break;
 				case 'ClassComponent':
 					$classDefinition = isset($rend['definition']) ? $rend['definition'] : [];
 					if (count($rend['items'])>0) {
 						$field['fields'] = [];
 						$field['label'] = '';
-						if (isset($classDefinition['showLabel']) && $classDefinition['showLabel'])
-							$field['label'] = isset($classDefinition['label']) ? $classDefinition['label'] : $rend['label'];
+						if (isset($classDefinition['showLabel']) && $classDefinition['showLabel']) {
+													$field['label'] = isset($classDefinition['label']) ? $classDefinition['label'] : $rend['label'];
+						}
 						$field['description'] = '';
-						if (isset($classDefinition['showDescription']) && $classDefinition['showDescription'])
-							$field['description'] = isset($classDefinition['description']) ? $classDefinition['description'] : $rend['description'];
+						if (isset($classDefinition['showDescription']) && $classDefinition['showDescription']) {
+													$field['description'] = isset($classDefinition['description']) ? $classDefinition['description'] : $rend['description'];
+						}
 						if ($this->isRepeater($rend)) {
 							$this->addRepeaterHeader($field, $rend['definition'], $key);
-							if (isset($classDefinition['showLabel']) && $classDefinition['showLabel'])
-								$field['template']['label'] = isset($classDefinition['label']) ? $classDefinition['label'] : $rend['label'];
+							if (isset($classDefinition['showLabel']) && $classDefinition['showLabel']) {
+															$field['template']['label'] = isset($classDefinition['label']) ? $classDefinition['label'] : $rend['label'];
+							}
 							$field['template']['fields'] = $this->addItems($rend['items'], $renderables);
 							$field['template']['fields'][] = $this->createHiddenField('_renderable', $key);
 							$field['template']['fields'][] = $this->createHiddenField('_classType', $rend['class_type']);
@@ -191,10 +199,11 @@ 
 		$order = 1;
 		foreach ($items as $rKey) {
 			$subField = $this->convertRenderablesToFields($rKey, $renderables, 1);
-			if (isset($subField[$rKey]))
-				$field[$rKey] = $subField[$rKey];
-			else
-				$field[$rKey] = $subField;
+			if (isset($subField[$rKey])) {
+							$field[$rKey] = $subField[$rKey];
+			} else {
+							$field[$rKey] = $subField;
+			}
 			$field[$rKey]['order'] = $order++;
 		}
 		return $field;

neon/phoebe/services/adapters/appforms/PhoebeType.php

Spacing +2 added lines, -2 removed lines

@@ -18,7 +18,7 @@ 
 {
 	use PhoebeTrait;
 
-	public function __construct($config=[])
+	public function __construct($config = [])
 	{
 		$path = '\neon\phoebe\services\adapters\appforms';
 		$config['phoebeType'] = 'applicationForm';
@@ -28,7 +28,7 @@ 
 		parent::__construct($config);
 	}
 
-	public function getClass($classType, $version=null, $classOverrideCriteria=[])
+	public function getClass($classType, $version = null, $classOverrideCriteria = [])
 	{
 		$class = parent::getClass($classType, $version, $classOverrideCriteria);
 		// update member definitions with the latest from the database and

Braces +6 added lines, -4 removed lines

@@ -33,8 +33,9 @@ 
 		$class = parent::getClass($classType, $version, $classOverrideCriteria);
 		// update member definitions with the latest from the database and
 		// override again with the changes that were defined before
-		if ($class)
-			$class->definition = $this->updateDefinitionFromDds($class->definition);
+		if ($class) {
+					$class->definition = $this->updateDefinitionFromDds($class->definition);
+		}
 		return $class;
 	}
 
@@ -55,8 +56,9 @@ 
 	{
 		$object = parent::getObject($objectId);
 		// update the data from Daedalus if required
-		if ($object)
-			$object->updateFromDds();
+		if ($object) {
+					$object->updateFromDds();
+		}
 		return $object;
 	}
 

neon/phoebe/services/adapters/appforms/PhoebeTrait.php

Spacing +6 added lines, -6 removed lines

@@ -28,7 +28,7 @@ 
 	 * values can be changed if they were changed in the Daedalus definition
 	 * @param type $definition
 	 */
-	protected function updateDefinitionFromDds($definition, $includeAll=false)
+	protected function updateDefinitionFromDds($definition, $includeAll = false)
 	{
 		if (!empty($definition['renderables'])) {
 			$classes = $this->getDdsClassDefinitions($definition);
@@ -162,7 +162,7 @@ 
 				}
 			}
 		}
-		if (count($newClassTypes)>0) {
+		if (count($newClassTypes) > 0) {
 			$newClasses = $this->ddsPhoebe()->getClasses($newClassTypes);
 			foreach ($newClasses as $newClass) {
 				$requestedClasses[$newClass->class_type] = $newClass;
@@ -185,7 +185,7 @@ 
 					if (!isset($memberDefinition['definition'][$key]) || ($memberDefinition['definition'][$key] != $value))
 						$differences[$key] = $value;
 				}
-				$renderable['changes']=$differences;
+				$renderable['changes'] = $differences;
 			}
 		}
 	}
@@ -198,10 +198,10 @@ 
 	protected function sanitiseDefinition(&$definition)
 	{
 		/** Remove Orphaned Renderables **/
-		$items = [ $definition['rootNode'] ];
+		$items = [$definition['rootNode']];
 		foreach ($definition['renderables'] as $renderable) {
 			if (isset($renderable['items'])) {
-				$items = array_merge($items,$renderable['items']);
+				$items = array_merge($items, $renderable['items']);
 			}
 		}
 		// remove renderables not linked via rootNode
@@ -228,7 +228,7 @@ 
 			$uuid64s[] = Hash::uuid2uuid64($key);
 		}
 		$serialised = str_replace($keys, $uuid64s, $serialised);
-		$definition = json_decode($serialised,true);
+		$definition = json_decode($serialised, true);
 	}
 
 	private function ddsPhoebe()

Braces +18 added lines, -12 removed lines

@@ -54,8 +54,9 @@ 
 	 */
 	protected function replaceDefinitionFromDds($definition)
 	{
-		if (empty($definition))
-			return [];
+		if (empty($definition)) {
+					return [];
+		}
 
 		$classes = $this->getDdsClassDefinitions($definition);
 		foreach ($definition['renderables'] as &$renderable) {
@@ -100,8 +101,9 @@ 
 				$parentClassId = null;
 				if (isset($r['parentClassId'])) {
 					$parentClassId = $r['parentClassId'];
-					if (!in_array($r['parentClassId'], $renderableKeys))
-						$parentClassId = $this->findParentClassIdFromType($r['parentClassId'], $definition['renderables']);
+					if (!in_array($r['parentClassId'], $renderableKeys)) {
+											$parentClassId = $this->findParentClassIdFromType($r['parentClassId'], $definition['renderables']);
+					}
 				}
 				$r['relations'] = [
 					[
@@ -117,8 +119,9 @@ 
 	protected function findParentClassIdFromType($type, $renderables)
 	{
 		foreach ($renderables as $r) {
-			if ($this->isClass($r) && $r['class_type'] == $type)
-				return $r['id'];
+			if ($this->isClass($r) && $r['class_type'] == $type) {
+							return $r['id'];
+			}
 		}
 		// can't find it so return the original so as not to break anything
 		return $type;
@@ -169,8 +172,9 @@ 
 			}
 		}
 		$definitions = [];
-		foreach ($requiredClassTypes as $rct)
-			$definitions[$rct] = isset($requestedClasses[$rct]) ? $requestedClasses[$rct]->definition : null;
+		foreach ($requiredClassTypes as $rct) {
+					$definitions[$rct] = isset($requestedClasses[$rct]) ? $requestedClasses[$rct]->definition : null;
+		}
 		return $definitions;
 	}
 
@@ -182,8 +186,9 @@ 
 				$memberDefinition = $classes[$renderable['class_type']]['fields'][$renderable['member_ref']];
 				$differences = [];
 				foreach ($renderDefinition as $key=>$value) {
-					if (!isset($memberDefinition['definition'][$key]) || ($memberDefinition['definition'][$key] != $value))
-						$differences[$key] = $value;
+					if (!isset($memberDefinition['definition'][$key]) || ($memberDefinition['definition'][$key] != $value)) {
+											$differences[$key] = $value;
+					}
 				}
 				$renderable['changes']=$differences;
 			}
@@ -233,8 +238,9 @@ 
 
 	private function ddsPhoebe()
 	{
-		if (!$this->_ddsPhoebe)
-			$this->_ddsPhoebe = neon('phoebe')->getIPhoebeType('daedalus');
+		if (!$this->_ddsPhoebe) {
+					$this->_ddsPhoebe = neon('phoebe')->getIPhoebeType('daedalus');
+		}
 		return $this->_ddsPhoebe;
 	}
 	private $_ddsPhoebe = null;

neon/phoebe/services/adapters/common/PhoebeObjectBase.php

Spacing +4 added lines, -4 removed lines

@@ -121,7 +121,7 @@ 
 	/**
 	 * @inheritdoc
 	 */
-	public function setOverride($overrideUuid, $force=false)
+	public function setOverride($overrideUuid, $force = false)
 	{
 		// don't override an override unless forced to do so
 		if (!$force && $this->override_uuid)
@@ -150,7 +150,7 @@ 
 	/**
 	 * @inheritdoc
 	 */
-	public function listHistory(&$paginator=[])
+	public function listHistory(&$paginator = [])
 	{
 		// check the inputs
 		$paginator = $this->createPaginator($paginator);
@@ -158,7 +158,7 @@ 
 		$query = ObjectHistoryModel::find()
 			->where(['object_uuid' => $this->uuid]);
 
-		if ($paginator['start']==0)
+		if ($paginator['start'] == 0)
 			$paginator['total'] = $query->count();
 
 		// and get the results
@@ -237,7 +237,7 @@ 
 		$hmodel->override_uuid = $this->override_uuid;
 		$hmodel->serialised_data = $this->serialised_data;
 		if (!$hmodel->save())
-			throw new \RuntimeException("Failed to save the history of the object. Model errors were ".print_r($hmodel->errors,true));
+			throw new \RuntimeException("Failed to save the history of the object. Model errors were ".print_r($hmodel->errors, true));
 	}
 
 }
\ No newline at end of file

Braces +21 added lines, -14 removed lines

@@ -42,15 +42,17 @@ 
 		// NOTE - changes are only saved into $this->data and not
 		// to the phoebe object in general.
 
-		if (empty($changes) || $changes == $this->data)
-			return true;
+		if (empty($changes) || $changes == $this->data) {
+					return true;
+		}
 
 		// Get the associated class object
 		$classType = $this->getClassType();
 		$class = $this->getClassModel($classType);
 
-		if (!$class)
-			throw new \RuntimeException("Class of type '$classType' not found. Can't save objects of unknown types");
+		if (!$class) {
+					throw new \RuntimeException("Class of type '$classType' not found. Can't save objects of unknown types");
+		}
 
 		// save the history object
 		if ($class->object_history) {
@@ -58,15 +60,17 @@ 
 		}
 
 		// update the version if the class is not version locked
-		if (!$class->version_locked)
-			$this->version = $class->version;
+		if (!$class->version_locked) {
+					$this->version = $class->version;
+		}
 
 		// merge the changes and save the model
 		$this->data = $changes;
 		$this->updated = date('Y-m-d H:i:s');
 		$model = $this->getModel();
-		if (!$model->save())
-			return $model->errors;
+		if (!$model->save()) {
+					return $model->errors;
+		}
 		return true;
 	}
 
@@ -124,8 +128,9 @@ 
 	public function setOverride($overrideUuid, $force=false)
 	{
 		// don't override an override unless forced to do so
-		if (!$force && $this->override_uuid)
-			return false;
+		if (!$force && $this->override_uuid) {
+					return false;
+		}
 
 		// Get the associated class object and check the override applies to this class
 		if ($this->getClassOverrideModel($overrideUuid, $this->version)) {
@@ -158,8 +163,9 @@ 
 		$query = ObjectHistoryModel::find()
 			->where(['object_uuid' => $this->uuid]);
 
-		if ($paginator['start']==0)
-			$paginator['total'] = $query->count();
+		if ($paginator['start']==0) {
+					$paginator['total'] = $query->count();
+		}
 
 		// and get the results
 		return $query->offset($paginator['start'])
@@ -236,8 +242,9 @@ 
 		$hmodel->version = $this->version;
 		$hmodel->override_uuid = $this->override_uuid;
 		$hmodel->serialised_data = $this->serialised_data;
-		if (!$hmodel->save())
-			throw new \RuntimeException("Failed to save the history of the object. Model errors were ".print_r($hmodel->errors,true));
+		if (!$hmodel->save()) {
+					throw new \RuntimeException("Failed to save the history of the object. Model errors were ".print_r($hmodel->errors,true));
+		}
 	}
 
 }
\ No newline at end of file

neon/phoebe/services/adapters/common/models/PhoebeObject.php

Braces +17 added lines, -12 removed lines

@@ -70,10 +70,11 @@ 
 	public function beforeSave($insert)
 	{
 		// data can only be an array and are stored as JSON
-		if (is_array($this->data) && count($this->data))
-			$this->serialised_data = json_encode($this->data);
-		else
-			$this->serialised_data = null;
+		if (is_array($this->data) && count($this->data)) {
+					$this->serialised_data = json_encode($this->data);
+		} else {
+					$this->serialised_data = null;
+		}
 		return parent::beforeSave($insert);
 	}
 
@@ -83,8 +84,9 @@ 
 	public function afterFind()
 	{
 		// return data as decoded json or null
-		if (is_string($this->serialised_data))
-			$this->data = json_decode($this->serialised_data, true);
+		if (is_string($this->serialised_data)) {
+					$this->data = json_decode($this->serialised_data, true);
+		}
 		parent::afterFind();
 	}
 
@@ -101,14 +103,17 @@ 
 		}
 		$query = PhoebeObject::find()->select(['phoebe_object.uuid', 'phoebe_class.label'])
 			->leftJoin('phoebe_class', 'phoebe_class.phoebe_type=phoebe_object.phoebe_type AND phoebe_class.class_type=phoebe_object.class_type');
-		if (!empty($query))
-			$query->where(['like', 'phoebe_class.label', $query]);
-		if (count($filters))
-			$query->andWhere($filters);
+		if (!empty($query)) {
+					$query->where(['like', 'phoebe_class.label', $query]);
+		}
+		if (count($filters)) {
+					$query->andWhere($filters);
+		}
 		$objects = $query->orderBy('phoebe_class.label')->asArray()->all();
 		$results = [];
-		foreach ($objects as $object)
-			$results[$object['uuid']] = "$object[label]: $object[uuid]";
+		foreach ($objects as $object) {
+					$results[$object['uuid']] = "$object[label]: $object[uuid]";
+		}
 		return $results;
 	}
 }

neon/phoebe/services/adapters/common/models/PhoebeClassOverrides.php

Spacing +1 added lines, -1 removed lines

@@ -121,7 +121,7 @@
 	/**
 	 * @inheritdoc
 	 */
-	public function toArray(array $fields=[], array $expand=[], $recursive=true)
+	public function toArray(array $fields = [], array $expand = [], $recursive = true)
 	{
 		$data = parent::toArray($fields, $expand, $recursive);
 		unset($data['serialised_overrides']);

Braces +6 added lines, -5 removed lines

@@ -99,9 +99,9 @@ 
 	{
 		// active_from must be set
 		// overrides can only be an array and are stored as JSON or already JSON
-		if (is_array($this->overrides) && count($this->overrides))
-			$this->serialised_overrides = json_encode($this->overrides);
-		else {
+		if (is_array($this->overrides) && count($this->overrides)) {
+					$this->serialised_overrides = json_encode($this->overrides);
+		} else {
 			$this->serialised_overrides = null;
 		}
 		return parent::beforeSave($insert);
@@ -113,8 +113,9 @@ 
 	public function afterFind()
 	{
 		// return overrides as decoded json or null
-		if (is_string($this->serialised_overrides))
-			$this->overrides = json_decode($this->serialised_overrides, true);
+		if (is_string($this->serialised_overrides)) {
+					$this->overrides = json_decode($this->serialised_overrides, true);
+		}
 		parent::afterFind();
 	}
 

neon/phoebe/services/adapters/common/models/PhoebeClass.php

Spacing +1 added lines, -1 removed lines

@@ -103,7 +103,7 @@
 		parent::afterFind();
 	}
 
-	public function toArray(array $fields=[], array $expand=[], $recursive=true)
+	public function toArray(array $fields = [], array $expand = [], $recursive = true)
 	{
 		$data = parent::toArray($fields, $expand, $recursive);
 		unset($data['serialised_definition']);

Braces +15 added lines, -11 removed lines

@@ -84,9 +84,9 @@ 
 	public function beforeSave($insert)
 	{
 		// definition can only be an array and are stored as JSON or already JSON
-		if (is_array($this->definition) && count($this->definition))
-			$this->serialised_definition = json_encode($this->definition);
-		else {
+		if (is_array($this->definition) && count($this->definition)) {
+					$this->serialised_definition = json_encode($this->definition);
+		} else {
 			$this->serialised_definition = null;
 		}
 		return parent::beforeSave($insert);
@@ -98,8 +98,9 @@ 
 	public function afterFind()
 	{
 		// return definition as decoded json or null
-		if (is_string($this->serialised_definition))
-			$this->definition = json_decode($this->serialised_definition, true);
+		if (is_string($this->serialised_definition)) {
+					$this->definition = json_decode($this->serialised_definition, true);
+		}
 		parent::afterFind();
 	}
 
@@ -120,14 +121,17 @@ 
 	public static function listClassTypes($query, $filters)
 	{
 		$query = PhoebeClass::find()->select(['class_type', 'label']);
-		if (!empty($query))
-			$query->where(['like', 'label', $query]);
-		if (count($filters))
-			$query->where($filters);
+		if (!empty($query)) {
+					$query->where(['like', 'label', $query]);
+		}
+		if (count($filters)) {
+					$query->where($filters);
+		}
 		$classes = $query->orderBy('label')->asArray()->all();
 		$results = [];
-		foreach ($classes as $class)
-			$results[$class['class_type']] = $class['label'];
+		foreach ($classes as $class) {
+					$results[$class['class_type']] = $class['label'];
+		}
 		return $results;
 	}
 }