HtmlRaw - Code Metrics - Inspection of "Merge branch 'releases' into develop" - newicon/neon - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — develop ( 319bd8...330c7a )

by Neill

created 2021-10-27 15:15 UTC

HtmlRaw A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	77
Duplicated Lines	0 %

Test Coverage

Coverage

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
eloc	20
c	2
b	0
f	0
dl	0
loc	77
ccs	0
cts	36
cp	0
rs	10
wmc	9

6 Methods

Rating	Name	Size	Complexity
A	getComponentDetails()	7	1
A	getValueDisplay()	6	2
A	processAsFilter()	5	3
A	getFilterField()	4	1
A	fake()	3	1
A	getValue()	3	1

<?php
/**
 * @link http://www.newicon.net/neon
 * @copyright Copyright (c) 2016 Newicon Ltd
 * @license http://www.newicon.net/neon/license
 */

namespace neon\core\form\fields;

use neon\core\grid\query\IQuery;

/**
 * Class Text
 * @package neon\core\form
 */
class HtmlRaw extends TextArea
{
	const TEXT_TRUNCATE_LENGTH=250;

	/**
	 * Set some allowable tags for single text fields
	 * @var string
	 */
	protected $allowableTags = "<br><em><i><u><b><s><mark><strong>";

	/**
	 * The DDS data type to store the value of the field
	 * text data type can be up to 20000 characters long
	 * @var string
	 */
	public $ddsDataType = 'text';

	/**
	 * @inheritdoc
	 */
	public function getValueDisplay($context='')
	{
		$text = parent::getValueDisplay();
		if (strlen($text) > self::TEXT_TRUNCATE_LENGTH)
			return substr($text, 0, self::TEXT_TRUNCATE_LENGTH).'...';
		return $text;
	}

	/**
	 * @inheritdoc
	 */
	public function getFilterField()
	{
		return [
			'class' => 'text'
		];
	}

	/**
	 * @inheritdoc
	 */
	public function processAsFilter(IQuery $query, $searchData=null)
	{
		$searchData = ($searchData === null) ? $this->getValue() : $searchData;
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
		if ($searchData !== '') {
			$query->where($this->getDataKey(), 'like', $searchData);
		}
	}

	/**
	 * @inheritdoc
	 */
	public function fake()
	{
		return faker()->realText(mt_rand(10, 20000));
	}

	/**
	 * @inheritdoc
	 */
	public function getComponentDetails()
	{
		return [
			'icon' => 'fa fa-paragraph',
			'group' => 'Formatted Text',
			'order' => 210,
			'label' => 'Raw Html',
		];
	}

	/**
	 * Because this is using raw html, we need to work with the unsanitised value
	 * @inheritdoc
	 */
	public function getValue()
	{
		return parent::getUnsafeValue();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
	}

}

1			<?php
2			/**
3			* @link http://www.newicon.net/neon
4			* @copyright Copyright (c) 2016 Newicon Ltd
5			* @license http://www.newicon.net/neon/license
6			*/
7
8			namespace neon\core\form\fields;
9
10			use neon\core\grid\query\IQuery;
11
12			/**
13			* Class Text
14			* @package neon\core\form
15			*/
16			class HtmlRaw extends TextArea
17			{
18			const TEXT_TRUNCATE_LENGTH=250;
19
20			/**
21			* Set some allowable tags for single text fields
22			* @var string
23			*/
24			protected $allowableTags = "<br><em><i><u><b><s><mark><strong>";
25
26			/**
27			* The DDS data type to store the value of the field
28			* text data type can be up to 20000 characters long
29			* @var string
30			*/
31			public $ddsDataType = 'text';
32
33			/**
34			* @inheritdoc
35			*/
36			public function getValueDisplay($context='')
37			{
38			$text = parent::getValueDisplay();
39			if (strlen($text) > self::TEXT_TRUNCATE_LENGTH)
40			return substr($text, 0, self::TEXT_TRUNCATE_LENGTH).'...';
41			return $text;
42			}
43
44			/**
45			* @inheritdoc
46			*/
47			public function getFilterField()
48			{
49			return [
50			'class' => 'text'
51			];
52			}
53
54			/**
55			* @inheritdoc
56			*/
57			public function processAsFilter(IQuery $query, $searchData=null)
58			{
59			$searchData = ($searchData === null) ? $this->getValue() : $searchData;
			0 ignored issues – show Bug introduced 2021-10-04 22:57 UTC by Report Bug Copy Issue Report Are you sure the usage of `$this->getValue()` targeting `neon\core\form\fields\HtmlRaw::getValue()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
60			if ($searchData !== '') {
61			$query->where($this->getDataKey(), 'like', $searchData);
62			}
63			}
64
65			/**
66			* @inheritdoc
67			*/
68			public function fake()
69			{
70			return faker()->realText(mt_rand(10, 20000));
71			}
72
73			/**
74			* @inheritdoc
75			*/
76			public function getComponentDetails()
77			{
78			return [
79			'icon' => 'fa fa-paragraph',
80			'group' => 'Formatted Text',
81			'order' => 210,
82			'label' => 'Raw Html',
83			];
84			}
85
86			/**
87			* Because this is using raw html, we need to work with the unsanitised value
88			* @inheritdoc
89			*/
90			public function getValue()
91			{
92			return parent::getUnsafeValue();
			0 ignored issues – show Bug introduced 2021-10-04 22:57 UTC by Report Bug Copy Issue Report Are you sure the usage of `parent::getUnsafeValue()` targeting `neon\core\form\fields\Field::getUnsafeValue()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
93			}
94
95			}

newicon / neon

Push — develop ( 319bd8...330c7a )

HtmlRaw A

Complexity

Size/Duplication

Test Coverage

Importance

6 Methods

Duplication Side-by-Side

Filter issues like