newicon / neon

neon/user/models/User.php

Braces +30 added lines, -20 removed lines

@@ -125,8 +125,9 @@ 
 	 */
 	public function getRoles()
 	{
-		if (!isset(static::$_userRoles[$this->id]))
-			static::$_userRoles[$this->id] = array_keys(neon()->authManager->getRolesByUser($this->id));
+		if (!isset(static::$_userRoles[$this->id])) {
+					static::$_userRoles[$this->id] = array_keys(neon()->authManager->getRolesByUser($this->id));
+		}
 		return is_array(static::$_userRoles[$this->id]) ? static::$_userRoles[$this->id] : [];
 	}
 
@@ -139,8 +140,9 @@ 
 		$authManager->revokeAll($this->id);
 		foreach ($roles as $role) {
 			$r = $authManager->getRole($role);
-			if ($r)
-				$authManager->assign($r, $this->id);
+			if ($r) {
+							$authManager->assign($r, $this->id);
+			}
 		}
 		unset(static::$_userRoles[$this->id]);
 	}
@@ -172,12 +174,14 @@ 
 
 		// searching in a specific role?
 		if (!empty($role)) {
-			if (isset($availableRoles[$role]['homeUrl']))
-				return $availableRoles[$role]['homeUrl'];
+			if (isset($availableRoles[$role]['homeUrl'])) {
+							return $availableRoles[$role]['homeUrl'];
+			}
 		} else { // or finding any one?
 			foreach ($userRoles as $role) {
-				if (isset($availableRoles[$role]['homeUrl']))
-					return $availableRoles[$role]['homeUrl'];
+				if (isset($availableRoles[$role]['homeUrl'])) {
+									return $availableRoles[$role]['homeUrl'];
+				}
 
 			}
 		}
@@ -204,8 +208,9 @@ 
 	public static function findIdentity($id)
 	{
 		// The id must be a uuid64
-		if (!Hash::isUuid64($id))
-			return null;
+		if (!Hash::isUuid64($id)) {
+					return null;
+		}
 		// The string conversion here is important to ensure the id is correctly quoted as a string
 		// otherwise if the $id is a number it will match uuid's that start with that number!
 		return self::findOne(['uuid' => (string) $id, 'status' => self::STATUS_ACTIVE]);
@@ -231,8 +236,9 @@ 
 	public static function findIdentityByInviteToken($token)
 	{
 		$invite = UserInvite::findInviteByInviteToken($token);
-		if (!$invite)
-			return null;
+		if (!$invite) {
+					return null;
+		}
 		return User::findOne(['uuid' => $invite->user_id, 'status' => [User::STATUS_PENDING]]);
 	}
 
@@ -362,10 +368,12 @@ 
 	public static function getUserListUncached($query='',$filters=[], $fields=[], $start=0, $length=100)
 	{
 		$q = self::find()->select(array_merge(['uuid', 'username', 'email'], $fields));
-		if ($q !== '')
-			$q->where(['or', ['like', 'username', $query], ['like', 'email', $query]]);
-		if (!empty($filters))
-			$q->andWhere($filters);
+		if ($q !== '') {
+					$q->where(['or', ['like', 'username', $query], ['like', 'email', $query]]);
+		}
+		if (!empty($filters)) {
+					$q->andWhere($filters);
+		}
 		$q->offset($start)
 			->limit($length)
 			->orderBy(['username' => SORT_ASC, 'email' => SORT_ASC])
@@ -383,8 +391,9 @@ 
 	public static function formatDataMapItems($userRows, $fields)
 	{
 		return collect($userRows)->mapWithKeys(function($row, $key) use($fields) {
-			if (empty($fields))
-				return [$row['uuid'] => $row['username'] ? $row['username'] . ' - ' . $row['email'] : $row['email']];
+			if (empty($fields)) {
+							return [$row['uuid'] => $row['username'] ? $row['username'] . ' - ' . $row['email'] : $row['email']];
+			}
 			return [$row['uuid'] => $row];
 		})->all();
 	}
@@ -538,8 +547,9 @@ 
 	{
 		// remove any caches and authorisations against the user
 		neon()->cacheArray->delete(static::CACHE_KEY_USER_LIST);
-		if ($this->id)
-			neon()->authManager->revokeAll($this->id);
+		if ($this->id) {
+					neon()->authManager->revokeAll($this->id);
+		}
 		return parent::beforeDelete();
 	}
 

neon/user/models/UserInvite.php

Braces +6 added lines, -3 removed lines

@@ -110,8 +110,9 @@ 
 	 */
 	public static function findInviteByInviteToken($token, $ignoreExpiry = false)
 	{
-		if (!$ignoreExpiry && self::hasInviteTokenExpired($token))
-			return null;
+		if (!$ignoreExpiry && self::hasInviteTokenExpired($token)) {
+					return null;
+		}
 		
 		return self::findOne(['token' => $token]);
 	}
@@ -154,7 +155,9 @@ 
 	public static function hasInviteTokenExpired($token)
 	{
 		$invite = self::getInvite($token);
-		if (!$invite) return false;
+		if (!$invite) {
+			return false;
+		}
 		return strtotime($invite->expires_at) <= time();
 	}
 

neon/user/grid/UserGrid.php

Braces +12 added lines, -8 removed lines

@@ -41,8 +41,9 @@ 
 		$this->addTextColumn('created_at');
 		$this->addTextColumn('updated_at', ['title'=>'Updated At']);
 		// action
-		if (neon()->user->isSuper())
-			$this->addTextColumn('impersonate')->setFilter(false);
+		if (neon()->user->isSuper()) {
+					$this->addTextColumn('impersonate')->setFilter(false);
+		}
 		// scopes
 		// $this->addScope('all','All');
 		$this->addScope('active','Active');
@@ -104,8 +105,9 @@ 
 		$userRoles = explode('|', $column->getCellData($model));
 		$displayRoles = [];
 		foreach ($userRoles as $ur) {
-			if (isset($roles[$ur]))
-				$displayRoles[] = $column->highlight($roles[$ur]['label'], $search);
+			if (isset($roles[$ur])) {
+							$displayRoles[] = $column->highlight($roles[$ur]['label'], $search);
+			}
 		}
 		return implode(', ', $displayRoles);
 	}
@@ -213,8 +215,9 @@ 
 		static $labels=null;
 		if (is_null($labels)) {
 			$roles = $this->getRoles();
-			foreach ($roles as $role => $details)
-				$labels[$details['label']] = $role;
+			foreach ($roles as $role => $details) {
+							$labels[$details['label']] = $role;
+			}
 		}
 		return $labels;
 	}
@@ -230,8 +233,9 @@ 
 		$labels = $this->getRoleLabels();
 		$roles = [];
 		foreach ($labels as $label => $role) {
-			if (stripos($label, $filter) !== false)
-				$roles[] = $role;
+			if (stripos($label, $filter) !== false) {
+							$roles[] = $role;
+			}
 		}
 		return $roles;
 	}

neon/user/services/apiTokenManager/JwtTokenAuth.php

Braces +9 added lines, -6 removed lines

@@ -56,8 +56,9 @@ 
 		// As there is no cookie or cookie string we return null allowing other authentication methods
 		// to attempt authentication
 		$tokenString = $this->getJwtStringFromCookie($request);
-		if ($tokenString === null)
-			return null;
+		if ($tokenString === null) {
+					return null;
+		}
 		// decode the cookie and perform csrf validation
 		// this only checks that the cookie data is good
 		$jwt = $this->decodeAndValidateJwtToken($tokenString, $request);
@@ -69,8 +70,9 @@ 
 		// @see self::findAndValidateUserIdentity()
 		// this is similar to the stock yii classes yii\filters\auth\HttpBearerAuth and yii\filters\auth\QueryParamAuth;
 		$identity = $user->loginByAccessToken($jwt, get_class($this));
-		if ($identity === null)
-			$this->handleFailure($response);
+		if ($identity === null) {
+					$this->handleFailure($response);
+		}
 
 		return $identity;
 	}
@@ -132,8 +134,9 @@ 
 	 */
 	public function getJwtStringFromCookie(Request $request)
 	{
-		if (!$request->cookies->has(static::$cookieName))
-			return null;
+		if (!$request->cookies->has(static::$cookieName)) {
+					return null;
+		}
 		$cookie = $request->cookies->get(static::$cookieName)->value;
 		return $cookie;
 	}

neon/user/services/apiTokenManager/models/UserApiToken.php

Braces +9 added lines, -6 removed lines

@@ -55,17 +55,20 @@
 	public static function getValidUserByToken($token)
 	{
 		$validToken = self::isValidToken($token);
-		if (!$validToken)
-			return null;
+		if (!$validToken) {
+					return null;
+		}
 
 		$apiToken = self::findOne(['active' => 1, 'token' => (string) $token]);
-		if ($apiToken == null)
-			return null;
+		if ($apiToken == null) {
+					return null;
+		}
 
 		// TODO: SO 27/10/2018 - update this to be User::findIndentity() - migrate to uuids.
 		$user = User::findOne(['id' => $apiToken->user_id, 'status' => User::STATUS_ACTIVE]);
-		if ($user == null)
-			return null;
+		if ($user == null) {
+					return null;
+		}
 
 		// Usage successful
 		$apiToken->touchTokenUsed();

neon/user/services/UserManager.php

Braces +21 added lines, -14 removed lines

@@ -29,8 +29,9 @@ 
 	{
 		$auth = neon()->authManager;
 		$authRole = $auth->createRole($role);
-		if ($authRole)
-			$auth->add($authRole);
+		if ($authRole) {
+					$auth->add($authRole);
+		}
 	}
 
 	/**
@@ -40,8 +41,9 @@ 
 	{
 		$auth = neon()->authManager;
 		$authRole = $auth->getRole($role);
-		if ($authRole)
-			$auth->remove($authRole);
+		if ($authRole) {
+					$auth->remove($authRole);
+		}
 	}
 
 	/**
@@ -70,8 +72,9 @@ 
 		$user->username = $username;
 		$user->email = $email;
 		$user->setPassword($password);
-		if ($superuser && neon()->user->isSuper())
-			$user->super = $superuser;
+		if ($superuser && neon()->user->isSuper()) {
+					$user->super = $superuser;
+		}
 		$user->generateAuthKey();
 		$success = $user->save();
 		if ($success) {
@@ -117,8 +120,9 @@ 
 			foreach ($newValues as $key=>$value) {
 				$user->$key = $value;
 			}
-			if (isset($changes['superuser']))
-				$user->__set_super($changes['superuser']);
+			if (isset($changes['superuser'])) {
+							$user->__set_super($changes['superuser']);
+			}
 			$success = $user->save();
 			return $success ? true : $user->errors;
 		}
@@ -132,8 +136,9 @@ 
 	public function destroyUser($uuid)
 	{
 		$user = $this->findUserModel($uuid);
-		if ($user)
-			$user->delete();
+		if ($user) {
+					$user->delete();
+		}
 	}
 
 
@@ -168,15 +173,17 @@ 
 			->offset($iterator->start)
 			->orderBy('username');
 
-		if ($where)
-			$query->where($where);
+		if ($where) {
+					$query->where($where);
+		}
 		
 		$userRows = $query->all();
 
 		// and return in required format
 		$users = [];
-		foreach ($userRows as $ur)
-			$users[$ur['uuid']] = $ur['username'];
+		foreach ($userRows as $ur) {
+					$users[$ur['uuid']] = $ur['username'];
+		}
 		return $users;
 	}
 

neon/user/services/User.php

Braces +6 added lines, -4 removed lines

@@ -107,8 +107,9 @@ 
 				$log = "User '$id' logged in from $ip. Session not enabled.";
 			}
 
-			if (neon()->getRequest()->enableCsrfValidation)
-				$this->regenerateCsrfToken();
+			if (neon()->getRequest()->enableCsrfValidation) {
+							$this->regenerateCsrfToken();
+			}
 
 			\Yii::info($log, __METHOD__);
 			$this->afterLogin($identity, false, $duration);
@@ -300,8 +301,9 @@ 
 		}
 
 		// use the default or application set one
-		if ($defaultUrl)
-			return parent::getReturnUrl( is_array($defaultUrl) ? $defaultUrl : [ $defaultUrl ] );
+		if ($defaultUrl) {
+					return parent::getReturnUrl( is_array($defaultUrl) ? $defaultUrl : [ $defaultUrl ] );
+		}
 
 		return parent::getReturnUrl();
 	}

neon/user/services/UserInvite.php

Braces +3 added lines, -2 removed lines

@@ -27,8 +27,9 @@
 				$fromName = setting('admin', 'fromEmailName', neon()->name);
 				$fromAddress = setting('admin', 'fromEmailAddress', 'system@'.neon()->request->getHostName());
 				
-				if (!$fromAddress)
-					throw new \Exception('The From Address needs to be set in the admin section for emails');
+				if (!$fromAddress) {
+									throw new \Exception('The From Address needs to be set in the admin section for emails');
+				}
 
 				$templates = [
 					'html' => '@neon/user/views/mail/userInviteToken-html',

neon/user/controllers/IndexController.php

Braces +8 added lines, -6 removed lines

@@ -103,12 +103,14 @@
 			if ($loggedInUser->isSuper()) {
 				if ($loggedInUser->getId() != $id) {
 					$user = $this->findModel($id);
-					if ($user->delete())
-						neon()->session->setFlash('success', 'The user has been successfully deleted');
-					else
-						neon()->session->setFlash('error', 'Something went wrong while trying to delete the user');
-				} else
-					neon()->session->setFlash('error', 'Sorry, you cannot delete yourself from the system.');
+					if ($user->delete()) {
+											neon()->session->setFlash('success', 'The user has been successfully deleted');
+					} else {
+											neon()->session->setFlash('error', 'Something went wrong while trying to delete the user');
+					}
+				} else {
+									neon()->session->setFlash('error', 'Sorry, you cannot delete yourself from the system.');
+				}
 				return $this->redirect(['/user/index/index']);
 			}
 			neon()->session->setFlash('error', 'You do not have permissions to delete the user');