newicon / neon

neon/daedalus/migrations/deprecatedMigrations/m160902_204642_dds_init.php

Spacing +2 added lines, -2 removed lines

@@ -15,7 +15,7 @@ 
 		$connection = \Yii::$app->getDb();
 
 		// create the various tables for dds
-		$sql=<<<EOQ
+		$sql = <<<EOQ
 -- --------------------------------------------------------
 
 --
@@ -142,7 +142,7 @@ 
 		$command = $connection->createCommand($sql);
 		$command->execute();
 
-		$sql=<<<EOQ
+		$sql = <<<EOQ
 --
 -- Dumping data for table `dds_storage`
 --

neon/daedalus/migrations/deprecatedMigrations/m161018_154331__dds_add_definition_to_class.php

Indentation +8 added lines, -8 removed lines

@@ -4,13 +4,13 @@
 
 class m161018_154331__dds_add_definition_to_class extends Migration
 {
-    public function safeUp()
-    {
-    	$this->addColumn('dds_class', 'definition', $this->text(10000) . " DEFAULT NULL COMMENT 'A definition for use by other modules, but not understood by DDS'");
-    }
+	public function safeUp()
+	{
+		$this->addColumn('dds_class', 'definition', $this->text(10000) . " DEFAULT NULL COMMENT 'A definition for use by other modules, but not understood by DDS'");
+	}
 
-    public function safeDown()
-    {
-    	$this->dropColumn('dds_class', 'definition');
-    }
+	public function safeDown()
+	{
+		$this->dropColumn('dds_class', 'definition');
+	}
 }

Spacing +1 added lines, -1 removed lines

@@ -6,7 +6,7 @@
 {
     public function safeUp()
     {
-    	$this->addColumn('dds_class', 'definition', $this->text(10000) . " DEFAULT NULL COMMENT 'A definition for use by other modules, but not understood by DDS'");
+    	$this->addColumn('dds_class', 'definition', $this->text(10000)." DEFAULT NULL COMMENT 'A definition for use by other modules, but not understood by DDS'");
     }
 
     public function safeDown()

neon/daedalus/App.php

Spacing +3 added lines, -3 removed lines

@@ -149,7 +149,7 @@ 
 	 * @param string $module  which module this is for - e.g. dds or phoebe
 	 * @return \neon\daedalus\interfaces\IDdsAppMigrator
 	 */
-	public function getIDdsAppMigrator($module='dds') {
+	public function getIDdsAppMigrator($module = 'dds') {
 		$factory = $this->get('DdsAppMigratorFactory');
 		return $factory::createMigrator("@system/$module/migrations");
 	}
@@ -197,7 +197,7 @@ 
 	/**
 	 * @inheritdoc
 	 */
-	public function getDataMap($key, $query='', $filters = [], $fields = [], $start = 0, $length = 100)
+	public function getDataMap($key, $query = '', $filters = [], $fields = [], $start = 0, $length = 100)
 	{
 		if (is_string($query)) {
 			$filters['_map_field_'] = $query;
@@ -209,7 +209,7 @@ 
 	/**
 	 * @inheritdoc
 	 */
-	public function makeMapLookupRequest($key, $ids, $fields=[])
+	public function makeMapLookupRequest($key, $ids, $fields = [])
 	{
 		return $this->IDdsObjectMapManagement->makeMapLookupRequest($ids, $fields, $key);
 	}

neon/settings/interfaces/ISettingsManager.php

Spacing +3 added lines, -3 removed lines

@@ -24,7 +24,7 @@ 
 	 * @param boolean $refresh whther to refresh the cache before fetching this setting defaults to false
 	 * @return string
 	 */
-	public function get($app, $key, $default=null, $refresh=false);
+	public function get($app, $key, $default = null, $refresh = false);
 
 	/**
 	 * Set a setting value
@@ -44,7 +44,7 @@ 
 	 * @param boolean $refresh if true forces reftech fo the the settings
 	 * @return array in the format @see self::$_settings
 	 */
-	public function getSettings($refresh=false);
+	public function getSettings($refresh = false);
 
 	/**
 	 * Load the settings from the database and cache for the session
@@ -52,6 +52,6 @@ 
 	 * @param boolean $refresh if true forces refresh values from the database
 	 * @return array in the format @see self::$_settings
 	 */
-	public function getAll($refresh=false);
+	public function getAll($refresh = false);
 
 }

neon/settings/controllers/IndexController.php

Braces +3 added lines, -2 removed lines

@@ -15,8 +15,9 @@
 	{
 		$form = new \neon\settings\forms\AppSettings('setting');
 		$form->registerScripts($this->getView());
-		if (neon()->request->isAjax)
-			return $form->ajaxValidation();
+		if (neon()->request->isAjax) {
+					return $form->ajaxValidation();
+		}
 		$form->process();
 		return $this->render('index', [
 			'form' => $form,

neon/settings/forms/AppSettings.php

Spacing +1 added lines, -1 removed lines

@@ -81,7 +81,7 @@
 	public function loadFields()
 	{
 		$settings = neon()->settings->getAppSettings();
-		foreach($settings as $app => $config) {
+		foreach ($settings as $app => $config) {
 			if (is_array($config)) {
 				$this->addSubForm($app)->setFields($config)->setLabel(neon($app)->name);
 			}

Indentation +11 added lines, -11 removed lines

@@ -35,16 +35,16 @@ 
 	/**
 	 *
 	 */
-    public function process()
-    {
-	    if ($this->shouldProcess()) {
-		    $this->load();
-		    $this->validate();
-		    if ($this->hasError()) {
-			    neon()->session->setFlash('error', 'The form has errors.');
-		    } else {
-			    $this->saveToSettings();
-			    neon()->session->setFlash('success', 'Settings have been successfully saved.');
+	public function process()
+	{
+		if ($this->shouldProcess()) {
+			$this->load();
+			$this->validate();
+			if ($this->hasError()) {
+				neon()->session->setFlash('error', 'The form has errors.');
+			} else {
+				$this->saveToSettings();
+				neon()->session->setFlash('success', 'Settings have been successfully saved.');
 			}
 		} else {
 			$this->loadFieldValuesFromSettings();
@@ -66,7 +66,7 @@ 
 			foreach ($appSettings as $key => $value) {
 				// if the fields value is valid then save it
 				if ($appForm->getField($key)->validate()) {
-				    $saved = $this->getSettingsManager()->set($appKey, $key, $value);
+					$saved = $this->getSettingsManager()->set($appKey, $key, $value);
 				}
 			}   
 		}

neon/settings/migrations/m181127_165817_settings_update_settings_to_json.php

Braces +3 added lines, -2 removed lines

@@ -15,8 +15,9 @@
 		$success = true;
 		foreach ($settings as $setting) {
 			try {
-				if ($setting->value != null)
-					$setting->value = $this->_decode($setting->value);
+				if ($setting->value != null) {
+									$setting->value = $this->_decode($setting->value);
+				}
 			} catch (\Exception $e) {
 				dp("Error while decoding setting from json: {$setting->app} {$setting->key} {$setting->value}. Error is ".$e->getMessage());
 				dp('Trying to save it back as Json');

neon/settings/App.php

Indentation +2 added lines, -2 removed lines

@@ -22,8 +22,8 @@
 
 	/**
 	 * Get all registered settings for each neon app
-     * ??? This should be in the settings manager ???
-     *
+	 * ??? This should be in the settings manager ???
+	 *
 	 * @return array
 	 */
 	public function getAppSettings()

Spacing +4 added lines, -4 removed lines

@@ -29,7 +29,7 @@ 
 	public function getAppSettings()
 	{
 		$ret = [];
-		foreach(neon()->getActiveApps() as $key => $app) {
+		foreach (neon()->getActiveApps() as $key => $app) {
 			if (!empty($app->getSettings())) {
 				$ret[$key] = $app->getSettings();
 			}
@@ -185,16 +185,16 @@ 
 
 	private function _itemLineDatetime($dateFormat, $exampleDate)
 	{
-		return neon()->formatter->asDatetime($exampleDate, $dateFormat) . "  -  $dateFormat";
+		return neon()->formatter->asDatetime($exampleDate, $dateFormat)."  -  $dateFormat";
 	}
 
 	private function _itemLine($dateFormat, $exampleDate)
 	{
-		return neon()->formatter->asDate($exampleDate, $dateFormat) . "  -  $dateFormat";
+		return neon()->formatter->asDate($exampleDate, $dateFormat)."  -  $dateFormat";
 	}
 
 	private function _itemLineTime($dateFormat, $exampleDate)
 	{
-		return neon()->formatter->asTime($exampleDate, $dateFormat) . "  -  $dateFormat";
+		return neon()->formatter->asTime($exampleDate, $dateFormat)."  -  $dateFormat";
 	}
 }

neon/install/forms/InstallDatabase.php

Spacing +9 added lines, -9 removed lines

@@ -6,7 +6,7 @@ 
 
 class InstallDatabase extends \yii\base\Model
 {
-	public $name='';
+	public $name = '';
 	public $username;
 	public $password;
 	public $host = 'localhost';
@@ -54,21 +54,21 @@ 
 		} else {
 			if ($result == InstallHelper::ERROR_DB_UNKNOWN_DATABASE) {
 				// Attempt to create the database (if asked to do so)
-				if ($this->create_database == 1 ) {
-					if (! $this->createDatabase($exception)) {
+				if ($this->create_database == 1) {
+					if (!$this->createDatabase($exception)) {
 						$this->error_message = 'cant_create_database';
-						$this->addError('name', 'Failed to create database "' . $this->name . '" Database error: ' . $exception);
+						$this->addError('name', 'Failed to create database "'.$this->name.'" Database error: '.$exception);
 					}
-				}  else {
+				} else {
 					// This is useful information - but not an error therefore in
-					if (! $this->isAjaxValidating) {
+					if (!$this->isAjaxValidating) {
 						$this->error_message = 'unknown_database';
-						$this->addError('name', 'Unknown database name "' . $this->name . '"');
+						$this->addError('name', 'Unknown database name "'.$this->name.'"');
 					}
 				}
 			} else if ($result == InstallHelper::ERROR_DB_UNKNOWN_HOST) {
 				$this->error_message = 'unknown_host';
-				$this->addError('host', 'Unknown host name "' . $this->host . '"');
+				$this->addError('host', 'Unknown host name "'.$this->host.'"');
 			} else if ($result == InstallHelper::ERROR_DB_ACCESS_DENIED) {
 				$this->error_message = 'access_denied';
 				$this->addError('username', 'The username either does not exist or does not work with the given password');
@@ -92,7 +92,7 @@ 
 			$config['dsn'] = 'mysql:host='.$this->host.';';
 			$connection = new \neon\core\db\Connection($config);
 			try {
-				$connection->createCommand('CREATE DATABASE ' . $this->name)->execute();
+				$connection->createCommand('CREATE DATABASE '.$this->name)->execute();
 			} catch (\yii\db\Exception $e) {
 				// could not create the database
 				$exception = $e->getMessage();

Braces +1 added lines, -1 removed lines

@@ -59,7 +59,7 @@
 						$this->error_message = 'cant_create_database';
 						$this->addError('name', 'Failed to create database "' . $this->name . '" Database error: ' . $exception);
 					}
-				}  else {
+				} else {
 					// This is useful information - but not an error therefore in
 					if (! $this->isAjaxValidating) {
 						$this->error_message = 'unknown_database';