ImageManager::imageCrop() - Code Metrics - Inspection of "Merged releases into develop" - newicon/neon - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — develop ( ff58ad...b8f9b2 )

by steve

created 2021-07-14 12:20 UTC

ImageManager::imageCrop() B

↳ Parent: ImageManager

Complexity

Conditions	8
Paths	9

Size

Total Lines	25
Code Lines	19

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	72

Importance

Changes

Metric	Value
cc	8
eloc	19
nc	9
nop	2
dl	0
loc	25
ccs	0
cts	17
cp	0
crap	72
rs	8.4444
c	0
b	0
f	0

<?php
/**
 * @link http://www.newicon.net/neon
 * @copyright Copyright (c) 2017 Newicon Ltd
 * @license http://www.newicon.net/neon/license/
 * @author Steve O'Brien <[email protected]> 06/05/2017
 * @package neon
 */

namespace neon\firefly\services;

use \Intervention\Image\ImageManager as InterventionImageManager;
use \Intervention\Image\Exception\NotReadableException;
use \Intervention\Image\Image as Image;
use \neon\core\helpers\Arr;
use neon\core\helpers\Hash;
use yii\web\HttpException;

class ImageManager
{
	/**
	 *
	 * @param string $source - Source to create an image from. Can be one of the following:
	 * string - A firefly uuid
	 * string - Path of the image in filesystem.
	 * string - URL of an image (allow_url_fopen must be enabled).
	 * string - Binary image data.
	 * string - Data-URL encoded image data.
	 * string - Base64 encoded image data.
	 * resource - PHP resource of type gd. (when using GD driver)
	 * object - Imagick instance (when using Imagick driver)
	 * object - Intervention\Image\Image instance
	 * object - SplFileInfo instance (To handle file uploads via Symfony\Component\HttpFoundation\File\UploadedFile)
	 * @throws HttpException if $image is a firefly uuid and is not found
	 * @return mixed
	 */
	public function process($source, $params)
	{
		// get firefly image if the source is a firefly id
		if (Hash::isUuid64($source)) {
			if (!neon()->firefly->fileManager->exists($source))
				throw new HttpException(404);
			$meta = neon()->firefly->fileManager->getMeta($source);
			if ($meta['mime_type'] == 'image/svg')
				return neon()->firefly->fileManager->read($source);
			$source = neon()->firefly->fileManager->readStream($source);
		}
		$manager = new InterventionImageManager();
		$image = $manager->make($source);
		$this->processImage($image, $params);
		return $image->response(null, Arr::get($params, 'q', 90));
	}

	/**
	 * Process the image based on passed in params
	 * @param Image $image
	 * @param array $params - url params passed (array format)
	 */
	public function processImage(Image & $image, $params)
	{
		$image->interlace();
		$this->imageResize($image, $params);
		$this->imageRotate($image, $params);
		$this->imageFlip($image, $params);
		$this->imageFilter($image, $params);
		$this->imageCrop($image, $params);
	}

	/**
	 * Process the image resize based on passed $params (w,h,fit | width,height)
	 * @param Image $image - The Intervention image object
	 * @param array $params - url params passed (array format)
	 */
	public function imageResize(Image & $image, $params)
	{
		// Get url params
		$width = Arr::get($params, 'w', Arr::get($params, 'width', null));
		$height = Arr::get($params, 'h', Arr::get($params, 'height', null));
		list($width, $height) = $this->resolveMissingDimensions($image, $width, $height);
		$pd = (double) Arr::get($params, 'pd', 1);

		if (Arr::get($params, 'fit', false)) {
			// add callback functionality to retain maximal original image size
			$image->fit($width, $height, function ($constraint) {
				$constraint->aspectRatio();
				$constraint->upsize();
			}, $params['fit']);
		} elseif ($width || $height) {
			$width = $width * $pd;
			$height = $height * $pd;
			$image->resize($width, $height, function ($constraint) {
				$constraint->aspectRatio();
				$constraint->upsize();
			});
		}
	}
	
	/**
	 * Rotate the image if params contains rotate
	 * @param Image $image - The Intervention image object
	 * @param array $params - url params passed (array format)
	 */
	public function imageRotate(Image & $image, $params)
	{
		$rotate = Arr::get($params, 'rotate', false);
		if ($rotate) $image->rotate($rotate);
	}

	/**
	 * Flip the image if params contains flip info (flip=v)
	 * @param Image $image - The Intervention image object
	 * @param array $params - url params passed (array format)
	 */
	public function imageFlip(Image & $image, $params)
	{
		$flip = Arr::get($params, 'flip', false);
		if ($flip !== false) {
			// flip horizontal
			if ($flip === 'v') {
				$image->flip('v');
			} else {
				// by default it will flip horizontally
				$image->flip('h');
			}
		}
	}

	/**
	 * Apply filters to the image if params contains filter info (flip=v)
	 * @param Image $image - The Intervention image object
	 * @param array $params - url params passed (array format)
	 */
	public function imageFilter(Image & $image, $params)
	{
		$filter = Arr::get($params, 'filter', false);
		if ($filter) {
			$filters = explode(',',$filter);
			if (in_array('greyscale', $filters, true)) {
				$image->greyscale();
			}
			if (in_array('sepia', $filters, true)) {
				$this->runSepiaFilter($image);
			}
			if (in_array('invert', $filters, true)) {
				$image->invert();
			}
		}
	}

	/**
	 * Apply crop to the image if params contains crop params info
	 * @param Image $image - The Intervention image object
	 * @param array $params - url params passed (array format)
	 */
	public function imageCrop(Image & $image, $params)
	{
		$crop = Arr::get($params, 'crop', false);
		if ($crop !== false) {
			if (is_string($crop)) {
				$bits = explode(',', $crop);
				$w = Arr::get($bits, 0, null);
				$h = Arr::get($bits, 1, null);
				$x = Arr::get($bits, 2, null);
				$y = Arr::get($bits, 3, null);
			}
			if (is_array($crop)) {
				$w = Arr::get($crop, 'width', null);
				$h = Arr::get($crop, 'height', null);
				$x = Arr::get($crop, 'x', null);
				$y = Arr::get($crop, 'y', null);
			}
			if ($w == 0 && $h == 0 && $x == 0 && $y ==0) {

				return $image;
			}
			$image->crop($w, $h, $x, $y);
			$manager = new InterventionImageManager();
			$bg = $manager->canvas($w, $h, array(255, 255, 255, 0));
			// Fill up the blank spaces with transparent color
			$image = $bg->insert($image, 'center');
		}
	}

	/**
	 * Resolve missing image dimensions.
	 * @param  Image        $image  The source image.
	 * @param  integer|null $width  The image width.
	 * @param  integer|null $height The image height.
	 * @return integer[]    The resolved width and height.
	 */
	public function resolveMissingDimensions(Image & $image, $width, $height)
	{
		if (is_null($width) and is_null($height)) {
			$width = $image->width();
			$height = $image->height();
		}

		if (is_null($width)) {
			$width = $height * ($image->width() / $image->height());
		}

		if (is_null($height)) {
			$height = $width / ($image->width() / $image->height());
		}

		return [
			(int) $width,
			(int) $height,
		];
	}

	/**
	 * Perform sepia manipulation.
	 * @param  Image $image The source image.
	 * @return Image The manipulated image.
	 */
	public function runSepiaFilter(Image & $image)
	{
		$image->greyscale();
		$image->brightness(-10);
		$image->contrast(10);
		$image->colorize(38, 27, 12);
		$image->brightness(-10);
		$image->contrast(10);
		return $image;
	}

	/**
	 * @return string
	 */
	public function getPlaceholderImageContents()
	{
		// should be configurable by settings somewhere
		return file_get_contents(dirname(__DIR__).'/assets/placeholder.jpg');
	}

	public function getNotReadableImageContents()
	{
		// should be configurable by settings somewhere
		return file_get_contents(dirname(__DIR__).'/assets/placeholder-broken.png');
	}
}


1			<?php
2			/**
3			* @link http://www.newicon.net/neon
4			* @copyright Copyright (c) 2017 Newicon Ltd
5			* @license http://www.newicon.net/neon/license/
6			* @author Steve O'Brien <[email protected]> 06/05/2017
7			* @package neon
8			*/
9
10			namespace neon\firefly\services;
11
12			use \Intervention\Image\ImageManager as InterventionImageManager;
13			use \Intervention\Image\Exception\NotReadableException;
14			use \Intervention\Image\Image as Image;
15			use \neon\core\helpers\Arr;
16			use neon\core\helpers\Hash;
17			use yii\web\HttpException;
18
19			class ImageManager
20			{
21			/**
22			*
23			* @param string $source - Source to create an image from. Can be one of the following:
24			* string - A firefly uuid
25			* string - Path of the image in filesystem.
26			* string - URL of an image (allow_url_fopen must be enabled).
27			* string - Binary image data.
28			* string - Data-URL encoded image data.
29			* string - Base64 encoded image data.
30			* resource - PHP resource of type gd. (when using GD driver)
31			* object - Imagick instance (when using Imagick driver)
32			* object - Intervention\Image\Image instance
33			* object - SplFileInfo instance (To handle file uploads via Symfony\Component\HttpFoundation\File\UploadedFile)
34			* @throws HttpException if $image is a firefly uuid and is not found
35			* @return mixed
36			*/
37			public function process($source, $params)
38			{
39			// get firefly image if the source is a firefly id
40			if (Hash::isUuid64($source)) {
41			if (!neon()->firefly->fileManager->exists($source))
42			throw new HttpException(404);
43			$meta = neon()->firefly->fileManager->getMeta($source);
44			if ($meta['mime_type'] == 'image/svg')
45			return neon()->firefly->fileManager->read($source);
46			$source = neon()->firefly->fileManager->readStream($source);
47			}
48			$manager = new InterventionImageManager();
49			$image = $manager->make($source);
50			$this->processImage($image, $params);
51			return $image->response(null, Arr::get($params, 'q', 90));
52			}
53
54			/**
55			* Process the image based on passed in params
56			* @param Image $image
57			* @param array $params - url params passed (array format)
58			*/
59			public function processImage(Image & $image, $params)
60			{
61			$image->interlace();
62			$this->imageResize($image, $params);
63			$this->imageRotate($image, $params);
64			$this->imageFlip($image, $params);
65			$this->imageFilter($image, $params);
66			$this->imageCrop($image, $params);
67			}
68
69			/**
70			* Process the image resize based on passed $params (w,h,fit \| width,height)
71			* @param Image $image - The Intervention image object
72			* @param array $params - url params passed (array format)
73			*/
74			public function imageResize(Image & $image, $params)
75			{
76			// Get url params
77			$width = Arr::get($params, 'w', Arr::get($params, 'width', null));
78			$height = Arr::get($params, 'h', Arr::get($params, 'height', null));
79			list($width, $height) = $this->resolveMissingDimensions($image, $width, $height);
80			$pd = (double) Arr::get($params, 'pd', 1);
81
82			if (Arr::get($params, 'fit', false)) {
83			// add callback functionality to retain maximal original image size
84			$image->fit($width, $height, function ($constraint) {
85			$constraint->aspectRatio();
86			$constraint->upsize();
87			}, $params['fit']);
88			} elseif ($width \|\| $height) {
89			$width = $width * $pd;
90			$height = $height * $pd;
91			$image->resize($width, $height, function ($constraint) {
92			$constraint->aspectRatio();
93			$constraint->upsize();
94			});
95			}
96			}
97
98			/**
99			* Rotate the image if params contains rotate
100			* @param Image $image - The Intervention image object
101			* @param array $params - url params passed (array format)
102			*/
103			public function imageRotate(Image & $image, $params)
104			{
105			$rotate = Arr::get($params, 'rotate', false);
106			if ($rotate) $image->rotate($rotate);
107			}
108
109			/**
110			* Flip the image if params contains flip info (flip=v)
111			* @param Image $image - The Intervention image object
112			* @param array $params - url params passed (array format)
113			*/
114			public function imageFlip(Image & $image, $params)
115			{
116			$flip = Arr::get($params, 'flip', false);
117			if ($flip !== false) {
118			// flip horizontal
119			if ($flip === 'v') {
120			$image->flip('v');
121			} else {
122			// by default it will flip horizontally
123			$image->flip('h');
124			}
125			}
126			}
127
128			/**
129			* Apply filters to the image if params contains filter info (flip=v)
130			* @param Image $image - The Intervention image object
131			* @param array $params - url params passed (array format)
132			*/
133			public function imageFilter(Image & $image, $params)
134			{
135			$filter = Arr::get($params, 'filter', false);
136			if ($filter) {
137			$filters = explode(',',$filter);
138			if (in_array('greyscale', $filters, true)) {
139			$image->greyscale();
140			}
141			if (in_array('sepia', $filters, true)) {
142			$this->runSepiaFilter($image);
143			}
144			if (in_array('invert', $filters, true)) {
145			$image->invert();
146			}
147			}
148			}
149
150			/**
151			* Apply crop to the image if params contains crop params info
152			* @param Image $image - The Intervention image object
153			* @param array $params - url params passed (array format)
154			*/
155			public function imageCrop(Image & $image, $params)
156			{
157			$crop = Arr::get($params, 'crop', false);
158			if ($crop !== false) {
159			if (is_string($crop)) {
160			$bits = explode(',', $crop);
161			$w = Arr::get($bits, 0, null);
162			$h = Arr::get($bits, 1, null);
163			$x = Arr::get($bits, 2, null);
164			$y = Arr::get($bits, 3, null);
165			}
166			if (is_array($crop)) {
167			$w = Arr::get($crop, 'width', null);
168			$h = Arr::get($crop, 'height', null);
169			$x = Arr::get($crop, 'x', null);
170			$y = Arr::get($crop, 'y', null);
171			}
172			if ($w == 0 && $h == 0 && $x == 0 && $y ==0) {
			0 ignored issues – show Comprehensibility Best Practice introduced 2020-07-02 09:59 UTC by Report Bug Copy Issue Report The variable `$x` does not seem to be defined for all execution paths leading up to this point. Loading history... Comprehensibility Best Practice introduced 2020-07-02 09:59 UTC by Report Bug Copy Issue Report The variable `$h` does not seem to be defined for all execution paths leading up to this point. Loading history... Comprehensibility Best Practice introduced 2020-07-02 09:59 UTC by Report Bug Copy Issue Report The variable `$y` does not seem to be defined for all execution paths leading up to this point. Loading history... Comprehensibility Best Practice introduced 2020-07-02 09:59 UTC by Report Bug Copy Issue Report The variable `$w` does not seem to be defined for all execution paths leading up to this point. Loading history...
173			return $image;
174			}
175			$image->crop($w, $h, $x, $y);
176			$manager = new InterventionImageManager();
177			$bg = $manager->canvas($w, $h, array(255, 255, 255, 0));
178			// Fill up the blank spaces with transparent color
179			$image = $bg->insert($image, 'center');
180			}
181			}
182
183			/**
184			* Resolve missing image dimensions.
185			* @param Image $image The source image.
186			* @param integer\|null $width The image width.
187			* @param integer\|null $height The image height.
188			* @return integer[] The resolved width and height.
189			*/
190			public function resolveMissingDimensions(Image & $image, $width, $height)
191			{
192			if (is_null($width) and is_null($height)) {
193			$width = $image->width();
194			$height = $image->height();
195			}
196
197			if (is_null($width)) {
198			$width = $height * ($image->width() / $image->height());
199			}
200
201			if (is_null($height)) {
202			$height = $width / ($image->width() / $image->height());
203			}
204
205			return [
206			(int) $width,
207			(int) $height,
208			];
209			}
210
211			/**
212			* Perform sepia manipulation.
213			* @param Image $image The source image.
214			* @return Image The manipulated image.
215			*/
216			public function runSepiaFilter(Image & $image)
217			{
218			$image->greyscale();
219			$image->brightness(-10);
220			$image->contrast(10);
221			$image->colorize(38, 27, 12);
222			$image->brightness(-10);
223			$image->contrast(10);
224			return $image;
225			}
226
227			/**
228			* @return string
229			*/
230			public function getPlaceholderImageContents()
231			{
232			// should be configurable by settings somewhere
233			return file_get_contents(dirname(__DIR__).'/assets/placeholder.jpg');
234			}
235
236			public function getNotReadableImageContents()
237			{
238			// should be configurable by settings somewhere
239			return file_get_contents(dirname(__DIR__).'/assets/placeholder-broken.png');
240			}
241			}
242

newicon / neon

Push — develop ( ff58ad...b8f9b2 )

ImageManager::imageCrop() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like