app_CtrlCustomSection::edit() - Code Metrics - Inspection of "Temporary fix isCreatable" - capwelton/libapp - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Push — master ( 6fc9bf...10dc5f )

by Laurent
created 2019-04-12 15:15 UTC
app_CtrlCustomSection::edit() B

↳ Parent: app_CtrlCustomSection
Complexity

Conditions	3
Paths	4
Size

Total Lines	114
Code Lines	78
Duplication

Lines	0
Ratio	0 %
Importance

Changes
Metric	Value
cc	3
eloc	78
c	0
b	0
f	0
nc	4
nop	3
dl	0
loc	114
rs	8.48
How to fix Long Method

<?php
//-------------------------------------------------------------------------
// OVIDENTIA http://www.ovidentia.org
// Ovidentia is free software; you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation; either version 2, or (at your option)
// any later version.
//
// This program is distributed in the hope that it will be useful, but
// WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
// See the GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with this program; if not, write to the Free Software
// Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307,
// USA.
//-------------------------------------------------------------------------
/**
 * @license http://opensource.org/licenses/gpl-license.php GNU General Public License (GPL)
 * @copyright Copyright (c) 2008 by CANTICO ({@link http://www.cantico.fr})
 */


require_once APP_CTRL_PATH . '/record.ctrl.php';


/**
 * This controller manages actions that can be performed on custom sections
 *
 * @method Func_App App()
 */
class app_CtrlCustomSection extends app_CtrlRecord
{
    /**
     * Returns an array of field names and descriptions that can be used in Full/CardFrames.
     *
     * @return string[]
     */
    public function getAvailableDisplayFields()
    {
        $recordSet = $this->getRecordSet();

        $availableFields = array();

        foreach ($recordSet->getFields() as $name => $field) {
            $availableFields[$name] = array(
                'name' => $field->getName(),
                'description' => $field->getDescription()
            );
        }

        return $availableFields;
    }


    /**
     *
     */
    public function addDisplayField($id = null, $filter = null)
    {
        $W = bab_Widgets();
        $W = /** @scrutinizer ignore-call */ bab_Widgets();
        $App = $this->App();

        $customSectionSet = $App->CustomSectionSet();

        $customSection = $customSectionSet->request($customSectionSet->id->is($id));
        /** @scrutinizer ignore-call */ $customSection = $customSectionSet->request($customSectionSet->id->is($id));

        $page = $App->Ui()->Page();
        $page->setTitle($App->translate('Add field'));

        $availableFields = $this->getAvailableDisplayFields();

        $box = $W->VBoxItems();

        foreach ($availableFields as $field) {
            $fieldName =  $field['name'];
            $fieldDescription = $field['description'];
            if (substr($fieldName, 0, 1) !== '_') {
                $fieldDescription = $App->translate($fieldDescription);
            }
            $box->addItem(
                $W->VBoxItems(
                    $W->Link(
                        $fieldDescription,
                        $this->proxy()->saveDisplayField($customSection->id, $fieldName)
                    )->addClass('widget-strong', 'widget-close-dialog')
                    ->setAjaxAction(),
                    $W->Label($fieldName)->addClass('widget-small'),
                    $W->Hidden()->setName(array('sections', $field['name']))
                )->setSizePolicy('widget-list-element')
            );
        }

        $page->addItem($box);
        return $page;
    }


    /**
     *
     * @param int $section
     * @param string $fieldName
     * @return boolean
     */
    public function saveDisplayField($section, $fieldName)
    {
        $App = $this->App();
        $customSectionSet = $App->CustomSectionSet();

        $customSection = $customSectionSet->request($customSectionSet->id->is($section));
        /** @scrutinizer ignore-call */ $customSection = $customSectionSet->request($customSectionSet->id->is($section));
        $customSection->addField($fieldName);
        $customSection->save();

        $this->addReloadSelector('.depends-custom-sections');

        return true;
    }


    /**
     *
     * @param int $section
     * @param string $fieldName
     * @return boolean
     */
    public function removeDisplayField($section, $fieldName)
    {
        $App = $this->App();
        $customSectionSet = $App->CustomSectionSet();

        $customSection = $customSectionSet->request($customSectionSet->id->is($section));
        /** @scrutinizer ignore-call */ $customSection = $customSectionSet->request($customSectionSet->id->is($section));

        $customSection->removeField($fieldName);
        $customSection->save();
        $this->addReloadSelector('.depends-custom-sections');
        return true;
    }




    /**
     * @param string    $view
     * @param int       $id
     * @param string    $object
     * @return app_Page
     */
    public function edit($view, $id = null, $object = null)
    {
        $App = $this->App();
        $W = bab_Widgets();
        $W = /** @scrutinizer ignore-call */ bab_Widgets();

        $customSectionSet = $App->CustomSectionSet();
        if (isset($id)) {
            $record = $customSectionSet->request($id);
            /** @scrutinizer ignore-call */ $record = $customSectionSet->request($id);
        } else {
            $record = $customSectionSet->newRecord();
            $record->object = $object;
        }

        $page = $App->Ui()->Page();

        $page->setTitle($App->translate('Section'));
        $page->addClass('app-page-editor');

        $editor = new app_Editor($App);
        $editor->setHiddenValue('tg', $App->controllerTg);
        $editor->/** @scrutinizer ignore-call */ setHiddenValue('tg', $App->controllerTg);
        $editor->setHiddenValue('data[view]', $view);
        if ($record->id) {
            $editor->setHiddenValue('data[id]', $record->id);
        }
        $editor->setName('data');
        $editor->addItem(
            $W->Hidden()->setName('object')
        );

        $editor->addItem(
            $W->LabelledWidget(
                $App->translate('Name'),
                $W->LineEdit()->setName('name')
            )
        );

        $sizePolicyClassnames = array(
            'col-md-1' => '1',
            'col-md-2' => '2',
            'col-md-3' => '3',
            'col-md-4' => '4',
            'col-md-5' => '5',
            'col-md-6' => '6',
            'col-md-7' => '7',
            'col-md-8' => '8',
            'col-md-9' => '9',
            'col-md-10' => '10',
            'col-md-11' => '11',
            'col-md-12' => '12',
        );


        $editor->addItem(
            $W->LabelledWidget(
                $App->translate('Size policy'),
                $W->Select()
                    ->addOptions($sizePolicyClassnames)
                    ->setName('sizePolicy')
            )
        );
        $editor->addItem(
            $W->LabelledWidget(
                $App->translate('Fields layout'),
                $W->Select()
                    ->addOptions(app_CustomSection::getFieldsLayouts())
                    ->setName('fieldsLayout')
            )
        );
        $editor->addItem(
            $W->LabelledWidget(
                $App->translate('Foldable'),
                $foldableCheckBox = $W->CheckBox()->setName('foldable')
            )
        );
        $editor->addItem(
            $foldedWidget = $W->LabelledWidget(
                $App->translate('Folded'),
                $W->CheckBox()->setName('folded')
            )
        );
        $editor->addItem(
            $W->LabelledWidget(
                $App->translate('Editable'),
                $W->CheckBox()->setName('editable')
            )
        );
        $editor->addItem(
            $W->LabelledWidget(
                $App->translate('Class'),
                $W->LineEdit()->setName('classname')
            )
        );

        $foldableCheckBox->setAssociatedDisplayable($foldedWidget, array(true));

        $editor->setValues($record->getFormOutputValues(), array('data'));

        $editor->addButton(
            $W->SubmitButton(/*'save'*/)
                ->validate(true)
                ->setAction($this->proxy()->save())
                ->setAjaxAction()
            ->setLabel($App->translate('Save'))
        );

        $editor->addButton(
            $W->SubmitButton(/*'cancel'*/)
                ->addClass('widget-close-dialog')
            ->setLabel($App->translate('Cancel'))
        );

        $page->addItem($editor);

        return $page;
    }


    /**
     *
     * @param int $id
     * @return app_Page
     */
    public function editVisibility($id = null)
    {
        $App = $this->App();

        $page = $App->Ui()->Page();

        $page->setTitle($App->translate('Section visibility'));
        $page->addClass('app-page-editor');

        $recordSet = $this->getRecordSet();
        $record = $recordSet->request($id);

        $object = $record->object . 'Set';

        $objectRecordSet = $App->$object();


        $editor = $App->Ui()->CriteriaEditor($objectRecordSet->all());
        $editor = $App->Ui()->/** @scrutinizer ignore-call */ CriteriaEditor($objectRecordSet->all());
        $editor->setHiddenValue('data[id]', $record->id);
        $editor->setName('data');

        if (!empty($record->visibilityCriteria)) {
            $arrCriteria = json_decode($record->visibilityCriteria, true);

            $data = array();
            foreach ($arrCriteria as $fieldName => $operation) {
                $data['field'] = $fieldName;
                foreach ($operation as $condition => $value) {
                    $data['condition']['default'] = $condition;
                    $data['condition']['bool'] = $condition;
                    $data['value'] = $value;
                }
            }

            $editor->setValues($data, array('data'));
        }


        $editor->setSaveAction($this->proxy()->saveVisibility());
        $editor->isAjax = bab_isAjaxRequest();
        $editor->isAjax = /** @scrutinizer ignore-call */ bab_isAjaxRequest();

        $page->addItem($editor);

        return $page;
    }



    /**
     * {@inheritDoc}
     * @see app_Controller::save()
     */
    public function save($data = null)
    {
        parent::save($data);

        $this->addReloadSelector('.depends-custom-sections');

        return true;
    }


    /**
     * {@inheritDoc}
     * @see app_CtrlRecord::delete()
     */
    public function delete($id)
    {
        parent::delete($id);

        $this->addReloadSelector('.depends-custom-sections');

        return true;
    }


    /**
     * @param array $data
     */
    public function saveVisibility($data = null)
    {
        $App = $this->App();

        $recordSet = $this->getRecordSet();
        $record = $recordSet->request($data['id']);

        $object = $record->object . 'Set';

        $objectRecordSet = $App->$object();

        $field = $data['field'];

        $field = $objectRecordSet->$field;

        $condition = $data['condition'];

        if ($field instanceof ORM_BoolInterface) {
filter:
    dependency_paths: ["lib/*"]
            $condition = $condition['bool'];
        } else {
            $condition = $condition['default'];
        }

        $criteria = $field->{$condition}($data['value']);

        $record->visibilityCriteria = $criteria->toJson();

        $record->save();

        $this->addReloadSelector('.depends-custom-sections');

        return true;
    }
}

capwelton / libapp

Push — master ( 6fc9bf...10dc5f )

app_CtrlCustomSection::edit() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like
