app_TableModelView

Complexity

Total Complexity

63

Size/Duplication

Total Lines	589
Duplicated Lines	0 %

Importance

Changes	10
Bugs	3	Features	0

15 Methods

Rating	Name	Duplication	Size	Complexity
A	setApp()	0	4	1
A	isFilterFieldSpecified()	0	20	6
A	handleFilterLabel()	0	13	2
A	getSearchItem()	0	5	1
C	getAdvancedFilterForm()	0	210	13
C	advancedFilterPanel()	0	59	11
A	handleAdvancedFilterFields()	0	2	1
A	getRecordControllerProxy()	0	6	2
A	__construct()	0	4	1
A	App()	0	13	3
A	addCustomFields()	0	12	2
A	getRecordController()	0	3	1
B	handleFilterInputWidget()	0	39	6
C	filterPanel()	0	58	12
A	setRecordController()	0	4	1

<?php
//-------------------------------------------------------------------------
// OVIDENTIA http://www.ovidentia.org
// Ovidentia is free software; you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation; either version 2, or (at your option)
// any later version.
//
// This program is distributed in the hope that it will be useful, but
// WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
// See the GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with this program; if not, write to the Free Software
// Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307,
// USA.
//-------------------------------------------------------------------------
/**
 * @license http://opensource.org/licenses/gpl-license.php GNU General Public License (GPL)
 * @copyright Copyright (c) 2009 by CANTICO ({@link http://www.cantico.fr})
 */

bab_Widgets()->includePhpClass('widget_Form');
bab_Widgets()->includePhpClass('widget_Frame');
bab_Widgets()->includePhpClass('widget_InputWidget');
bab_Widgets()->includePhpClass('widget_TableModelView');

require_once dirname(__FILE__) . '/ui.helpers.php';

/**
 * @return Widget_Form
 *
 *
 * @method self     setReadOnly($flag = true)
 * @method boolean  isReadOnly()
 * @method boolean  getReadOnly()
 * @method self     colon($colon = true)
 * @method boolean  isColon()
 * @method self     setHiddenValue($name, $value)
 * @method string   getHiddenValue($name)
 * @method array    getHiddenFields()
 * @method self     setHiddenValues($basename, $values)
 * @method Widget_InputWidget[] getFields($parent = null)
 * @method mixed    getValue($namePath)
 * @method self     setValue($namePath, $value)
 * @method self     setValues($row, $namePathBase = array())
 * @method array    getValues()
 * @method self     setAnchor($anchorname)
 * @method self     setSelfPageHiddenFields()
 * @method boolean  testMandatory()
 * @method self     checkUnsaved($check, $unsavedMessage)
 * @method self     setValidateAction(Widget_Action $action = null)
 * @method array    getClasses()
 * @method array    getFullName()
 * @method string   getName()
 * @method string   display(Widget_Canvas $canvas)
 * @method self     addClass($className)
 */
class app_Editor extends app_UiObject
{
    /**
     * @var Widget_Form $item
     */
    protected $item = null;

    /**
     * @var app_Record
     */
    protected $record;

    protected $ctrl;

    protected $saveAction;
    protected $saveLabel;

    protected $cancelAction;
    protected $cancelLabel;

    /**
     * @var Func_Widgets
     */
    protected $widgets;

    protected $buttonsLayout;

    /**
     * @var Widget_Layout
     */
    protected $innerLayout;

    protected $failedAction = null;
    protected $successAction = null;

    /**
     * @var Widget_Section[]
     */
    protected $sections = array();


    public $isAjax = false;

    /**
     *
     * @var array
     */
    private $tmp_values;


    /**
     * @param	Func_App		$app
     * @param 	Widget_Layout 	$layout		The layout that will manage how widgets are displayed in this form.
     * @param 	string 			$id			The item unique id.
     */
    public function __construct(Func_App $app, $id = null, Widget_Layout $layout = null)
    {
        parent::__construct($app);
         // We simulate inheritance from Widget_VBoxLayout.
        $W = $this->widgets = bab_Widgets();

        $this->buttonsLayout = $this->buttonsLayout();

        if (!isset($layout)) {
            $this->innerLayout = $W->VBoxLayout();
            $this->innerLayout->setVerticalSpacing(1, 'em');
        } else {
            $this->innerLayout = $layout;
        }

        $this->innerLayout->addClass('app-loading-box'); // javascript can add the app-loading-on class to this container to show ajax loading progress in the form

        $layout = $W->VBoxItems(
            $this->innerLayout,
            $this->buttonsLayout
        );

        // We simulate inheritance from Widget_Form.
        $this->setInheritedItem($W->Form($id, $layout));
        if (isset($this->tmp_values)) {
            $this->setValues($this->tmp_values[0], $this->tmp_values[1]);
        }

        $this->setFormStyles();
        $this->prependFields();

    }


    /**
     * @return Widget_Layout
     */
    protected function buttonsLayout()
    {
        $W = bab_Widgets();
        return $W->HBoxLayout()
            ->setSizePolicy('widget-form-buttons')
            ->setHorizontalSpacing(1, 'em');
    }



    protected function setFormStyles()
    {
        $this->addClass('app-editor');
    }


    /**
     * Set record and values to editor
     * @see app_Editor::getRecord()
     *
     * @param app_Record $record
     *
     * @return self
     */
    public function setRecord(app_Record $record)
    {
        $this->record = $record;

        if ($name = $this->getName()) {
            $values = $record->getFormOutputValues();

            $this->setValues($values, array($name));
        }

        return $this;
    }

    /**
     * @return app_Record
     */
    protected function getRecord()
    {
        return $this->record;
    }


    /**
     * @return app_RecordSet
     */
    protected function getRecordSet()
    {
        if ($this->record) {
            return $this->record->getParentSet();
        }
        return null;
    }


    public function setValues($row, $namePathBase = array())
    {
        if (isset($this->item)) {
            return $this->item->setValues($row, $namePathBase);
        } else {
            $this->tmp_values = array($row, $namePathBase);
            return true;
        }
    }

    /**
     *
     * @return app_Editor
     */
    public function setController($ctrl)
    {
        $this->ctrl = $ctrl;
        return $this;
    }


    /**
     *
     * @return app_Editor
     */
    public function setSaveAction($saveAction, $saveLabel = null)
    {
        $this->saveAction = $saveAction;
        $this->saveLabel = $saveLabel;
        return $this;
    }

    public function setSuccessAction($successAction)
    {
        $this->successAction = $successAction;
        return $this;
    }

    public function setFailedAction($failedAction)
    {
        $this->failedAction = $failedAction;
        return $this;
    }

    /**
     *
     * @return app_Editor
     */
    public function setCancelAction($cancelAction, $cancelLabel = null)
    {
        $this->cancelAction = $cancelAction;
        $this->cancelLabel = $cancelLabel;
        return $this;
    }



    /**
     * Adds a button to button box of the form.
     *
     * @param Widget_Item $button
     * @param Widget_Action $action
     *
     * @return self
     */
    public function addButton(Widget_Item $button, Widget_Action $action = null)
    {
        $this->buttonsLayout->addItem($button);
        if (isset($action)) {
            $button->setAction($action);

The method setAction() does not exist on Widget_Item. It seems like you code against a sub-type of Widget_Item such as Widget_SimpleTreeView or Widget_Link or Widget_Dockable or Widget_SubmitButton or Widget_Tab.

        }

        return $this;
    }


    /**
     * Adds an item to the top part of the form.
     *
     * @return app_Editor
     */
    public function addItem(Widget_Displayable_Interface $item = null, $position = null)
    {
        $this->innerLayout->addItem($item, $position);

The call to Widget_Layout::addItem() has too many arguments starting with $position.

        return $this;
    }

    /**
     *
     *
     */
    protected function appendButtons()
    {
        $W = $this->widgets;
        $App = $this->App();

        if (isset($this->saveAction)) {
            $saveLabel = isset($this->saveLabel) ? $this->saveLabel : $App->translate('Save');
            $submitButton = $W->SubmitButton();
            $submitButton->validate()
                ->setAction($this->saveAction)
                ->setFailedAction($this->failedAction)
                ->setSuccessAction($this->successAction)
                ->setLabel($saveLabel);
            if ($this->isAjax) {
                $submitButton->setAjaxAction();
            }
            $this->addButton($submitButton);
        }

        if (isset($this->cancelAction)) {
            $cancelLabel = isset($this->cancelLabel) ? $this->cancelLabel : $App->translate('Cancel');
            $this->addButton(
                $W->SubmitButton(/*'cancel'*/)
                     ->addClass('widget-close-dialog')
                    ->setAction($this->cancelAction)
                      ->setLabel($cancelLabel)
            );
        }
    }

    /**
     * Fields that will appear at the beginning of the form.
     *
     */
    protected function prependFields()
    {

    }


    /**
     * Fields that will appear at the end of the form.
     *
     */
    protected function appendFields()
    {

    }


    /**
     * Adds an item with a label and a description to the form.
     *
     * @param string                       $labelText
     * @param Widget_Displayable_Interface $item
     * @param string                       $fieldName
     * @param string                       $description
     * @param string						$suffix		 suffix for input field, example : unit
     *
     * @return Widget_LabelledWidget
     */
    public function labelledField($labelText, Widget_Displayable_Interface $item, $fieldName = null, $description = null, $suffix = null)
    {
        $W = $this->widgets;
        return $W->LabelledWidget($labelText, $item, $fieldName, $description, $suffix);
    }


    /**
     * Creates section in the editor.
     * If a section with the same header text (title) was already
     * created it is replaced by an empty section.
     *
     * @param string $headerText
     * @return Widget_Section
     */
    protected function createSection($headerText, $layout = null)
    {
        $W = bab_Widgets();
        if (!isset($layout)) {
            $layout = $W->VBoxLayout()->setVerticalSpacing(1, 'em');
        }
        $this->sections[$headerText] = $W->Section(
            $headerText,
            $layout
        )->setFoldable(true);

        return $this->sections[$headerText];
    }

    /**
     * Retrieves a section in the editor.
     *
     * @param string $headerText
     * @return Widget_Section
     */
    protected function getSection($headerText)
    {
        if (!isset($this->sections[$headerText])) {
            return null;
        }
        return $this->sections[$headerText];
    }


    /**
     * Returns the list of sections created via createSection().
     *
     * @return Widget_Section[]
     */
    public function getSections()
    {
        return $this->sections;
    }


    /**
     *
     */
    public function display(Widget_Canvas $canvas)
    {
        $this->appendFields();
        $this->appendButtons();

        return parent::display($canvas);
    }
}


class app_Toolbar extends Widget_Frame
{
    public $local = false;

    public function __construct($id = null, Widget_Layout $layout = null)
    {
        if (!isset($layout)) {
            $W = bab_Widgets();
            $layout = $W->FlowLayout()->setHorizontalSpacing(1, 'em');
            $layout->setVerticalAlign('top');
        }

        parent::__construct($id, $layout);
    }

    /**
     *
     * @param string		 	$labelText
     * @param string			$iconName
     * @param Widget_Action		$action
     * @param string			$id
     * @return app_Toolbar
     */
    public function addButton($labelText = null, $iconName = null, $action = null, $id = null)
    {
        $W = bab_Widgets();
        $button = $W->Link($labelText, $action, $id);
        if (isset($iconName)) {
            $button->addClass('icon', $iconName);
        }

        $this->addItem($button);

        return $this;
    }


    public function addInstantForm(Widget_Displayable_Interface $form, $labelText = null, $iconName = null, $action = null, $id = null)
    {
        $W = bab_Widgets();
        if (isset($iconName)) {
            $content = $W->Icon($labelText, $iconName);
        } else {
            $content = $labelText;
        }
        $button = $W->Link($content, $action, $id);

        $this->addItem(
            $W->VBoxItems(
                $button->addClass('widget-instant-button'),
                $form->addClass('widget-instant-form')
            )->addClass('widget-instant-container')
        );

        if ($form->getTitle() === null) {
            $form->setTitle($labelText);
        }


        return $this;

    }


    public function display(Widget_Canvas $canvas)
    {
        if (!$this->local) {
            $this->addClass('widget-toolbar');
        } else {
            $this->addClass('app-toolbar');
        }
        $this->addClass(Func_Icons::ICON_LEFT_16);

        return parent::display($canvas);
    }

}




class app_RecordEditor extends app_Editor
{

    /**
     * @var app_RecordSet
     */
    public $recordSet = null;

    /**
     * Creates section in the editor.
     * If a section with the same header text (title) was already
     * created it is replaced by an empty section.
     *
     * @param string $headerText
     * @return Widget_Section
     */
    protected function addSection($id, $headerText, $layout = null)
    {
        $W = bab_Widgets();
        if (!isset($layout)) {
            $layout = $W->VBoxLayout()->setVerticalSpacing(1, 'em');
        }
        $this->sections[$id] = $W->Section(
            $headerText,
            $layout
            )->setFoldable(true);

            return $this->sections[$id];
    }


    /**
     * Retrieves a section in the editor.
     *
     * @param string $headerText
     * @return Widget_Section
     */
    protected function getSection($id)
    {
        if (!isset($this->sections[$id])) {
            return null;
        }
        return $this->sections[$id];
    }


    /**
     * @param string $textLabel
     * @param mixed $value
     * @return Widget_Displayable_Interface
     */
    public function labelledWidget($textLabel, $value, app_CustomSection $section = null)
    {
        $W = bab_Widgets();

        if ($value instanceof Widget_Displayable_Interface) {
            $widget = $value;
        } else {
            $widget = $W->Label($value);
        }

        if (isset($section)) {
            if ($textLabel === '__') {
                $fieldLayout = app_CustomSection::FIELDS_LAYOUT_NO_LABEL;
            } else {
                $fieldLayout = $section->fieldsLayout;
            }
            switch ($fieldLayout) {
                case app_CustomSection::FIELDS_LAYOUT_HORIZONTAL_LABEL:
                    return $W->FlowItems(
                        $W->Label($textLabel)->addClass('crm-horizontal-display-label', 'widget-strong')
                            ->setSizePolicy('widget-25pc'),
                        $widget->setSizePolicy('widget-75pc')
                    )->addClass('widget-labelled-widget')
                    ->setHorizontalSpacing(1, 'ex')
                    ->setVerticalAlign('top');

                case app_CustomSection::FIELDS_LAYOUT_WIDE_HORIZONTAL_LABEL:
                    return $W->FlowItems(
                        $W->Label($textLabel)->addClass('crm-horizontal-display-label', 'widget-strong')
                            ->setSizePolicy('widget-50pc'),
                        $widget
                    )->addClass('widget-labelled-widget')
                    ->setHorizontalSpacing(1, 'ex')
                    ->setVerticalAlign('top');

                case app_CustomSection::FIELDS_LAYOUT_NO_LABEL:
                    return $widget;

                case app_CustomSection::FIELDS_LAYOUT_VERTICAL_LABEL:
                default:
                    return $W->LabelledWidget($textLabel, $widget);
            }
        }
    }


    function labelledWidgetOptional($textLabel, $displayedValue, $value = null, app_CustomSection $section = null)

It is generally recommended to explicitly declare the visibility for methods.

    {
        if (!isset($value)) {
            $value = $displayedValue;
        }
        if (!isset($value) || is_numeric($value) && $value == 0 || is_string($value) && trim($value) == '' || ($value instanceof Widget_Layout && count($value->getItems()) <= 0)) {
            return null;
        }
        return $this->labelledWidget($textLabel, $displayedValue, $section);
    }



    protected function fieldOutput($field, $record, $fieldName)
    {
        if ($field instanceof ORM_CurrencyField) {
            $App = $this->App();
            $value = $App->shortFormatWithUnit($this->record->$fieldName, $App->translate('_euro_'));
        } else {
            $value = $field->output($this->record->$fieldName);
        }
        if (is_array($value)) {
            $value = implode(', ', $value);
        }
        return $value;
    }


    protected function getValueItem($customSection, $displayField, $label, $value)
    {
        return $this->labelledWidget(
            $label,
            //            $item,
            $value,
            $customSection
        );
    }


    protected function addSections($view)
    {
        $App = $this->App();
        $W = bab_Widgets();


        $this->addItem($W->Hidden()->setName('id'));

        $recordClassName = $this->record->getClassName();

        $customSectionSet = $App->CustomSectionSet();
        $conditions = array(
            $customSectionSet->object->is($recordClassName),
            $customSectionSet->view->is($view)
        );

        $customSections = $customSectionSet->select(
            $customSectionSet->all($conditions)
            );
        $customSections->orderAsc($customSectionSet->rank);

        $currentColumn = 0;
        $nbCol = 0;

        $row = $W->Items()->setSizePolicy('row');
        foreach ($customSections as $customSection) {

            if (isset($this->record) && !$customSection->isVisibleForRecord($this->record)) {
                continue;
            }

            list(, , $nbCol) = explode('-', $customSection->sizePolicy);

            if ($currentColumn + $nbCol > 12) {
                $this->addItem($row);
                $row = $W->Items()->setSizePolicy('row');
                $currentColumn = 0;
            }
            $currentColumn += $nbCol;

            $section = $this->getSection($customSection->id);
            if (!isset($section)) {
                $section = $this->addSection($customSection->id, $customSection->name);
                $section->addClass($customSection->classname);
                $section->setSizePolicy($customSection->sizePolicy);

                $section->setFoldable($customSection->foldable, $customSection->folded);
                $row->addItem($section);
            }

            $displayFields = $customSection->getFields();

            foreach ($displayFields as $displayField) {
                $widget = null;
                $item = null;
                $displayFieldName = $displayField['fieldname'];
                $parameters = $displayField['parameters'];
                $classname = isset($parameters['classname']) ? $parameters['classname'] : '';
                $label = isset($parameters['label']) && $parameters['label'] !== '__' ? $parameters['label'] : '';
                $displayFieldMethod = '_' . $displayFieldName;

                if (method_exists($this, $displayFieldMethod)) {
                    $widget = $this->$displayFieldMethod($customSection, $label);
                    $item = $widget;
                } elseif ($this->recordSet->fieldExist($displayFieldName)) {
                    $field = $this->recordSet->getField($displayFieldName);
                    if ($label === '') {
                        $label = $field->getDescription();
                        if (substr($displayFieldName, 0, 1) !== '_') {
                            $label = $App->translate($label);
                        }
                    }
                    $widget = $field->getWidget();
                    if ($widget instanceof Widget_TextEdit || $widget instanceof Widget_Select) {
                        $widget->addClass('widget-100pc');
                    }
                    $item = $this->getValueItem($customSection, $displayField, $label, $widget);
                }

                if ($item) {
                    $item->addClass($classname);
                    $section->addItem($item);
                }
            }
        }

        if ($currentColumn + $nbCol > 0) {
            $this->addItem($row);
        }
    }

    public function sectionContent($customSectionId)
    {
        $App = $this->App();

        $customSectionSet = $App->CustomSectionSet();
        $customSection = $customSectionSet->get($customSectionId);

        if (isset($this->record) && !$customSection->isVisibleForRecord($this->record)) {
            return null;
        }

        $W = bab_Widgets();

        $section = $W->VBoxLayout()->setVerticalSpacing(1, 'em');

        $displayFields = $customSection->getFields();

        $customSection->fieldsLayout = app_CustomSection::FIELDS_LAYOUT_HORIZONTAL_LABEL;

        foreach ($displayFields as $displayField) {
            $widget = null;
            $item = null;
            $displayFieldName = $displayField['fieldname'];
            $parameters = $displayField['parameters'];
            $classname = isset($parameters['classname']) ? $parameters['classname'] : '';
            $label = isset($parameters['label']) && $parameters['label'] !== '__' ? $parameters['label'] : '';
            $displayFieldMethod = '_' . $displayFieldName;

            if (method_exists($this, $displayFieldMethod)) {
                $widget = $this->$displayFieldMethod($customSection, $label);
                $item = $widget;
            } elseif ($this->recordSet->fieldExist($displayFieldName)) {
                $field = $this->recordSet->getField($displayFieldName);
                if ($label === '') {
                    $label = $field->getDescription();
                    if (substr($displayFieldName, 0, 1) !== '_') {
                        $label = $App->translate($label);
                    }
                }
                $widget = $field->getWidget();
                if ($widget instanceof Widget_TextEdit) {
                    $widget->addClass('widget-100pc widget-autoresize');

                }
                if ($widget instanceof Widget_Select) {
                    $widget->addClass('widget-100pc');
                }
                $item = $this->getValueItem($customSection, $displayField, $label, $widget);
            }

            if ($item) {
                $item->addClass($classname);
                $section->addItem($item);
            }
        }

        return $section;
    }
}





/**
 * A record frame is a frame displaying information about a app record.
 *
 * @since 1.0.40
 */
class app_RecordFrame extends app_UiObject // extends Widget_Frame
{
    /**
     * @var Widget_Section[]
     */
    protected $sections = array();

    /**
     * @var app_Record
     */
    protected $record = null;

    /**
     * @var app_RecordSet
     */
    protected $recordSet = null;


    /**
     * @param Func_App      $app
     * @param app_Record    $record
     * @param string        $id
     * @param Widget_Layout $layout
     */
    public function __construct(Func_App $app, app_Record $record, $id = null, Widget_Layout $layout = null)
    {
        parent::__construct($app);

        $W = bab_Widgets();
        $this->setInheritedItem($W->Frame($id, $layout));
    }


    /**
     * Creates section in the editor.
     * If a section with the same header text (title) was already
     * created it is replaced by an empty section.
     *
     * @param string $headerText
     * @return Widget_Section
     */
    protected function addSection($id, $headerText, $layout = null)
    {
        $W = bab_Widgets();
        if (!isset($layout)) {
            $layout = $W->VBoxLayout()->setVerticalSpacing(0.6, 'em');

0.6 of type double is incompatible with the type integer expected by parameter $spacing of Widget_Layout::setVerticalSpacing().

        }
        $this->sections[$id] = $W->Section(
            $headerText,
            $layout
        )->setFoldable(true);

        return $this->sections[$id];
    }


    /**
     * Retrieves a section in the editor.
     *
     * @param string $headerText
     * @return Widget_Section
     */
    protected function getSection($id)
    {
        if (!isset($this->sections[$id])) {
            return null;
        }
        return $this->sections[$id];
    }


    /**
     * @param string $textLabel
     * @param Widget_Displayable_Interface|string $value
     * @param app_CustomSection $section
     * @return Widget_Displayable_Interface
     */
    public function labelledWidget($textLabel, $value, app_CustomSection $section = null)
    {
        $W = bab_Widgets();

        if ($value instanceof Widget_Displayable_Interface) {
            $widget = $value;
        } else {
            $widget = $W->Label($value);
        }

        if (isset($section)) {
            if ($textLabel === '__') {
                $fieldLayout = app_CustomSection::FIELDS_LAYOUT_NO_LABEL;
            } else {
                $fieldLayout = $section->fieldsLayout;
            }
            switch ($fieldLayout) {
                case app_CustomSection::FIELDS_LAYOUT_HORIZONTAL_LABEL:
                    return $W->FlowItems(
                    $W->Label($textLabel)->addClass('app-horizontal-display-label', 'widget-strong')
                        ->setSizePolicy('widget-25pc'),
                    $widget->setSizePolicy('widget-75pc')
                )->addClass('widget-labelled-widget')
                ->setHorizontalSpacing(1, 'ex')
                ->setVerticalAlign('top');

                case app_CustomSection::FIELDS_LAYOUT_WIDE_HORIZONTAL_LABEL:
                    return $W->FlowItems(
                    $W->Label($textLabel)->addClass('app-horizontal-display-label', 'widget-strong')
                        ->setSizePolicy('widget-50pc'),
                    $widget->setSizePolicy('widget-50pc')
                )->addClass('widget-labelled-widget')
                ->setHorizontalSpacing(1, 'ex')
                ->setVerticalAlign('top');

                case app_CustomSection::FIELDS_LAYOUT_VERY_WIDE_HORIZONTAL_LABEL:
                    return $W->FlowItems(
                    $W->Label($textLabel)->addClass('app-horizontal-display-label', 'widget-strong')
                        ->setSizePolicy('widget-75pc'),
                    $widget->setSizePolicy('widget-25pc')
                )->addClass('widget-labelled-widget')
                ->setHorizontalSpacing(1, 'ex')
                ->setVerticalAlign('top');


                case app_CustomSection::FIELDS_LAYOUT_NO_LABEL:
                    return $widget;

                case app_CustomSection::FIELDS_LAYOUT_VERTICAL_LABEL:
                default:
                    return $W->LabelledWidget($textLabel, $widget);
            }
        }
    }


    /**
     *
     * @param string $textLabel
     * @param mixed $displayedValue
     * @param mixed $value
     * @param app_CustomSection $section
     * @return Widget_Displayable_Interface|null
     */
    public function labelledWidgetOptional($textLabel, $displayedValue, $value = null, app_CustomSection $section = null)
    {
        if (!isset($value)) {
            $value = $displayedValue;
        }
        if (!isset($value) || is_numeric($value) && $value == 0 || is_string($value) && trim($value) == '' || ($value instanceof Widget_Layout && count($value->getItems()) <= 0)) {
            return null;
        }
        $labelledWidget = $this->labelledWidget($textLabel, $displayedValue, $section);
        return $labelledWidget;
    }


    /**
     *
     * @param ORM_Field $field
     * @param ORM_Record $record
     * @param string $fieldName
     * @return mixed
     */
    protected function fieldOutput($field, $record, $fieldName)
    {
        if ($field instanceof ORM_CurrencyField) {
            $App = $this->App();
            $value = $App->shortFormatWithUnit($this->record->$fieldName, $App->translate('_euro_'));
        } else {
            $value = $field->output($this->record->$fieldName);
        }
        if (is_array($value)) {
            $value = implode(', ', $value);
        }
        return $value;
    }


    /**
     *
     * @param app_CustomSection $customSection
     * @param array $displayField
     * @param string $textLabel
     * @param Widget_Displayable_Interface|string $value
     * @return Widget_Displayable_Interface
     */
    protected function getValueItem(app_CustomSection $customSection, $displayField, $textLabel, $value)
    {
        if ($value instanceof Widget_Displayable_Interface) {
            return $value;
        }
        $W = bab_Widgets();
        $parameters = $displayField['parameters'];
        if (isset($parameters['type'])) {
            if ($parameters['type'] === 'title1') {
                $item = $W->Title($value, 1);
            } elseif ($parameters['type'] === 'title2') {
                $item = $W->Title($value, 2);
            } elseif ($parameters['type'] === 'title3') {
                $item = $W->Title($value, 3);
            } else {
                $item = $W->Label($value);
            }
        } else {
            $item = $W->Label($value);
        }
        $labelledWidgetOptional = $this->labelledWidget( //Optional(
            $textLabel,
            $item,
//            $value,
            $customSection
        );

        if (isset($labelledWidgetOptional)) {
            $labelledWidgetOptional->addClass($displayField['fieldname']);
        }

        return $labelledWidgetOptional;
    }


    /**
     * @param string $view
     */
    protected function addSections($view)
    {
        $App = $this->App();
        $W = bab_Widgets();

        $recordClassName = $this->record->getClassName();

        $customSectionSet = $App->CustomSectionSet();
        $customSections = $customSectionSet->select(
            $customSectionSet->object->is($recordClassName)->_AND_(
                $customSectionSet->view->is($view)
            )
        );
        $customSections->orderAsc($customSectionSet->rank);

        $currentColumn = 0;
        $nbCol = 0;
        $row = $W->Items()->setSizePolicy('row');
        foreach ($customSections as $customSection) {

            list(, , $nbCol) = explode('-', $customSection->sizePolicy);

            if ($currentColumn + $nbCol > 12) {
                $this->addItem($row);

The method addItem() does not exist on app_RecordFrame. Since you implemented __call, consider adding a @method annotation.

                $row = $W->Items()->setSizePolicy('row');
                $currentColumn = 0;
            }
            $currentColumn += $nbCol;

            $section = $this->getSection($customSection->id);
            if (!isset($section)) {
                $section = $this->addSection($customSection->id, $customSection->name);
                $section->addClass($customSection->classname);
                $section->setSizePolicy($customSection->sizePolicy);

                $section->setFoldable($customSection->foldable, $customSection->folded);
                $row->addItem($section);
            }

            $displayFields = $customSection->getFields();

            foreach ($displayFields as $displayField) {
                $value = null;
                $displayFieldName = $displayField['fieldname'];
                $parameters = $displayField['parameters'];
                $classname = isset($parameters['classname']) ? $parameters['classname'] : '';
                $label = isset($parameters['label']) ? $parameters['label'] : '';
                $displayFieldMethod = '_' . $displayFieldName;

                if (method_exists($this, $displayFieldMethod)) {
                    $value = $this->$displayFieldMethod($customSection, $label);
                } elseif ($this->recordSet->fieldExist($displayFieldName)) {
                    $field = $this->recordSet->getField($displayFieldName);
                    if ($label === '') {
                        $label = $field->getDescription();
                        if (substr($displayFieldName, 0, 1) !== '_') {
                            $label = $App->translate($label);
                        }
                    }
                    $value = $this->fieldOutput($field, $this->record, $displayFieldName);
                }

                if (isset($value)) {
                    $item = $this->getValueItem($customSection, $displayField, $label, $value);
                    if ($item) {
                        $item->addClass($classname);
                        $section->addItem($item);
                    }
                }
            }
        }

        if ($currentColumn + $nbCol > 0) {
            $this->addItem($row);
        }
    }
}








/**
 * Table model view with App() method
 *
 *
 */
class app_TableModelView extends widget_TableModelView
{

    /**
     * Filter form reset button
     */
    protected $reset = null;


    /**
     * @var Func_App
     */
    private $app = null;


    /**
     * @var app_CtrlRecord
     */
    protected $recordController = null;

    /**
     * @var app_CtrlRecord
     */
    protected $recordControllerProxy = null;

    /**
     * @param Func_App $app
     * @param string $id
     */
    public function __construct(Func_App $app = null, $id = null)
    {
        parent::__construct($id);
        $this->setApp($app);
    }

    /**
     * Forces the Func_App object to which this object is 'linked'.
     *
     * @param Func_App	$app
     * @return self
     */
    public function setApp(Func_App $app = null)
    {
        $this->app = $app;
        return $this;
    }

    /**
     * Get App object to use with this SET
     *
     * @return Func_App
     */
    public function App()
    {
        if (!isset($this->app)) {
            // If the app object was not specified (through the setApp() method)
            // we try to select one according to the classname prefix.
            list($prefix) = explode('_', get_class($this));
            $functionalityName = ucwords($prefix);
            $this->app = @bab_functionality::get('App/' . $functionalityName);

@bab_functionality::get('App/' . $functionalityName) is of type bab_functionality, but the property $app was declared to be of type Func_App. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

            if (!$this->app) {
                $this->app = @bab_functionality::get('App');
            }
        }
        return $this->app;
    }



	protected function addCustomFields(app_RecordSet $recordSet)
	{
		$customFields = $recordSet->getCustomFields();

        foreach ($customFields as $customField) {
            $fieldname = $customField->fieldname;
            $this->addColumn(
                widget_TableModelViewColumn($recordSet->$fieldname, $customField->name)
                  ->setSortable(true)
                  ->setExportable(true)
                  ->setSearchable($customField->searchable)

The property searchable does not exist on app_CustomField. Since you implemented __get, consider adding a @property annotation.

				  ->setVisible($customField->visible)

The property visible does not exist on app_CustomField. Since you implemented __get, consider adding a @property annotation.

            );
        }
	}


    /**
     * Get a generic filter panel
     * Use setPageLength to define the default number of items per page
     *
     * @param	array	$filter		Filter values
     * @param	string	$name		filter form name
     * @param	string	$anchor		anchor in destination page of filter, the can be a Widget_Tab id
     *
     * @return Widget_Filter
     */
    public function filterPanel($filter = null, $name = null)
    {
        $W = bab_Widgets();

        $filterPanel = $W->Filter();
        $filterPanel->setLayout($W->VBoxLayout());
        if (isset($name)) {
            $filterPanel->setName($name);
        }

        $pageLength = $this->getPageLength();
        if (null === $pageLength) {

The condition null === $pageLength is always false.

            $pageLength = 15;
        }

        $pageNumber = $this->getCurrentPage();
        if (null === $pageNumber) {

The condition null === $pageNumber is always false.

            $pageNumber = 0;
        }

        $this->setPageLength(isset($filter['pageSize']) ? $filter['pageSize'] : $pageLength);
        $this->setCurrentPage(isset($filter['pageNumber']) ? $filter['pageNumber'] : $pageNumber);

        if (isset($name)) {
            $this->sortParameterName = $name . '[filter][sort]';
        } else {
            $this->sortParameterName = 'filter[sort]';
        }

        if (isset($filter['sort'])) {
            $this->setSortField($filter['sort']);
        } elseif (!isset($this->sortField)) {

            if (method_exists($this, 'getDefaultSortField')) {
                $this->setSortField($this->getDefaultSortField());
            } else {
                $columns = $this->getVisibleColumns();
                $sortField = key($columns);
                $this->setSortField($sortField);
            }
        }

        $form = $this->getFilterForm();

        if (isset($filter)) {
            if (isset($name)) {
                $path = array($name, 'filter');
            } else {
                $path = array('filter');
            }
            $form->setValues($filter, $path);
        }


        $filterPanel->setFilter($form);
        $filterPanel->setFiltered($this);

        return $filterPanel;
    }


    /**
     * Add the filter fields to the filter form
     * @param Widget_Form $form
     *
     */
    protected function handleAdvancedFilterFields(Widget_Item $form)
    {

    }




    protected function isFilterFieldSpecified($filter, $fieldPath)
    {
        if (isset($filter[$fieldPath])) {
            $value = $filter[$fieldPath];
            if (is_array($value)) {
                foreach ($value as $val) {
                    $val = trim($val);
                    if (!empty($val)) {
                        return true;
                    }
                }
                return false;
            }

            if (trim($value) !== '') {
                return true;
            }
        }

        return false;
    }


    protected function handleFilterInputWidget($name, ORM_Field $field = null)
    {
        if (null === $field) {
            return null;
        }

        $W = bab_Widgets();

        if ($field instanceof ORM_FkField) {
            $widget = $W->Select();
            $widget->addOption('', '');

            $App = $this->App();
            $setName = $field->getForeignSetName();

            $pos = strrpos($setName, '\\');
            if ($pos === false) {
                list(, $appSetName) = explode('_', $setName);
            } else {
                list(, $appSetName) = array(substr($setName, 0, $pos), substr($setName, $pos + 1));
            }

            $set = $App->$appSetName();
            $set->setName($field->getName());
            $set->setDescription($field->getDescription());

            if ($set === null) {
                return null;
            }

            $values = $set->select();
            foreach ($values as $record) {
                $widget->addOption($record->id, (string)$record->name);
            }

            return $widget;
        }

        return parent::handleFilterInputWidget($name, $field);
    }


    /**
     * Handle label and input widget merge in one item before adding to the filter form
     * default is a vertical box layout
     *
     * @param Widget_Label                  $label
     * @param Widget_Displayable_Interface  $input
     * @return Widget_Item
     */
    protected function handleFilterLabel(Widget_Label $label, Widget_Displayable_Interface $input)
    {
        $W = bab_Widgets();
        if ($input instanceof Widget_CheckBox) {
            return $W->HBoxItems(
                $input,
                $label
            )->setVerticalAlign('middle')
            ->setHorizontalSpacing(1, 'ex');
        }
        return $W->VBoxItems(
            $label,
            $input
        );
    }

    protected function getSearchItem()
    {
        $W = bab_Widgets();

        return $W->LineEdit()->setName('search')->addClass('widget-100pc');
    }

    /**
     * Get an advanced form filter
     * @see Widget_Filter
     *
     * @param   string          $id
     * @param   array           $filter
     *
     * @return Widget_Form
     */
    public function getAdvancedFilterForm($id = null, $filter = null)
    {
        $App = $this->App();

        $W = bab_Widgets();

        $formItem = $this->getSearchItem();

        $activeFiltersFrame = $W->Frame(
            null,
            $W->FlowItems(
                $W->VBoxItems(
                    $W->Label($App->translate('Search'))->setAssociatedWidget($formItem),
                    $formItem
                )
            )
            ->setHorizontalSpacing(2, 'em')
            ->setVerticalSpacing(1, 'em')
            ->setVerticalAlign('bottom')
        );


        $addFilterButton = $W->Link($App->translate('More criteria'))
            ->addClass('icon', Func_Icons::ACTIONS_LIST_ADD, 'widget-instant-button', 'widget-actionbutton');


        $filterBox = $W->FlowLayout()
            ->addClass('widget-instant-form')
            ->setHorizontalSpacing(2, 'em')
            ->setVerticalSpacing(1, 'em')
            ->setVerticalAlign('bottom');

        $advancedFiltersFrame = $W->VBoxItems(
            $addFilterButton,
            $filterBox
        )->addClass('widget-instant-container');


        $columns = $this->getVisibleColumns();

        foreach ($columns as $fieldName => $column) {
            $field = $column->getField();
            if (! $column->isSearchable()) {
                continue;
            }

            if (! ($field instanceof ORM_Field)) {
                $field = null;
            }

            $label = $this->handleFilterLabelWidget($fieldName, $field);
            $input = $this->handleFilterInputWidget($fieldName, $field);

            if (isset($input) && isset($label)) {

                $input->setName($fieldName);
                $label->setAssociatedWidget($input);

                $input->addClass('widget-100pc');

                $formItem = $this->handleFilterLabel($label, $input);
                $formItem->addClass('field_' . $fieldName);

                $mainSearch = (method_exists($column, 'isMainSearch') && $column->isMainSearch());

                if ($mainSearch || $this->isFilterFieldSpecified($filter, $column->getFieldPath())) {

                    $removeColumnsAction = $W->Action();
                    $removeColumnsAction->setMethod(
                        'addon/widgets/configurationstorage',
                        'removeFilter',
                        array(
                            'key' => $this->getId(),
                            'name' => $column->getFieldPath(),
                            'insession' => $this->isConfigurationStorageInSession()
                        )
                    );

                    $activeFiltersFrame->addItem(
                        $W->FlowItems(
                            $formItem,
                            $W->Link('', $removeColumnsAction)
                                ->setAjaxAction()
                                ->addClass('icon', Func_Icons::STATUS_DIALOG_ERROR)
                        )
                    );
                } else {
                    $formItem->setSizePolicy('col-lg-2 col-md-3 col-sm-6 col-xs-12');
                    $filterBox->addItem($formItem);
                }
            }
        }


        if (! $this->submit) {
            $this->submit = $W->SubmitButton();
            $this->submit->setLabel(widget_translate('Apply filter'));
        }



        if ($controller = $this->getRecordController()) {
            $proxy = $controller->proxy();
            $this->reset = $W->Link(
                $App->translate('Reset'),
                $proxy->resetFilters()

The method resetFilters() does not exist on app_Controller. Since you implemented __call, consider adding a @method annotation.

            )->addClass('icon', Func_Icons::ACTIONS_VIEW_REFRESH, 'widget-actionbutton')
            ->setTitle($App->translate('Reset filter to default values'))
            ->setAjaxAction();

//             $this->save = $W->Link(
//                 $App->translate('Save'),
//                 $proxy->confirmSaveCurrentFilter()
//             )->addClass('icon', Func_Icons::ACTIONS_DOCUMENT_SAVE, 'widget-actionbutton')
//             ->setTitle($App->translate('Save current filter'))
//             ->setOpenMode(Widget_Link::OPEN_DIALOG_AND_RELOAD);

//             $this->select = null;

            $this->filterMenu = $W->Menu(null, $W->VBoxItems());

The property filterMenu does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            $this->filterMenu->setButtonClass('widget-actionbutton icon actions-list-filter');
            $this->filterMenu->setButtonLabel($App->translate('Saved filters'));
            $this->filterMenu->addClass(Func_Icons::ICON_LEFT_16);

            $filterNames = $controller->getFilterNames();
            if (count($filterNames) > 0) {
//                 $this->select = $W->Menu(null, $W->VBoxItems());
//                 $this->select->setButtonClass('widget-link icon actions-list-filter');
//                 $this->select->setButtonLabel($App->translate('Saved filters'));
//                 $this->select->addClass(Func_Icons::ICON_LEFT_16);


                foreach ($filterNames as $filterName) {
                    $filter = $W->getUserConfiguration($controller->getModelViewDefaultId() . '/filters/' . $filterName, 'widgets', false);

//                     $this->select->addItem(
//                         $W->Link(
//                             $filterName,
//                             $proxy->setCurrentFilterName($filterName)
//                         )->setTitle($filter['description'])
//                     );


                    $this->filterMenu->addItem(
                        $W->Link(
                            $filterName,
                            $proxy->setCurrentFilterName($filterName)

The method setCurrentFilterName() does not exist on app_Controller. Since you implemented __call, consider adding a @method annotation.

                        )->setTitle($filter['description'])
                        ->setAjaxAction()
                    );
                }
//                 $this->select->addSeparator();
//                 $this->select->addItem(
//                     $W->Link(
//                         $App->translate('Manage filters'),
//                         $proxy->manageFilters()
//                     )->addClass('icon', Func_Icons::ACTIONS_DOCUMENT_PROPERTIES)
//                     ->setOpenMode(Widget_Link::OPEN_DIALOG_AND_RELOAD)
//                 );

                $this->filterMenu->addSeparator();
                $this->filterMenu->addItem(
                    $W->Link(
                        $App->translate('Manage filters...'),
                        $proxy->manageFilters()

The method manageFilters() does not exist on app_Controller. Since you implemented __call, consider adding a @method annotation.

                    )->addClass('icon', Func_Icons::ACTIONS_DOCUMENT_PROPERTIES)
                    ->setOpenMode(Widget_Link::OPEN_DIALOG)
                );
                $this->filterMenu->addSeparator();
            }
        }

        $this->filterMenu->addItem(
            $W->Link(
                $App->translate('Save current filter...'),
                $proxy->confirmSaveCurrentFilter()

The variable $proxy does not seem to be defined for all execution paths leading up to this point.

            )->addClass('icon', Func_Icons::ACTIONS_DOCUMENT_SAVE)
            ->setOpenMode(Widget_Link::OPEN_DIALOG)
        );



        $form = $W->Form($id);
        $form->setReadOnly(true);
        $form->setName('filter');
        $form->colon();

        $form->setLayout(
            $W->FlowItems(
                $activeFiltersFrame,
                $W->FlowItems(
                    $advancedFiltersFrame,
                    $this->submit,
                    $W->FlowItems(
                        $this->reset,
                        $this->filterMenu
                    )
//                   $this->save,
//                   $this->select,
                )->setHorizontalSpacing(2, 'em')
                ->setVerticalSpacing(1, 'em')
            )->setVerticalSpacing(1, 'em')
            ->setVerticalAlign('bottom')
            ->addClass(Func_Icons::ICON_LEFT_16)
        );

        $form->setHiddenValue('tg', $App->controllerTg);
        $form->setAnchor($this->getAnchor());

        return $form;
    }


    /**
     * Get a advanced filter panel
     * Use setPageLength to define the default number of items per page
     *
     * @param	array	$filter		Filter values
     * @param	string	$name		filter form name
     * @param	string	$anchor		anchor in destination page of filter, the can be a Widget_Tab id
     *
     * @return Widget_Filter
     */
    public function advancedFilterPanel($filter = null, $name = null)
    {
        $W = bab_Widgets();

        $filterPanel = $W->Filter();
        $filterPanel->setLayout($W->VBoxLayout());
        if (isset($name)) {
            $filterPanel->setName($name);
        }

        $pageLength = $this->getPageLength();
        if (null === $pageLength) {

The condition null === $pageLength is always false.

            $pageLength = 15;
        }

        $pageNumber = $this->getCurrentPage();
        if (null === $pageNumber) {

The condition null === $pageNumber is always false.

            $pageNumber = 0;

The assignment to $pageNumber is dead and can be removed.

        }

        $this->setPageLength(isset($filter['pageSize']) ? $filter['pageSize'] : $pageLength);
//        $this->setCurrentPage(isset($filter['pageNumber']) ? $filter['pageNumber'] : $pageNumber);

        if (isset($name)) {
            $this->sortParameterName = $name . '[filter][sort]';
        } else {
            $this->sortParameterName = 'filter[sort]';
        }

        if (isset($filter['sort'])) {
            $this->setSortField($filter['sort']);
        } elseif (!isset($this->sortField)) {

            if (method_exists($this, 'getDefaultSortField'))
            {
                $this->setSortField($this->getDefaultSortField());
            } else {
                $columns = $this->getVisibleColumns();
                $sortField = key($columns);
                $this->setSortField($sortField);
            }
        }

        $form = $this->getAdvancedFilterForm(null, $filter);

        if (isset($filter)) {
            if (isset($name)) {
                $path = array($name, 'filter');
            } else {
                $path = array('filter');
            }
            $form->setValues($filter, $path);
        }

        $filterPanel->setFilter($form);
        $filterPanel->setFiltered($this);


        return $filterPanel;
    }

    /**
     * @param app_CtrlRecord $recordController
     * @return app_TableModelView
     */
    public function setRecordController(app_CtrlRecord $recordController)
    {
        $this->recordController = $recordController;
        return $this;
    }


    /**
     * @return app_CtrlRecord
     */
    public function getRecordController()
    {
        return $this->recordController;
    }



    /**
     * @return app_CtrlRecord
     */
    public function getRecordControllerProxy()
    {
        if (!isset($this->recordControllerProxy)) {
            $this->recordControllerProxy = $this->getRecordController()->proxy();
        }
        return $this->recordControllerProxy;
    }
}

/**
 * Creates a specific filter panel containing the table and an auto-generated form.
 *
 * @param Func_App                     $App
 * @param app_TableModelView           $tableview
 * @param Widget_Displayable_Interface $formContent
 * @param array                        $filter
 * @param string                       $name
 * @return Widget_Filter
 */
function app_filteredTableView(Func_App $App, app_TableModelView $tableview, Widget_Displayable_Interface $formContent, $filterValues = null, $name = null)
{
    $W = bab_Widgets();

    $filterPanel = $W->Filter();
    $filterPanel->setLayout($W->VBoxLayout());
    if (isset($name)) {
        $filterPanel->setName($name);
    }

    if (isset($filterValues['pageSize'])) {
        $tableview->setPageLength($filterValues['pageSize']);
    } else if ($tableview->getPageLength() === null) {

The condition $tableview->getPageLength() === null is always false.

        $tableview->setPageLength(12);
    }

    $tableview->setCurrentPage(isset($filterValues['pageNumber']) ? $filterValues['pageNumber'] : 0);

    $tableview->sortParameterName = $name . '[filter][sort]';

    if (isset($filterValues['sort'])) {
        $tableview->setSortField($filterValues['sort']);
    } else {
        $columns = $tableview->getVisibleColumns();
        foreach ($columns as $sort => $column) {
            if ($sortField = $column->getField()) {

The assignment to $sortField is dead and can be removed.

                $tableview->setSortField($sort);
                break;
            }
        }
    }


    if ($formContent instanceof Widget_Form) {
        $form = $formContent;
    } else {
        $form = $W->Form()->setLayout($W->VBoxLayout()->setVerticalSpacing(1, 'em'));
        $form->setReadOnly(true);
        $form->setName('filter');
        $form->colon();
        $form->addItem($formContent);

        $form->addItem($W->SubmitButton()->setLabel($App->translate('Filter')));
    }


    if (isset($filterValues) && is_array($filterValues)) {
        $form->setValues($filterValues, array($name, 'filter'));
    }
    $form->setHiddenValue('tg', bab_rp('tg'));
    $form->setHiddenValue('idx', bab_rp('idx'));

    $filterPanel->setFilter($form);
    $filterPanel->setFiltered($tableview);

    return $filterPanel;
}



/**
 * @param string|ORM_Field $field
 * @param string|null $description
 *
 * @return widget_TableModelViewColumn
 */
function app_TableModelViewColumn($field, $description = null)
{
    if (null === $field) {

The condition null === $field is always false.

        return null;
    }

    if (!isset($description) && $field instanceof ORM_Field) {
        $App = $field->getParentSet()->App();
        $description = $App->translate($field->getDescription());

The method translate() does not exist on ORM_Field. It seems like you code against a sub-type of ORM_Field such as ORM_RecordSet.

    }

    return new widget_TableModelViewColumn($field, $description);
}


class app_RecordView extends app_UiObject
{
    /**
     * @var app_Record
     */
    protected $record = null;

    /**
     * @var app_RecordSet
     */
    protected $recordSet = null;

    /**
     * @var Widget_Section[]
     */
    protected $sections = array();

    protected $view = '';

    /**
     * @var app_CtrlRecord
     */
    protected $recordController = null;

    /**
     * @param Func_App $App
     * @param string $id
     * @param Widget_Layout $layout
     */
    public function __construct(Func_App $App, $id = null, Widget_Layout $layout = null)
    {
        parent::__construct($App);

        if (!isset($layout)) {
            $W = bab_Widgets();
            $layout = $W->Items();
        }

        $this->setInheritedItem($layout);
    }


    /**
     * @param app_Record $record
     * @return self
     */
    public function setRecord(app_Record $record)
    {
        $this->record = $record;
        $this->recordSet = $record->getParentSet();


        return $this;
    }


    /**
     * @param string $view
     * @return self
     */
    public function setView($view)
    {
        $this->view = $view;
        return $this;
    }


    /**
     * @return string
     */
    public function getView()
    {
        return $this->view;
    }



    /**
     * Creates section in the editor.
     * If a section with the same header text (title) was already
     * created it is replaced by an empty section.
     *
     * @param string $headerText
     * @return Widget_Section
     */
    protected function addSection($id, $headerText, $layout = null)
    {
        $W = bab_Widgets();
        if (!isset($layout)) {
            $layout = $W->VBoxLayout()->setVerticalSpacing(1, 'em');
        }
        $this->sections[$id] = $W->Section(
            $headerText,
            $layout
        )->setFoldable(true);

        return $this->sections[$id];
    }

    /**
     * Creates section in the editor.
     * If a section with the same header text (title) was already
     * created it is replaced by an empty section.
     *
     * @param string $headerText
     * @return Widget_Section
     */
    protected function createSection($headerText, $layout = null)
    {
        return $this->addSection($headerText, $headerText, $layout);
    }


    /**
     * Retrieves a section in the editor.
     *
     * @param string $headerText
     * @return Widget_Section
     */
    protected function getSection($id)
    {
        if (!isset($this->sections[$id])) {
            return null;
        }
        return $this->sections[$id];
    }


    /**
     * Returns the list of sections created via createSection().
     *
     * @return Widget_Section[]
     */
    public function getSections()
    {
        return $this->sections;
    }




    /*
     * @param string $textLabel
     * @param mixed $value
     * @return Widget_Layout
     */
    function labelledWidget($textLabel, $value, app_CustomSection $section = null)

It is generally recommended to explicitly declare the visibility for methods.

    {
        $W = bab_Widgets();

        if ($value instanceof Widget_Displayable_Interface) {
            $widget = $value;
        } else {
            $widget = $W->Label($value);
        }

        if (isset($section)) {
            if ($textLabel === '__') {
                $fieldLayout = app_CustomSection::FIELDS_LAYOUT_NO_LABEL;
            } else {
                $fieldLayout = $section->fieldsLayout;
            }
            switch ($fieldLayout) {
                case app_CustomSection::FIELDS_LAYOUT_HORIZONTAL_LABEL:
                    return $W->FlowItems(
                        $W->Label($textLabel)->addClass('crm-horizontal-display-label', 'widget-strong')
                            ->setSizePolicy('widget-25pc'),
                        $widget
                    )->addClass('widget-labelled-widget')
                    ->setHorizontalSpacing(1, 'ex')
                    ->setVerticalAlign('top');

                case app_CustomSection::FIELDS_LAYOUT_WIDE_HORIZONTAL_LABEL:
                    return $W->FlowItems(
                        $W->Label($textLabel)->addClass('crm-horizontal-display-label', 'widget-strong')
                            ->setSizePolicy('widget-50pc'),
                        $widget
                    )->addClass('widget-labelled-widget')
                    ->setHorizontalSpacing(1, 'ex')
                    ->setVerticalAlign('top');

                case app_CustomSection::FIELDS_LAYOUT_NO_LABEL:
                    return $widget;

The expression return $widget returns the type Widget_Label which is incompatible with the documented return type Widget_Layout.

                case app_CustomSection::FIELDS_LAYOUT_VERTICAL_LABEL:
                default:
                    return $W->LabelledWidget($textLabel, $widget);

The expression return $W->LabelledWidget($textLabel, $widget) returns the type Widget_LabelledWidget which is incompatible with the documented return type Widget_Layout.

            }
        }
    }


    function labelledWidgetOptional($textLabel, $displayedValue, $value = null, app_CustomSection $section = null)

It is generally recommended to explicitly declare the visibility for methods.

    {
        if (!isset($value)) {
            $value = $displayedValue;
        }
        if (!isset($value) || is_numeric($value) && $value == 0 || is_string($value) && trim($value) == '' || ($value instanceof Widget_Layout && count($value->getItems()) <= 0)) {
            return null;
        }
        return $this->labelledWidget($textLabel, $displayedValue, $section);
    }



    protected function fieldOutput($field, $record, $fieldName)
    {
        if ($field instanceof ORM_CurrencyField) {
            $App = $this->App();
            $value = $App->shortFormatWithUnit($this->record->$fieldName, $App->translate('_euro_'));
        } else {
            $value = $field->output($this->record->$fieldName);
        }
        return $value;
    }

    protected function addSections($view = '')
    {
        $App = $this->App();
        $W = bab_Widgets();

        $objectName = $this->record->getClassName();

        $customSectionSet = $App->CustomSectionSet();
        $customSections = $customSectionSet->select(
            $customSectionSet->object->is($objectName)->_AND_($customSectionSet->view->is($view))
            );
        $customSections->orderAsc($customSectionSet->rank);

        $currentColumn = 0;
        $nbCol = 0;
        $row = $W->Items()->setSizePolicy('row');
        foreach ($customSections as $customSection) {

            if (isset($this->record) && !$customSection->isVisibleForRecord($this->record)) {
                continue;
            }

            list(, , $nbCol) = explode('-', $customSection->sizePolicy);

            if ($currentColumn + $nbCol > 12) {
                $this->addItem($row);

The method addItem() does not exist on app_RecordView. Since you implemented __call, consider adding a @method annotation.

                $row = $W->Items()->setSizePolicy('row');
                $currentColumn = 0;
            }
            $currentColumn += $nbCol;

            if (strpos($customSection->classname, 'horizontal') !== false) {
                $box = $W->FlowItems()
                    ->setVerticalAlign('top')
                    ->setSpacing(1, 'em');
            } else {
                $box = null;
            }

            $section = $this->getSection($customSection->id);
            if (!isset($section)) {
                $section = $this->addSection($customSection->id, $customSection->name, $box);
                $section->addClass($customSection->classname);
                $section->setSizePolicy($customSection->sizePolicy);

                if ($customSection->editable) {

The property editable does not exist on app_CustomSection. Since you implemented __get, consider adding a @property annotation.

                    $menu = $section->addContextMenu('inline');
                    $menu->addClass(Func_Icons::ICON_LEFT_16);
                    $menu->addItem(
                        $W->Link(
                            '',
                            $this->record->getController()->editSection($this->record->id, $customSection->id)

The method editSection() does not exist on app_Controller. Since you implemented __call, consider adding a @method annotation.

                        )->addClass('widget-actionbutton', 'section-button', 'icon', Func_Icons::ACTIONS_DOCUMENT_EDIT)
                        ->setOpenMode(Widget_Link::OPEN_DIALOG)
                    );
                }

                $section->setFoldable($customSection->foldable, $customSection->folded);
                $row->addItem($section);
            }



            $displayFields = $customSection->getFields();

            foreach ($displayFields as $displayField) {
                $item = null;
                $displayFieldName = $displayField['fieldname'];
                $parameters = $displayField['parameters'];
                $classname = isset($parameters['classname']) ? $parameters['classname'] : '';
                $label = isset($parameters['label']) ? $parameters['label'] : null;
                $sizePolicy = isset($parameters['sizePolicy']) ? $parameters['sizePolicy'] : '';

                $displayFieldMethod = '_' . $displayFieldName;
                if (method_exists($this, $displayFieldMethod)) {
                    $item = $this->$displayFieldMethod($customSection, $label);
                } else {
                    try {
                        $field = $this->recordSet->getField($displayFieldName);
                        $value = $this->fieldOutput($field, $this->record, $displayFieldName);
                        if (!isset($label) || empty($label)) {
                            $label = $App->translate($field->getDescription());
                        }

                        $outputWidget = $field->outputWidget($this->record->$displayFieldName);

The method outputWidget() does not exist on ORM_Field. Did you maybe mean output()?

                        $item = $this->labelledWidgetOptional(
                            $label,
                            $outputWidget,
                            $value,
                            $customSection
                        );
                    } catch (ORM_Exception $e) {
                        $item = null;
                    }
                }
                if (isset($item)) {
                    $item->setSizePolicy($sizePolicy);
                    $item->addClass($classname);
                    $section->addItem($item);
                }
            }
        }

        if ($currentColumn + $nbCol> 0) {
            $this->addItem($row);
        }
    }


    protected function __spacer()
    {
        $W = bab_Widgets();
        return $W->Label('')->addClass('spacer');
    }
}




/**
 * A card frame is a frame with contact informations
 *
 */
class app_CardFrame extends app_UiObject // extends Widget_Frame
{

    const IMAGE_WIDTH = 40;
    const IMAGE_HEIGHT = 40;


    const MAPS_URL = '//maps.google.com/?q=%s';

    const MAPS_ROUTE_URL = '//maps.google.com/maps?saddr=%s&daddr=%s';

    const STATIC_MAPS_URL = '//maps.google.com/maps/api/staticmap?';

    /**
     * @var Widget_Section[] $sections
     */
    protected $sections = array();


    protected $menu = null;





    public function __construct(Func_App $App, $id = null, Widget_Layout $layout = null)
    {
        parent::__construct($App);

        $W = bab_Widgets();

        $this->setInheritedItem($W->Frame($id, $layout));
    }


    /**
     * render a labeled string
     *
     * @param	string | Widget_Item	$label
     * @param	string | Widget_Item	$value
     *
     * @return Widget_Item
     */
    protected function labelStr($label, $value)
    {
        $W = bab_Widgets();

        if (!($label instanceOf Widget_Item)) {
            $label = $W->Label($label);
        }

        if (!($value instanceOf Widget_Displayable_Interface)) {
            $value = $W->Label($value);
        }


        return $W->VBoxItems(
            $label->colon(false)->addClass('crm-display-label'),

The method colon() does not exist on Widget_Item. It seems like you code against a sub-type of Widget_Item such as Widget_Title or Widget_SimpleTreeView or Widget_LabelledWidget or Widget_Label or Widget_InputPassword or Widget_Section or Widget_Form.

            $value->addClass('crm-display-value')
            )->setVerticalAlign('middle')->setVerticalSpacing(3, 'px');
    }

    /**
     * render a labeled string only if value set
     *
     * @param	string | Widget_Item	$label
     * @param	string | Widget_Item	$value
     *
     * @return Widget_Item | null
     */
    protected function labelStrSet($label, $value)
    {
        if (!isset($value) || '' === $value) {
            return null;
        }

        return $this->labelStr($label, $value);
    }


    /**
     * render a labeled string with a field value, if the value is not set, return null
     *
     *
     * @param string $label
     * @param app_Record $record
     * @param ORM_Field $field
     */
    protected function labeledField($label, app_Record $record, ORM_Field $field)
    {
        $W = bab_Widgets();

        $fieldName = $field->getName();
        $value = $record->$fieldName;

        if (!$field->isValueSet($value)) {
            return null;
        }

        $displayable = $field->output($value);

        switch(true) {
            case ($field instanceof ORM_TextField):
                $displayable = $W->RichText($displayable)->setRenderingOptions(BAB_HTML_ALL ^ BAB_HTML_P);
                break;

            case ($field instanceof ORM_UrlField):
                $displayable = $W->Link($displayable, $displayable);
                break;

            case ($field instanceof ORM_EmailField):
                $displayable = $W->Link($displayable, 'mailto:'.$displayable);
                break;

            case ($field instanceof ORM_FkField):
                $record = $record->$fieldName();
                if (!isset($record)) {
                    return null;
                }
                $displayable = $record->getRecordTitle();
                break;
        }

        return $this->labelStr($label, $displayable);
    }





    /**
     * Creates section in the editor.
     * If a section with the same header text (title) was already
     * created it is replaced by an empty section.
     *
     * @param string $headerText
     * @return Widget_Section
     */
    protected function addSection($id, $headerText, $layout = null)
    {
        $W = bab_Widgets();
        if (!isset($layout)) {
            $layout = $W->VBoxLayout()->setVerticalSpacing(1, 'em');
        }
        $this->sections[$id] = $W->Section(
            $headerText,
            $layout
            )->setFoldable(true);

            return $this->sections[$id];
    }

    /**
     * Creates section in the editor.
     * If a section with the same header text (title) was already
     * created it is replaced by an empty section.
     *
     * @param string $headerText
     * @return Widget_Section
     */
    protected function createSection($headerText, $layout = null)
    {
        return $this->addSection($headerText, $headerText, $layout);
    }


    /**
     * Retrieves a section in the editor.
     *
     * @param string $headerText
     * @return Widget_Section
     */
    protected function getSection($id)
    {
        if (!isset($this->sections[$id])) {
            return null;
        }
        return $this->sections[$id];
    }


    /**
     * Returns the list of sections created via createSection().
     *
     * @return Widget_Section[]
     */
    public function getSections()
    {
        return $this->sections;
    }


    /**
     * @param Widget_Displayable_Interface $item
     * @return self
     */
    public function addAction(Widget_Displayable_Interface $item)
    {
        if (!isset($this->menu)) {
            $W = bab_Widgets();
            $this->menu = $W->Menu()
                ->setLayout($W->FlowLayout())
                ->addClass(Func_Icons::ICON_LEFT_SYMBOLIC);

        }
        $this->menu->addItem($item);
        return $this;
    }
}