app_AccessManager

Complexity

Total Complexity

5

Size/Duplication

Total Lines	64
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	App()	0	3	1
A	getAccess()	0	8	1
A	setApp()	0	4	1
A	getAccessCriterion()	0	3	1

<?php
//-------------------------------------------------------------------------
// OVIDENTIA http://www.ovidentia.org
// Ovidentia is free software; you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation; either version 2, or (at your option)
// any later version.
//
// This program is distributed in the hope that it will be useful, but
// WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
// See the GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with this program; if not, write to the Free Software
// Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307,
// USA.
//-------------------------------------------------------------------------
/**
 * @license http://opensource.org/licenses/gpl-license.php GNU General Public License (GPL)
 * @copyright Copyright (c) 2009 by CANTICO ({@link http://www.cantico.fr})
 */




/**
 * The app_AccessManager class
 *
 * @method Func_App App()
 */
class app_AccessManager implements app_Object_Interface
{
    /**
     * @var Func_App
     */
    private $App = null;

The private property $App is not used, and could be removed.

    /**
     * @param Func_App $app
     */
    public function __construct(Func_App $app)
    {
        $this->setApp($app);
    }

    /**
     * Forces the Func_App object to which this object is 'linked'.
     *
     * @param Func_App	$app
     * @return self
     */
    public function setApp(Func_App $app)
    {
        $this->app = $app;

The property app does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        return $this;
    }

    /**
     * Get APP object to use with this SET
     *
     * @return Func_App
     */
    public function App()
    {
        return $this->app;
    }


    /**
     *
     * @param app_RecordSet $recordSet
     * @param string        $accessType
     * @param int           $user
     */
    public function getAccessCriterion(app_RecordSet $recordSet, $accessType, $user = null)

The parameter $accessType is not used and could be removed.

The parameter $user is not used and could be removed.

    {
        return $recordSet->none();
    }

    /**
     *
     * @param app_Record    $record
     * @param string        $accessType
     * @param int           $user
     */
    public function getAccess(app_Record $record, $accessType, $user = null)
    {
        $recordSet = $record->getParentSet();
        $criterion = $this->getAccessCriterion($recordSet, $accessType, $user);

        $matches = $recordSet->select($criterion->_AND_($recordSet->id->is($record->id)));

The property id does not exist on app_Record. Since you implemented __get, consider adding a @property annotation.

The property id does not exist on app_RecordSet. Since you implemented __get, consider adding a @property annotation.

        return ($matches->count() !== 0);
    }
}