Capwelton\LibApp\Ui\AppTableModelView

Complexity

Total Complexity

96

Size/Duplication

Total Lines	713
Duplicated Lines	0 %

Importance

Changes	3
Bugs	0	Features	1

22 Methods

Rating	Name	Duplication	Size	Complexity
A	displayAdvancedForm()	0	4	1
A	handleAdvancedFilterFields()	0	2	1
A	addCustomFields()	0	10	2
A	initRow()	0	11	3
A	isAdvancedFormDisplayed()	0	3	1
A	__construct()	0	5	1
A	setApp()	0	4	1
F	initHeaderRow()	0	105	23
C	filterPanel()	0	66	12
A	isFilterFieldSpecified()	0	20	6
A	App()	0	13	3
B	handleFilterInputWidget()	0	47	7
A	setRecordController()	0	4	1
A	getSearchItem()	0	7	1
A	handleFilterLabel()	0	5	1
A	getFilterFormItem()	0	3	1
A	getRecordControllerProxy()	0	6	2
C	advancedFilterPanel()	0	66	11
D	getAdvancedFilterForm()	0	172	15
A	getFilterLabelWidget()	0	3	1
A	getFilterInputWidget()	0	3	1
A	getRecordController()	0	3	1

<?php

// -------------------------------------------------------------------------
// OVIDENTIA http://www.ovidentia.org
// Ovidentia is free software; you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation; either version 2, or (at your option)
// any later version.
//
// This program is distributed in the hope that it will be useful, but
// WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
// See the GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with this program; if not, write to the Free Software
// Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307,
// USA.
// -------------------------------------------------------------------------
/**
 * @license http://opensource.org/licenses/gpl-license.php GNU General Public License (GPL)
 * @copyright Copyright (c) 2022 by SI4YOU ({@link https://www.siforyou.com})
 */
namespace Capwelton\LibApp\Ui;

use Capwelton\Widgets\Widgets\Abstracts\WidgetItem;

The type Capwelton\Widgets\Widgets\Abstracts\WidgetItem was not found. Maybe you did not declare it correctly or list all dependencies?

use Capwelton\Widgets\Widgets\Form\WidgetForm;

The type Capwelton\Widgets\Widgets\Form\WidgetForm was not found. Maybe you did not declare it correctly or list all dependencies?

use Capwelton\Widgets\Widgets\Interfaces\WidgetDisplayableInterface;

The type Capwelton\Widgets\Widgets\Interfaces\WidgetDisplayableInterface was not found. Maybe you did not declare it correctly or list all dependencies?

use Capwelton\Widgets\Widgets\Item\WidgetFilter;

The type Capwelton\Widgets\Widgets\Item\WidgetFilter was not found. Maybe you did not declare it correctly or list all dependencies?

use Capwelton\Widgets\Widgets\Item\WidgetLabel;

The type Capwelton\Widgets\Widgets\Item\WidgetLabel was not found. Maybe you did not declare it correctly or list all dependencies?

use Capwelton\Widgets\Widgets\Item\WidgetLink;

The type Capwelton\Widgets\Widgets\Item\WidgetLink was not found. Maybe you did not declare it correctly or list all dependencies?

use Capwelton\Widgets\Widgets\Layout\WidgetFlexLayout;

The type Capwelton\Widgets\Widgets\Layout\WidgetFlexLayout was not found. Maybe you did not declare it correctly or list all dependencies?

use Capwelton\Widgets\Widgets\Table\WidgetTableModelView;

The type Capwelton\Widgets\Widgets\Table\WidgetTableModelView was not found. Maybe you did not declare it correctly or list all dependencies?

use Capwelton\Widgets\Widgets\Table\WidgetTableModelViewColumn;

The type Capwelton\Widgets\Widgets\Table\WidgetTableModelViewColumn was not found. Maybe you did not declare it correctly or list all dependencies?

use Capwelton\LibApp\Ctrl\AppCtrlRecord;
use Capwelton\LibApp\Func_App;
use Capwelton\LibApp\Set\AppRecordSet;
use Capwelton\LibOrm\Field\ORMField;

The type Capwelton\LibOrm\Field\ORMField was not found. Maybe you did not declare it correctly or list all dependencies?

use Capwelton\LibOrm\Field\ORMFkField;

The type Capwelton\LibOrm\Field\ORMFkField was not found. Maybe you did not declare it correctly or list all dependencies?

use Capwelton\LibOrm\ORMRecordSet;

The type Capwelton\LibOrm\ORMRecordSet was not found. Maybe you did not declare it correctly or list all dependencies?

use function Capwelton\Widgets\widget_translate;

The function Capwelton\Widgets\widget_translate was not found. Maybe you did not declare it correctly or list all dependencies?

class AppTableModelView extends WidgetTableModelView
{
    
    /**
     * Filter form reset button
     */
    protected $reset = null;
    
    protected $highlightRows = null;
    
    /**
     * @var Func_App
     */
    private $app = null;
    
    /**
     * @var AppCtrlRecord
     */
    protected $recordController = null;
    
    /**
     * @var AppCtrlRecord
     */
    protected $recordControllerProxy = null;
    
    protected $filterBaseUrl = null;
    
    protected $displayAdvancedForm = true;
    
    /**
     * @param Func_App $app
     * @param string $id
     */
    public function __construct(Func_App $app = null, $id = null)
    {
        parent::__construct($id);
        $this->setApp($app);
        $this->displayAdvancedForm(true);
    }
    
    public function displayAdvancedForm($displayAdvancedForm = true)
    {
        $this->displayAdvancedForm = $displayAdvancedForm;
        return $this;
    }
    
    public function isAdvancedFormDisplayed()
    {
        return $this->displayAdvancedForm;
    }
    
    /**
     * Called before data rows
     *
     * @return void
     */
    protected function initHeaderRow(ORMRecordSet $set)
    {
        require_once $GLOBALS['babInstallPath'] . 'utilit/urlincl.php';
        
        \bab_functionality::includefile('Icons');

The method includefile() does not exist on bab_functionality. It seems like you code against a sub-type of bab_functionality such as Capwelton\LibApp\Func_App.

        
        $W = bab_Widgets();
        
        $this->addHeaderSection();
        $this->setCurrentSection('header');
        
        $col = 0;
        
        $this->toggleCheckAllBox = null;

The property toggleCheckAllBox does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->displayedIds = array();

The property displayedIds does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        
        $filterValues = $this->getFilterValues();
        
        foreach ($this->visibleColumns as $columnPath => $column){
            
            if(! isset($this->columnsDescriptions[$columnPath])){
                $this->columnsDescriptions[$columnPath] = $column->getDescription();

The property columnsDescriptions does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            }
            
            $columnLabel = $this->columnsDescriptions[$columnPath];
            
            $columnIcon = $column->getIcon();
            $isSortable = $column->isSortable();
            $isSearchable = $column->isSearchable() && $this->getFilterInputWidget($columnPath, $column->getField());
            
            $sizePolicy = 'widget-actions-target';
            
            if($this->isMultiSelect() && $columnPath === '_select_'){
                $this->toggleCheckAllBox = $W->CheckBox();
                $this->toggleCheckAllBox->setName('toggleCheckAllBox');
                $this->toggleCheckAllBox->setTitle(widget_translate('Select all on page'));
                $this->toggleCheckAllBox->setSizePolicy('condensed');
                $this->toggleCheckAllBox->setCheckedValue(true);

true of type true is incompatible with the type string expected by parameter $value of Widget_CheckBox::setCheckedValue().

                if(isset($_SESSION['toggleCheckAllBox'][$this->getId()]) && ! empty($_SESSION['toggleCheckAllBox'][$this->getId()]) && $_SESSION['toggleCheckAllBox'][$this->getId()] == 'on'){
                    $this->toggleCheckAllBox->setValue(true);
                }
                $isSearchable = false;
                $isSortable = false;
                $columnItem = $W->FlexItems($this->toggleCheckAllBox);

The method FlexItems() does not exist on Func_Widgets.

            }
            elseif(isset($this->sortParameterName) && self::getRecordSetField($set, $columnPath) && $isSortable){
                if(! isset($this->sortBaseUrl)){
                    $this->sortBaseUrl = \bab_url::request_gp();

The property sortBaseUrl does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

                }
                
                if($this->sortField === $columnPath && $this->sortAscending){
                    $direction = ':down';
                }
                else{
                    $direction = ':up';
                }
                
                $url = \bab_url::mod($this->sortBaseUrl, $this->sortParameterName, $columnPath . $direction);
                if($anchor = $this->getAnchor()){
                    $url .= '#' . urlencode($anchor);
                }
                
                $columnItem = $W->Link($W->FlexItems($W->Label($columnLabel), $W->Items()
                    ->addClass('widget-table-column-sorting-icons'))
                    ->setAlignItems(WidgetFlexLayout::FLEX_ALIGN_CONTENT_CENTER), $url)
                    ->addClass('widget-table-column-sorting-action');
                if($this->sortAjaxAction){
                    $columnItem->setAjaxAction($this->sortAjaxAction->setParameter('sort', $columnPath . $direction), '');
                }
                $columnItem = $W->FlexItems($columnItem);
            }
            else{
                $columnItem = $W->FlexItems($W->Label($columnLabel), $W->Label(''));
            }
            
            $columnItem->setAlignItems(WidgetFlexLayout::FLEX_ALIGN_CONTENT_CENTER)->setJustifyContent(WidgetFlexLayout::FLEX_JUSTIFY_CONTENT_SPACE_BETWEEN);
            $columnItem->addClass('widget-table-column-header-item');
            
            if(isset($columnIcon)){
                $columnItem->addClass('icon', $columnIcon)->setSizePolicy(\Func_Icons::ICON_LEFT_16);
            }
            
            if($isSortable){
                $sizePolicy .= ' widget-table-column-sortable';
            }
            if($isSearchable){
                if(! isset($this->filterBaseUrl)){
                    $this->filterBaseUrl = $this->getRecordControllerProxy()->displayListFilter();
                }
                $url = $this->filterBaseUrl;
                $url->setParameter('col', $columnPath);
                $url->setParameter('key', $this->getId());
                $columnItem->addItem($W->Link('', $url->url())
                    ->setOpenMode(WidgetLink::OPEN_DIALOG)
                    ->addClass('widget-table-column-search-action')
                    ->setDialogClass('box blue'), 0);

The method setDialogClass() does not exist on Widget_Link.

                $sizePolicy .= ' widget-table-column-searchable';
                if(isset($filterValues[$columnPath]) && ! empty($filterValues[$columnPath])){
                    $sizePolicy .= ' widget-table-column-searched';
                }
            }
            $items = $W->Items()->setSizePolicy($sizePolicy);
            $items->addItem($columnItem);
            
            $this->addItem($items, 0, $col ++);
        }
    }
    
    protected function initRow($record, $row)
    {
        if($this->highlightRows == null){
            $this->highlightRows = $this->getHighlightedRows();
        }
        
        if(in_array($record->id, $this->highlightRows)){
            $this->addRowClass($row, "app_highlightRow");
        }
        $this->addRowClass($row, "app_highlightAvailable");
        return parent::initRow($record, $row);
    }
    
    /**
     * Forces the \Func_App object to which this object is 'linked'.
     *
     * @param Func_App $app
     * @return self
     */
    public function setApp(Func_App $app = null)
    {
        $this->app = $app;
        return $this;
    }
    
    /**
     * Get App object to use with this SET
     *
     * @return Func_App
     */
    public function App()
    {
        if(! isset($this->app)){
            // If the app object was not specified (through the setApp() method)
            // we try to select one according to the classname prefix.
            list ($prefix) = explode('_', get_class($this));
            $functionalityName = ucwords($prefix);
            $this->app = @\bab_functionality::get('App/' . $functionalityName);

@bab_functionality::get('App/' . $functionalityName) is of type bab_functionality, but the property $app was declared to be of type Capwelton\LibApp\Func_App. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

            if(! $this->app){
                $this->app = @\bab_functionality::get('App');
            }
        }
        return $this->app;
    }
    
    protected function addCustomFields(AppRecordSet $recordSet)
    {
        $customFields = $recordSet->getCustomFields();
        
        foreach ($customFields as $customField){
            $fieldname = $customField->fieldname;
            $this->addColumn(app_TableModelViewColumn($recordSet->$fieldname, $customField->name)->setSortable(true)
                ->setExportable(true)
                ->setSearchable($customField->searchable)
                ->setVisible($customField->visible));
        }
    }
    
    /**
     * Get a generic filter panel
     * Use setPageLength to define the default number of items per page
     *
     * @param array $filter
     *            Filter values
     * @param string $name
     *            filter form name
     * @param string $anchor
     *            anchor in destination page of filter, the can be a WidgetTab id
     * @return WidgetFilter
     */
    public function filterPanel($filter = null, $name = null)
    {
        $W = bab_Widgets();
        
        $filterPanel = $W->Filter();
        $filterPanel->setLayout($W->VBoxLayout());
        if(isset($name)){
            $filterPanel->setName($name);
        }
        
        $pageLength = $this->getPageLength();
        if(null === $pageLength){
            $pageLength = 15;
        }
        
        $pageNumber = $this->getCurrentPage();
        if(null === $pageNumber){
            $pageNumber = 0;
        }
        
        $this->setPageLength(isset($filter['pageSize']) ? $filter['pageSize'] : $pageLength);
        $this->setCurrentPage(isset($filter['pageNumber']) ? $filter['pageNumber'] : $pageNumber);
        
        if(isset($name)){
            $this->sortParameterName = $name . '[filter][sort]';

The property sortParameterName does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        }
        else{
            $this->sortParameterName = 'filter[sort]';
        }
        
        if(isset($filter['sort'])){
            $this->setSortField($filter['sort']);
        }
        elseif(! isset($this->sortField)){
            
            if(method_exists($this, 'getDefaultSortField')){
                $this->setSortField($this->getDefaultSortField());
            }
            else{
                $columns = $this->getVisibleColumns();
                $sortField = key($columns);
                $this->setSortField($sortField);
            }
        }
        
        $form = $this->getFilterForm();
        
        if(isset($filter)){
            if(isset($name)){
                $path = array(
                    $name,
                    'filter'
                );
            }
            else{
                $path = array(
                    'filter'
                );
            }
            $form->setValues($filter, $path);
        }
        
        $filterPanel->setFilter($form);
        $filterPanel->setFiltered($this);
        
        return $filterPanel;

The expression return $filterPanel returns the type Widget_Filter which is incompatible with the documented return type Capwelton\Widgets\Widgets\Item\WidgetFilter.

    }
    
    /**
     * Add the filter fields to the filter form
     *
     * @param WidgetForm $form
     *
     */
    protected function handleAdvancedFilterFields(WidgetItem $form)
    {
    }
    
    protected function isFilterFieldSpecified($filter, $fieldPath)
    {
        if(isset($filter[$fieldPath])){
            $value = $filter[$fieldPath];
            if(is_array($value)){
                foreach ($value as $val){
                    $val = trim($val);
                    if(! empty($val)){
                        return true;
                    }
                }
                return false;
            }
            
            if(trim($value) !== ''){
                return true;
            }
        }
        
        return false;
    }
    
    protected function handleFilterInputWidget($name, ORMField $field = null)
    {
        if(null === $field){
            return null;
        }
        
        $W = bab_Widgets();
        
        if($field instanceof ORMFkField){            
            $App = $this->App();
            $setName = $field->getForeignSetName();
            
            $pos = strrpos($setName, '\\');
            if($pos === false){
                list (, $appSetName) = explode('_', $setName);
            }
            else{
                list (, $appSetName) = array(
                    substr($setName, 0, $pos),
                    substr($setName, $pos + 1)
                );
            }
            
            $set = $App->$appSetName();
            $set->setName($field->getName());
            $set->setDescription($field->getDescription());
            
            if($set === null){
                return null;
            }
            
            $values = $set->select();
            if($values->count()>15){
                $widget = bab_Widgets()->select2();

The method select2() does not exist on Func_Widgets.

                $widget->setDataSource($set->getController()->search());
            }else{
                $widget = $W->Select();
                $widget->addOption('', '');
                foreach ($values as $record){
                    $widget->addOption($record->id, (string) $record->name);
                }
                
            }
            return $widget;
        }
        
        return parent::handleFilterInputWidget($name, $field);
    }
    
    public function getFilterInputWidget($name, ORMField $field = null)
    {
        return $this->handleFilterInputWidget($name, $field);
    }
    
    public function getFilterLabelWidget($name, ORMField $field = null)
    {
        return $this->handleFilterLabelWidget($name, $field);
    }
    
    public function getFilterFormItem($name, ORMField $field = null)
    {
        return $this->handleFilterLabel($this->getFilterLabelWidget($name, $field), $this->getFilterInputWidget($name, $field));

It seems like $this->getFilterInputWidget($name, $field) can also be of type null; however, parameter $input of Capwelton\LibApp\Ui\AppTableModelView::handleFilterLabel() does only seem to accept Capwelton\Widgets\Widgets\Interfaces\WidgetDisplayableInterface, maybe add an additional type check?

    }
    
    /**
     * Handle label and input widget merge in one item before adding to the filter form
     * default is a vertical box layout
     *
     * @param WidgetLabel $label
     * @param WidgetDisplayableInterface $input
     * @return WidgetItem
     */
    protected function handleFilterLabel(WidgetLabel $label, WidgetDisplayableInterface $input)
    {
        $W = bab_Widgets();
        
        return $W->FlowItems($W->LabelledWidget($label->getText(), $input));

The expression return $W->FlowItems($W->LabelledWidget($label->getText(), $input)) returns the type Widget_FlowLayout which is incompatible with the documented return type Capwelton\Widgets\Widgets\Abstracts\WidgetItem.

    }
    
    protected function getSearchItem()
    {
        $W = bab_Widgets();
        
        return $W->LineEdit()
            ->setName('search')
            ->addClass('widget-100pc');
    }
    
    /**
     * Get an advanced form filter
     *
     * @see WidgetFilter
     *
     * @param string $id
     * @param array $filter
     *
     * @return WidgetForm
     */
    public function getAdvancedFilterForm($id = null, $filter = null)
    {
        $App = $this->App();
        
        $W = bab_Widgets();
        
        $formItem = $this->getSearchItem();
        
        $activeFiltersFrame = $W->Frame(null, $W->FlowItems($W->VBoxItems($W->Label($App->translate('Search'))
            ->setAssociatedWidget($formItem), $formItem))
            ->setHorizontalSpacing(2, 'em')
            ->setVerticalSpacing(1, 'em')
            ->setVerticalAlign('bottom'));
        
        $addFilterButton = $W->Link($App->translate('More criteria'), $this->getRecordControllerProxy()
            ->displayListMoreCriteria($this->getId()))
            ->addClass('widget-actionbutton')
            ->setIcon(\Func_Icons::ACTIONS_LIST_ADD)
            ->setOpenMode(WidgetLink::OPEN_DIALOG)
            ->setDialogClass('box gradient blue app-morecriteria-dialog');
        
        $displayAdvancedForm = $this->isAdvancedFormDisplayed();
        $advancedFiltersFrame = $W->VBoxItems($addFilterButton)->addClass('widget-instant-container');
            
        if($displayAdvancedForm){
            $filterBox = $W->FlowLayout()
                ->addClass('widget-instant-form')
                ->setHorizontalSpacing(2, 'em')
                ->setVerticalSpacing(1, 'em')
                ->setVerticalAlign('bottom');
            $advancedFiltersFrame->addItem($filterBox);
        }
        
        $columns = $this->getVisibleColumns();
        
        foreach ($columns as $fieldName => $column){
            $field = $column->getField();
            if(! $column->isSearchable()){
                continue;
            }
            
            if(! ($field instanceof ORMField)){
                $field = null;
            }
            
            $label = $this->handleFilterLabelWidget($fieldName, $field);
            $input = $this->handleFilterInputWidget($fieldName, $field);
            
            if(isset($input) && isset($label)){
                
                $input->setName($fieldName);
                $label->setAssociatedWidget($input);
                
                $input->addClass('widget-100pc');
                
                $formItem = $this->handleFilterLabel($label, $input);
                
                // $formItem = $W->Section($label->getText(), $input, 7)->setFoldable(true, true);
                $formItem->addClass('compact', 'field_' . $fieldName);
                
                $mainSearch = (method_exists($column, 'isMainSearch') && $column->isMainSearch());
                
                if($mainSearch || $this->isFilterFieldSpecified($filter, $column->getFieldPath())){
                    
                    $removeColumnsAction = $W->Action();
                    $removeColumnsAction->setMethod('addon/widgets/configurationstorage', 'removeFilter', array(
                        'key' => $this->getId(),
                        'name' => $column->getFieldPath(),
                        'insession' => $this->isConfigurationStorageInSession()
                    ));
                    
                    // $formItem->setFoldable(false);
                    $activeFiltersFrame->addItem($W->FlexItems($formItem, $W->Link('', $removeColumnsAction)
                        ->setAjaxAction()
                        ->addClass('icon', \Func_Icons::STATUS_DIALOG_ERROR)
                        ->addAttribute('data-removefor', $column->getFieldPath()))
                        ->setAlignItems(WidgetFlexLayout::FLEX_ALIGN_ITEMS_FLEX_END));
                }
                elseif($displayAdvancedForm){
                    $formItem->setSizePolicy('col-lg-2 col-md-3 col-sm-6 col-xs-12');
                    $filterBox->addItem($formItem);

The variable $filterBox does not seem to be defined for all execution paths leading up to this point.

                }
            }
        }
        
        if(! $this->submit){
            $this->submit = $W->SubmitButton();

The property submit does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            $this->submit->setLabel(Widget_translate('Apply filter'));
        }
        
        if($controller = $this->getRecordController()){
            $proxy = $controller->proxy();
            $this->reset = $W->Link($App->translate('Reset'), $proxy->resetFilters())

$proxy->resetFilters() of type true is incompatible with the type Widget_Action|bab_url|string expected by parameter $url of Func_Widgets::Link().

                ->addClass('icon', \Func_Icons::ACTIONS_VIEW_REFRESH, 'widget-actionbutton')
                ->setTitle($App->translate('Reset filter to default values'))
                ->setAjaxAction();
            
            // $this->save = $W->Link(
            // $App->translate('Save'),
            // $proxy->confirmSaveCurrentFilter()
            // )->addClass('icon', \Func_Icons::ACTIONS_DOCUMENT_SAVE, 'widget-actionbutton')
            // ->setTitle($App->translate('Save current filter'))
            // ->setOpenMode(WidgetLink::OPEN_DIALOG_AND_RELOAD);
            
            // $this->select = null;
            
            $this->filterMenu = $W->Menu(null, $W->VBoxItems());

The property filterMenu does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            $this->filterMenu->setButtonClass('widget-actionbutton icon actions-list-filter');
            $this->filterMenu->setButtonLabel($App->translate('Saved filters'));
            $this->filterMenu->addClass(\Func_Icons::ICON_LEFT_16);
            
            $filterNames = $controller->getFilterNames();
            if(count($filterNames) > 0){
                // $this->select = $W->Menu(null, $W->VBoxItems());
                // $this->select->setButtonClass('widget-link icon actions-list-filter');
                // $this->select->setButtonLabel($App->translate('Saved filters'));
                // $this->select->addClass(\Func_Icons::ICON_LEFT_16);
                
                foreach ($filterNames as $filterName){
                    $filter = $W->getUserConfiguration($controller->getModelViewDefaultId() . '/filters/' . $filterName, 'widgets', false);
                    
                    // $this->select->addItem(
                    // $W->Link(
                    // $filterName,
                    // $proxy->setCurrentFilterName($filterName)
                    // )->setTitle($filter['description'])
                    // );
                    
                    $this->filterMenu->addItem($W->Link($filterName, $proxy->setCurrentFilterName($filterName))
                        ->setTitle($filter['description'])
                        ->setAjaxAction());
                }
                // $this->select->addSeparator();
                // $this->select->addItem(
                // $W->Link(
                // $App->translate('Manage filters'),
                // $proxy->manageFilters()
                // )->addClass('icon', \Func_Icons::ACTIONS_DOCUMENT_PROPERTIES)
                // ->setOpenMode(WidgetLink::OPEN_DIALOG_AND_RELOAD)
                // );
                
                $this->filterMenu->addSeparator();
                $this->filterMenu->addItem($W->Link($App->translate('Manage filters...'), $proxy->manageFilters())
                    ->addClass('icon', \Func_Icons::ACTIONS_DOCUMENT_PROPERTIES)
                    ->setOpenMode(WidgetLink::OPEN_DIALOG));
                $this->filterMenu->addSeparator();
            }
            
            $this->filterMenu->addItem($W->Link($App->translate('Save current filter...'), $proxy->confirmSaveCurrentFilter())
                ->addClass('icon', \Func_Icons::ACTIONS_DOCUMENT_SAVE)
                ->setOpenMode(WidgetLink::OPEN_DIALOG));
        }
        
        $form = $W->Form($id);
        $form->setReadOnly(true);
        $form->setName('filter');
        $form->colon();
        $form->checkUnsaved(false, null);
        
        $form->setLayout($W->FlowItems($activeFiltersFrame, $W->FlowItems($advancedFiltersFrame, $this->submit, $W->FlowItems($this->reset, $this->filterMenu) // $this->save,
        // $this->select,
        )
            ->setHorizontalSpacing(2, 'em')
            ->setVerticalSpacing(1, 'em'))
            ->setVerticalSpacing(1, 'em')
            ->setVerticalAlign('bottom')
            ->addClass(\Func_Icons::ICON_LEFT_16));
        
        $form->setHiddenValue('tg', $App->controllerTg);
        $form->setAnchor($this->getAnchor());
        
        return $form;

The expression return $form returns the type Widget_Form which is incompatible with the documented return type Capwelton\Widgets\Widgets\Form\WidgetForm.

    }
    
    /**
     * Get a advanced filter panel
     * Use setPageLength to define the default number of items per page
     *
     * @param array $filter
     *            Filter values
     * @param string $name
     *            filter form name
     * @param string $anchor
     *            anchor in destination page of filter, the can be a WidgetTab id
     * @return WidgetFilter
     */
    public function advancedFilterPanel($filter = null, $name = null)
    {
        $W = bab_Widgets();
        
        $filterPanel = $W->Filter();
        $filterPanel->setLayout($W->VBoxLayout());
        if(isset($name)){
            $filterPanel->setName($name);
        }
        
        $pageLength = $this->getPageLength();
        if(null === $pageLength){
            $pageLength = 15;
        }
        
        $pageNumber = $this->getCurrentPage();
        if(null === $pageNumber){
            $pageNumber = 0;

The assignment to $pageNumber is dead and can be removed.

        }
        
        $this->setPageLength(isset($filter['pageSize']) ? $filter['pageSize'] : $pageLength);
        // $this->setCurrentPage(isset($filter['pageNumber']) ? $filter['pageNumber'] : $pageNumber);
        
        if(isset($name)){
            $this->sortParameterName = $name . '[filter][sort]';

The property sortParameterName does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        }
        else{
            $this->sortParameterName = 'filter[sort]';
        }
        
        if(isset($filter['sort'])){
            $this->setSortField($filter['sort']);
        }
        elseif(! isset($this->sortField)){
            
            if(method_exists($this, 'getDefaultSortField')){
                $this->setSortField($this->getDefaultSortField());
            }
            else{
                $columns = $this->getVisibleColumns();
                $sortField = key($columns);
                $this->setSortField($sortField);
            }
        }
        
        $form = $this->getAdvancedFilterForm(null, $filter);
        
        if(isset($filter)){
            if(isset($name)){
                $path = array(
                    $name,
                    'filter'
                );
            }
            else{
                $path = array(
                    'filter'
                );
            }
            $form->setValues($filter, $path);
        }
        
        $filterPanel->setFilter($form);
        $filterPanel->setFiltered($this);
        
        return $filterPanel;

The expression return $filterPanel returns the type Widget_Filter which is incompatible with the documented return type Capwelton\Widgets\Widgets\Item\WidgetFilter.

    }
    
    /**
     * @param AppCtrlRecord $recordController
     * @return self
     */
    public function setRecordController(AppCtrlRecord $recordController)
    {
        $this->recordController = $recordController;
        return $this;
    }
    
    /**
     * @return AppCtrlRecord
     */
    public function getRecordController()
    {
        return $this->recordController;
    }
    
    /**
     * @return AppCtrlRecord
     */
    public function getRecordControllerProxy()
    {
        if(! isset($this->recordControllerProxy)){
            $this->recordControllerProxy = $this->getRecordController()->proxy();
        }
        return $this->recordControllerProxy;
    }
}

/**
 * @param string|ORMField $field
 * @param string|null $description
 *
 * @return WidgetTableModelViewColumn
 */
function app_TableModelViewColumn($field, $description = null)
{
    if(null === $field){

The condition null === $field is always false.

        return null;
    }
    
    if(! isset($description) && $field instanceof ORMField){
        $App = $field->getParentSet()->App();
        $description = $App->translate($field->getDescription());
    }
    
    return new WidgetTableModelViewColumn($field, $description);
}